9pfs: Stop including gstrfuncs.h

[PATCH v2] 9pfs: Stop including gstrfuncs.h

Posted by Peter Foley 5 months ago

gstrfuncs.h is not intended to be included directly.
In fact this only works because glib.h is already included by osdep.h.
Just remove the include.

Signed-off-by: Peter Foley <pefoley@google.com>
---
Changes in v2:
- Just remove the include entirely in favor of osdep.h
- Link to v1: https://lore.kernel.org/qemu-devel/20250904-9p-v1-1-e634cb374c80@google.com
---
 hw/9pfs/9p-util-generic.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hw/9pfs/9p-util-generic.c b/hw/9pfs/9p-util-generic.c
index 4c1e9c887d00c44bc073bec00c07ed09d3868bf5..b71fa2cb3785349c6b4d2b9591f5ea4f917844d0 100644
--- a/hw/9pfs/9p-util-generic.c
+++ b/hw/9pfs/9p-util-generic.c
@@ -2,7 +2,6 @@
 
 #include "qemu/osdep.h"
 #include "9p-util.h"
-#include <glib/gstrfuncs.h>
 
 char *qemu_open_flags_tostr(int flags)
 {

---
base-commit: baa79455fa92984ff0f4b9ae94bed66823177a27
change-id: 20250904-9p-11c0405ae7c5

Best regards,
-- 
Peter Foley <pefoley@google.com>

Re: [PATCH v2] 9pfs: Stop including gstrfuncs.h

Posted by Christian Schoenebeck 5 months ago

On Friday, September 5, 2025 5:17:11 PM CEST Peter Foley wrote:
> gstrfuncs.h is not intended to be included directly.
> In fact this only works because glib.h is already included by osdep.h.
> Just remove the include.
> 
> Signed-off-by: Peter Foley <pefoley@google.com>
> ---

Queued on 9p.next:
https://github.com/cschoenebeck/qemu/commits/9p.next

Thanks!

/Christian

Re: [PATCH v2] 9pfs: Stop including gstrfuncs.h

Posted by Richard Henderson 5 months ago

On 9/5/25 17:17, Peter Foley wrote:
> gstrfuncs.h is not intended to be included directly.
> In fact this only works because glib.h is already included by osdep.h.
> Just remove the include.
> 
> Signed-off-by: Peter Foley <pefoley@google.com>

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~

> ---
> Changes in v2:
> - Just remove the include entirely in favor of osdep.h
> - Link to v1: https://lore.kernel.org/qemu-devel/20250904-9p-v1-1-e634cb374c80@google.com
> ---
>   hw/9pfs/9p-util-generic.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/hw/9pfs/9p-util-generic.c b/hw/9pfs/9p-util-generic.c
> index 4c1e9c887d00c44bc073bec00c07ed09d3868bf5..b71fa2cb3785349c6b4d2b9591f5ea4f917844d0 100644
> --- a/hw/9pfs/9p-util-generic.c
> +++ b/hw/9pfs/9p-util-generic.c
> @@ -2,7 +2,6 @@
>   
>   #include "qemu/osdep.h"
>   #include "9p-util.h"
> -#include <glib/gstrfuncs.h>
>   
>   char *qemu_open_flags_tostr(int flags)
>   {
> 
> ---
> base-commit: baa79455fa92984ff0f4b9ae94bed66823177a27
> change-id: 20250904-9p-11c0405ae7c5
> 
> Best regards,