9pfs: Include glib.h

[PATCH] 9pfs: Include glib.h

Peter Foley posted 1 patch 1 day, 21 hours ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20250904-9p-v1-1-e634cb374c80@google.com

Maintainers: Christian Schoenebeck <qemu_oss@crudebyte.com>, Greg Kurz <groug@kaod.org>

hw/9pfs/9p-util-generic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] 9pfs: Include glib.h

Posted by Peter Foley 1 day, 21 hours ago

gstrfuncs.h is not intended to be included directly.

Signed-off-by: Peter Foley <pefoley@google.com>
---
 hw/9pfs/9p-util-generic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/9pfs/9p-util-generic.c b/hw/9pfs/9p-util-generic.c
index 4c1e9c887d00c44bc073bec00c07ed09d3868bf5..93c38e40f693a945f979ca89555cd9b1ea3175d6 100644
--- a/hw/9pfs/9p-util-generic.c
+++ b/hw/9pfs/9p-util-generic.c
@@ -2,7 +2,7 @@
 
 #include "qemu/osdep.h"
 #include "9p-util.h"
-#include <glib/gstrfuncs.h>
+#include <glib.h>
 
 char *qemu_open_flags_tostr(int flags)
 {

---
base-commit: baa79455fa92984ff0f4b9ae94bed66823177a27
change-id: 20250904-9p-11c0405ae7c5

Best regards,
-- 
Peter Foley <pefoley@google.com>

Re: [PATCH] 9pfs: Include glib.h

Posted by Paolo Bonzini 1 day, 5 hours ago

On 9/4/25 16:30, Peter Foley wrote:
> gstrfuncs.h is not intended to be included directly.

Indeed -- it works only because qemu/osdep.h actually already includes 
glib.h.  So the line can be removed altogether.

Thanks for looking at these papercuts and bringing attention to the QEMU 
upstream developers.

Paolo

> Signed-off-by: Peter Foley <pefoley@google.com>
> ---
>   hw/9pfs/9p-util-generic.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/9pfs/9p-util-generic.c b/hw/9pfs/9p-util-generic.c
> index 4c1e9c887d00c44bc073bec00c07ed09d3868bf5..93c38e40f693a945f979ca89555cd9b1ea3175d6 100644
> --- a/hw/9pfs/9p-util-generic.c
> +++ b/hw/9pfs/9p-util-generic.c
> @@ -2,7 +2,7 @@
>   
>   #include "qemu/osdep.h"
>   #include "9p-util.h"
> -#include <glib/gstrfuncs.h>
> +#include <glib.h>
>   
>   char *qemu_open_flags_tostr(int flags)
>   {
> 
> ---
> base-commit: baa79455fa92984ff0f4b9ae94bed66823177a27
> change-id: 20250904-9p-11c0405ae7c5
> 
> Best regards,