[PATCH 11/24] accel/hvf: Mention hvf_arch_update_guest_debug() must run on vCPU

Philippe Mathieu-Daudé posted 24 patches 5 months, 1 week ago
There is a newer version of this series
[PATCH 11/24] accel/hvf: Mention hvf_arch_update_guest_debug() must run on vCPU
Posted by Philippe Mathieu-Daudé 5 months, 1 week ago
Since hvf_arch_update_guest_debug() calls hvf_arch_set_traps()
and hvf_arch_update_guest_debug(), which must run on a vCPU, it
also must. Mention it.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 include/system/hvf_int.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/system/hvf_int.h b/include/system/hvf_int.h
index 0c335facc3b..241c668795e 100644
--- a/include/system/hvf_int.h
+++ b/include/system/hvf_int.h
@@ -83,6 +83,8 @@ int hvf_arch_vcpu_exec(CPUState *);
 int hvf_arch_put_registers(CPUState *);
 /* Must be called by the owning thread */
 int hvf_arch_get_registers(CPUState *);
+/* Must be called by the owning thread */
+void hvf_arch_update_guest_debug(CPUState *cpu);
 
 struct hvf_sw_breakpoint {
     vaddr pc;
@@ -109,7 +111,6 @@ void hvf_arch_remove_all_hw_breakpoints(void);
  * handled by calling down to hvf_arch_update_guest_debug.
  */
 int hvf_update_guest_debug(CPUState *cpu);
-void hvf_arch_update_guest_debug(CPUState *cpu);
 
 /*
  * Return whether the guest supports debugging.
-- 
2.51.0


Re: [PATCH 11/24] accel/hvf: Mention hvf_arch_update_guest_debug() must run on vCPU
Posted by Mads Ynddal 5 months ago
> On 3 Sep 2025, at 12.06, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
> 
> Since hvf_arch_update_guest_debug() calls hvf_arch_set_traps()
> and hvf_arch_update_guest_debug(), which must run on a vCPU, it
> also must. Mention it.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> include/system/hvf_int.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Mads Ynddal <mads@ynddal.dk>