1. Patchew
  2. QEMU
  3. [PATCH 0/3] tests/functional: improve handling flaky downloads
  4. View patch

[PATCH 1/3] tests/functional: enable force refresh of cached assets

Daniel P. Berrangé posted 3 patches 1 month ago
Maintainers: Thomas Huth <thuth@redhat.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, "Daniel P. Berrangé" <berrange@redhat.com>
There is a newer version of this series
[PATCH 1/3] tests/functional: enable force refresh of cached assets
Posted by Daniel P. Berrangé 1 month ago 
If the 'QEMU_TEST_REFRESH_CACHE' environment variable is set, then
ignore any existing cached asset and download a fresh copy.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 docs/devel/testing/functional.rst   | 3 +++
 tests/functional/qemu_test/asset.py | 4 ++++
 2 files changed, 7 insertions(+)

diff --git a/docs/devel/testing/functional.rst b/docs/devel/testing/functional.rst
index 3728bab6c0..fdeaebaadc 100644
--- a/docs/devel/testing/functional.rst
+++ b/docs/devel/testing/functional.rst
@@ -312,6 +312,9 @@ The cache is populated in the ``~/.cache/qemu/download`` directory by
 default, but the location can be changed by setting the
 ``QEMU_TEST_CACHE_DIR`` environment variable.
 
+To force the test suite to re-download the cache, even if still valid,
+set the ``QEMU_TEST_REFRESH_CACHE`` environment variable.
+
 Skipping tests
 --------------
 
diff --git a/tests/functional/qemu_test/asset.py b/tests/functional/qemu_test/asset.py
index 704b84d0ea..b5a6136d36 100644
--- a/tests/functional/qemu_test/asset.py
+++ b/tests/functional/qemu_test/asset.py
@@ -72,6 +72,10 @@ def _check(self, cache_file):
         return self.hash == hl.hexdigest()
 
     def valid(self):
+        if os.getenv("QEMU_TEST_REFRESH_CACHE", None) is not None:
+            self.log.info("Force refresh of asset %s", self.url)
+            return False
+
         return self.cache_file.exists() and self._check(self.cache_file)
 
     def fetchable(self):
-- 
2.50.1
Re: [PATCH 1/3] tests/functional: enable force refresh of cached assets
Posted by Thomas Huth 1 month ago 
On 29/08/2025 10.31, Daniel P. Berrangé wrote:
> If the 'QEMU_TEST_REFRESH_CACHE' environment variable is set, then
> ignore any existing cached asset and download a fresh copy.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>   docs/devel/testing/functional.rst   | 3 +++
>   tests/functional/qemu_test/asset.py | 4 ++++
>   2 files changed, 7 insertions(+)
> 
> diff --git a/docs/devel/testing/functional.rst b/docs/devel/testing/functional.rst
> index 3728bab6c0..fdeaebaadc 100644
> --- a/docs/devel/testing/functional.rst
> +++ b/docs/devel/testing/functional.rst
> @@ -312,6 +312,9 @@ The cache is populated in the ``~/.cache/qemu/download`` directory by
>   default, but the location can be changed by setting the
>   ``QEMU_TEST_CACHE_DIR`` environment variable.
>   
> +To force the test suite to re-download the cache, even if still valid,
> +set the ``QEMU_TEST_REFRESH_CACHE`` environment variable.
> +
>   Skipping tests
>   --------------
>   
> diff --git a/tests/functional/qemu_test/asset.py b/tests/functional/qemu_test/asset.py
> index 704b84d0ea..b5a6136d36 100644
> --- a/tests/functional/qemu_test/asset.py
> +++ b/tests/functional/qemu_test/asset.py
> @@ -72,6 +72,10 @@ def _check(self, cache_file):
>           return self.hash == hl.hexdigest()
>   
>       def valid(self):
> +        if os.getenv("QEMU_TEST_REFRESH_CACHE", None) is not None:
> +            self.log.info("Force refresh of asset %s", self.url)
> +            return False
> +

Do we really need this? You can also simply "rm ~/.cache/qemu/downloads" 
instead, or click on the "Clear runner caches" in the gitlab CI.

  Thomas
Re: [PATCH 1/3] tests/functional: enable force refresh of cached assets
Posted by Daniel P. Berrangé 1 month ago 
On Fri, Aug 29, 2025 at 10:50:41AM +0200, Thomas Huth wrote:
> On 29/08/2025 10.31, Daniel P. Berrangé wrote:
> > If the 'QEMU_TEST_REFRESH_CACHE' environment variable is set, then
> > ignore any existing cached asset and download a fresh copy.
> > 
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > ---
> >   docs/devel/testing/functional.rst   | 3 +++
> >   tests/functional/qemu_test/asset.py | 4 ++++
> >   2 files changed, 7 insertions(+)
> > 
> > diff --git a/docs/devel/testing/functional.rst b/docs/devel/testing/functional.rst
> > index 3728bab6c0..fdeaebaadc 100644
> > --- a/docs/devel/testing/functional.rst
> > +++ b/docs/devel/testing/functional.rst
> > @@ -312,6 +312,9 @@ The cache is populated in the ``~/.cache/qemu/download`` directory by
> >   default, but the location can be changed by setting the
> >   ``QEMU_TEST_CACHE_DIR`` environment variable.
> > +To force the test suite to re-download the cache, even if still valid,
> > +set the ``QEMU_TEST_REFRESH_CACHE`` environment variable.
> > +
> >   Skipping tests
> >   --------------
> > diff --git a/tests/functional/qemu_test/asset.py b/tests/functional/qemu_test/asset.py
> > index 704b84d0ea..b5a6136d36 100644
> > --- a/tests/functional/qemu_test/asset.py
> > +++ b/tests/functional/qemu_test/asset.py
> > @@ -72,6 +72,10 @@ def _check(self, cache_file):
> >           return self.hash == hl.hexdigest()
> >       def valid(self):
> > +        if os.getenv("QEMU_TEST_REFRESH_CACHE", None) is not None:
> > +            self.log.info("Force refresh of asset %s", self.url)
> > +            return False
> > +
> 
> Do we really need this? You can also simply "rm ~/.cache/qemu/downloads"
> instead, or click on the "Clear runner caches" in the gitlab CI.

This can selectively refresh assets from a single test

  QEMU_TEST_REFRESH_CACHE=1 ./tests/functional/test_blah.py


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
Re: [PATCH 1/3] tests/functional: enable force refresh of cached assets
Posted by Thomas Huth 1 month ago 
On 29/08/2025 11.04, Daniel P. Berrangé wrote:
> On Fri, Aug 29, 2025 at 10:50:41AM +0200, Thomas Huth wrote:
>> On 29/08/2025 10.31, Daniel P. Berrangé wrote:
>>> If the 'QEMU_TEST_REFRESH_CACHE' environment variable is set, then
>>> ignore any existing cached asset and download a fresh copy.
>>>
>>> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
>>> ---
>>>    docs/devel/testing/functional.rst   | 3 +++
>>>    tests/functional/qemu_test/asset.py | 4 ++++
>>>    2 files changed, 7 insertions(+)
>>>
>>> diff --git a/docs/devel/testing/functional.rst b/docs/devel/testing/functional.rst
>>> index 3728bab6c0..fdeaebaadc 100644
>>> --- a/docs/devel/testing/functional.rst
>>> +++ b/docs/devel/testing/functional.rst
>>> @@ -312,6 +312,9 @@ The cache is populated in the ``~/.cache/qemu/download`` directory by
>>>    default, but the location can be changed by setting the
>>>    ``QEMU_TEST_CACHE_DIR`` environment variable.
>>> +To force the test suite to re-download the cache, even if still valid,
>>> +set the ``QEMU_TEST_REFRESH_CACHE`` environment variable.
>>> +
>>>    Skipping tests
>>>    --------------
>>> diff --git a/tests/functional/qemu_test/asset.py b/tests/functional/qemu_test/asset.py
>>> index 704b84d0ea..b5a6136d36 100644
>>> --- a/tests/functional/qemu_test/asset.py
>>> +++ b/tests/functional/qemu_test/asset.py
>>> @@ -72,6 +72,10 @@ def _check(self, cache_file):
>>>            return self.hash == hl.hexdigest()
>>>        def valid(self):
>>> +        if os.getenv("QEMU_TEST_REFRESH_CACHE", None) is not None:
>>> +            self.log.info("Force refresh of asset %s", self.url)
>>> +            return False
>>> +
>>
>> Do we really need this? You can also simply "rm ~/.cache/qemu/downloads"
>> instead, or click on the "Clear runner caches" in the gitlab CI.
> 
> This can selectively refresh assets from a single test
> 
>    QEMU_TEST_REFRESH_CACHE=1 ./tests/functional/test_blah.py

Ok, fair point.

Reviewed-by: Thomas Huth <thuth@redhat.com>

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.