[PATCH v3 0/3] vfio-user client functional test

John Levon posted 3 patches 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20250828100555.1893504-1-john.levon@nutanix.com
Maintainers: Thomas Huth <thuth@redhat.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, "Daniel P. Berrangé" <berrange@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Zhao Liu <zhao1.liu@intel.com>, John Levon <john.levon@nutanix.com>, Thanos Makatos <thanos.makatos@nutanix.com>, "Cédric Le Goater" <clg@redhat.com>
There is a newer version of this series
MAINTAINERS                                   |   1 +
tests/functional/qemu_test/cmd.py             |  65 ++-
tests/functional/x86_64/meson.build           |   1 +
.../x86_64/test_vfio_user_client.py           | 407 ++++++++++++++++++
4 files changed, 462 insertions(+), 12 deletions(-)
create mode 100755 tests/functional/x86_64/test_vfio_user_client.py
[PATCH v3 0/3] vfio-user client functional test
Posted by John Levon 1 month ago
Add a basic functional test for the vfio-user client, along with a couple of
test framework extensions to support it.

John Levon (2):
  tests/functional: return output from cmd.py helpers
  tests/functional: add vm param to cmd.py helpers

Mark Cave-Ayland (1):
  tests/functional: add a vfio-user smoke test

 MAINTAINERS                                   |   1 +
 tests/functional/qemu_test/cmd.py             |  65 ++-
 tests/functional/x86_64/meson.build           |   1 +
 .../x86_64/test_vfio_user_client.py           | 407 ++++++++++++++++++
 4 files changed, 462 insertions(+), 12 deletions(-)
 create mode 100755 tests/functional/x86_64/test_vfio_user_client.py

-- 
2.43.0
Re: [PATCH v3 0/3] vfio-user client functional test
Posted by Cédric Le Goater 3 weeks, 5 days ago
On 8/28/25 12:05, John Levon wrote:
> Add a basic functional test for the vfio-user client, along with a couple of
> test framework extensions to support it.
> 
> John Levon (2):
>    tests/functional: return output from cmd.py helpers
>    tests/functional: add vm param to cmd.py helpers
> 
> Mark Cave-Ayland (1):
>    tests/functional: add a vfio-user smoke test
> 
>   MAINTAINERS                                   |   1 +
>   tests/functional/qemu_test/cmd.py             |  65 ++-
>   tests/functional/x86_64/meson.build           |   1 +
>   .../x86_64/test_vfio_user_client.py           | 407 ++++++++++++++++++
>   4 files changed, 462 insertions(+), 12 deletions(-)
>   create mode 100755 tests/functional/x86_64/test_vfio_user_client.py
> 

The test is failing :


2025-09-02 11:24:37,944 - ERROR: Server logs did not match:
2025-09-02 11:24:37,944 - ERROR: ---

2025-09-02 11:24:37,944 - ERROR: +++

2025-09-02 11:24:37,944 - ERROR: @@ -50,8 +50,10 @@

2025-09-02 11:24:37,944 - ERROR:  gpio: removing DMA region [0xf0000, 0x8000000) flags=0
2025-09-02 11:24:37,944 - ERROR:  gpio: adding DMA region [0, 0x8000000) offset=0 flags=0x3
2025-09-02 11:24:37,944 - ERROR:  gpio: region7: read 0x494f from (0:2)
2025-09-02 11:24:37,944 - ERROR: -gpio: region7: read 0 from (0xe:1)
2025-09-02 11:24:37,944 - ERROR: -gpio: region7: read 0x494f from (0:2)
2025-09-02 11:24:37,944 - ERROR: +gpio: region7: read 0 from (0xa:2)
2025-09-02 11:24:37,944 - ERROR: +gpio: region7: read 0 from (0xe:1)
2025-09-02 11:24:37,944 - ERROR: +gpio: region7: read 0x494f from (0:2)
2025-09-02 11:24:37,944 - ERROR: +gpio: region7: read 0 from (0xa:2)
2025-09-02 11:24:37,944 - ERROR:  gpio: region7: read 0 from (0xe:1)
2025-09-02 11:24:37,944 - ERROR:  gpio: region7: read 0x494f from (0:2)
2025-09-02 11:24:37,944 - ERROR:  gpio: region7: read 0xdc8494f from (0:4)
2025-09-02 11:24:37,944 - ERROR: @@ -106,6 +108,7 @@

2025-09-02 11:24:37,944 - ERROR:  gpio: removing DMA region [0xd0000, 0xf0000) flags=0
2025-09-02 11:24:37,944 - ERROR:  gpio: adding DMA region [0xc4000, 0xe8000) offset=0 flags=0x1
2025-09-02 11:24:37,944 - ERROR:  gpio: adding DMA region [0xe8000, 0xf0000) offset=0 flags=0x3
2025-09-02 11:24:37,944 - ERROR: +gpio: region7: read 0 from (0xa:2)
2025-09-02 11:24:37,944 - ERROR:  gpio: region7: read 0x494f from (0:2)
2025-09-02 11:24:37,944 - ERROR:  gpio: region7: read 0xdc8 from (0x2:2)
2025-09-02 11:24:37,944 - ERROR:  gpio: region7: read 0 from (0xe:1)



Thanks,

C.
Re: [PATCH v3 0/3] vfio-user client functional test
Posted by John Levon 3 weeks, 5 days ago
On Tue, Sep 02, 2025 at 11:25:46AM +0200, Cédric Le Goater wrote:

> On 8/28/25 12:05, John Levon wrote:
> > Add a basic functional test for the vfio-user client, along with a couple of
> > test framework extensions to support it.
> > 
> > John Levon (2):
> >    tests/functional: return output from cmd.py helpers
> >    tests/functional: add vm param to cmd.py helpers
> > 
> > Mark Cave-Ayland (1):
> >    tests/functional: add a vfio-user smoke test
> > 
> >   MAINTAINERS                                   |   1 +
> >   tests/functional/qemu_test/cmd.py             |  65 ++-
> >   tests/functional/x86_64/meson.build           |   1 +
> >   .../x86_64/test_vfio_user_client.py           | 407 ++++++++++++++++++
> >   4 files changed, 462 insertions(+), 12 deletions(-)
> >   create mode 100755 tests/functional/x86_64/test_vfio_user_client.py
> > 
> 
> The test is failing :

What is the parent commit you tried this with?

I've had to fix this from a rebasing before, but it seems it's more sensitive
than I expected, and we'll have to be looser in terms of what we expect to
see...

regards
john
Re: [PATCH v3 0/3] vfio-user client functional test
Posted by Cédric Le Goater 3 weeks, 5 days ago
On 9/2/25 11:37, John Levon wrote:
> On Tue, Sep 02, 2025 at 11:25:46AM +0200, Cédric Le Goater wrote:
> 
>> On 8/28/25 12:05, John Levon wrote:
>>> Add a basic functional test for the vfio-user client, along with a couple of
>>> test framework extensions to support it.
>>>
>>> John Levon (2):
>>>     tests/functional: return output from cmd.py helpers
>>>     tests/functional: add vm param to cmd.py helpers
>>>
>>> Mark Cave-Ayland (1):
>>>     tests/functional: add a vfio-user smoke test
>>>
>>>    MAINTAINERS                                   |   1 +
>>>    tests/functional/qemu_test/cmd.py             |  65 ++-
>>>    tests/functional/x86_64/meson.build           |   1 +
>>>    .../x86_64/test_vfio_user_client.py           | 407 ++++++++++++++++++
>>>    4 files changed, 462 insertions(+), 12 deletions(-)
>>>    create mode 100755 tests/functional/x86_64/test_vfio_user_client.py
>>>
>>
>> The test is failing :
> 
> What is the parent commit you tried this with?

91589bcd9fee0e66b241d04e5f37cd4f218187a2

C.