hw/vfio-user: add x-pci-class-code

[PATCH] hw/vfio-user: add x-pci-class-code

Posted by John Levon 1 month ago

This new option was not added to vfio_user_pci_dev_properties, which
caused an incorrect class code for vfio-user devices.

Fixes: a59d06305fff ("vfio/pci: Introduce x-pci-class-code option")
Signed-off-by: John Levon <john.levon@nutanix.com>
---
 hw/vfio-user/pci.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/hw/vfio-user/pci.c b/hw/vfio-user/pci.c
index be71c77729..dfaa89498d 100644
--- a/hw/vfio-user/pci.c
+++ b/hw/vfio-user/pci.c
@@ -406,6 +406,8 @@ static const Property vfio_user_pci_dev_properties[] = {
                        sub_vendor_id, PCI_ANY_ID),
     DEFINE_PROP_UINT32("x-pci-sub-device-id", VFIOPCIDevice,
                        sub_device_id, PCI_ANY_ID),
+    DEFINE_PROP_UINT32("x-pci-class-code", VFIOPCIDevice,
+                       class_code, PCI_ANY_ID),
     DEFINE_PROP_BOOL("x-send-queued", VFIOUserPCIDevice, send_queued, false),
     DEFINE_PROP_UINT32("x-msg-timeout", VFIOUserPCIDevice, wait_time, 5000),
     DEFINE_PROP_BOOL("x-no-posted-writes", VFIOUserPCIDevice, no_post, false),
-- 
2.43.0

Re: [PATCH] hw/vfio-user: add x-pci-class-code

Posted by Cédric Le Goater 2 weeks, 6 days ago

On 8/27/25 21:08, John Levon wrote:
> This new option was not added to vfio_user_pci_dev_properties, which
> caused an incorrect class code for vfio-user devices.
> 
> Fixes: a59d06305fff ("vfio/pci: Introduce x-pci-class-code option")
> Signed-off-by: John Levon <john.levon@nutanix.com>
> ---
>   hw/vfio-user/pci.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/hw/vfio-user/pci.c b/hw/vfio-user/pci.c
> index be71c77729..dfaa89498d 100644
> --- a/hw/vfio-user/pci.c
> +++ b/hw/vfio-user/pci.c
> @@ -406,6 +406,8 @@ static const Property vfio_user_pci_dev_properties[] = {
>                          sub_vendor_id, PCI_ANY_ID),
>       DEFINE_PROP_UINT32("x-pci-sub-device-id", VFIOPCIDevice,
>                          sub_device_id, PCI_ANY_ID),
> +    DEFINE_PROP_UINT32("x-pci-class-code", VFIOPCIDevice,
> +                       class_code, PCI_ANY_ID),
>       DEFINE_PROP_BOOL("x-send-queued", VFIOUserPCIDevice, send_queued, false),
>       DEFINE_PROP_UINT32("x-msg-timeout", VFIOUserPCIDevice, wait_time, 5000),
>       DEFINE_PROP_BOOL("x-no-posted-writes", VFIOUserPCIDevice, no_post, false),


Applied to vfio-next.

Thanks,

C.

Re: [PATCH] hw/vfio-user: add x-pci-class-code

Posted by Cédric Le Goater 3 weeks, 6 days ago

On 8/27/25 21:08, John Levon wrote:
> This new option was not added to vfio_user_pci_dev_properties, which
> caused an incorrect class code for vfio-user devices.
> 
> Fixes: a59d06305fff ("vfio/pci: Introduce x-pci-class-code option")
> Signed-off-by: John Levon <john.levon@nutanix.com>
> ---
>   hw/vfio-user/pci.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/hw/vfio-user/pci.c b/hw/vfio-user/pci.c
> index be71c77729..dfaa89498d 100644
> --- a/hw/vfio-user/pci.c
> +++ b/hw/vfio-user/pci.c
> @@ -406,6 +406,8 @@ static const Property vfio_user_pci_dev_properties[] = {
>                          sub_vendor_id, PCI_ANY_ID),
>       DEFINE_PROP_UINT32("x-pci-sub-device-id", VFIOPCIDevice,
>                          sub_device_id, PCI_ANY_ID),
> +    DEFINE_PROP_UINT32("x-pci-class-code", VFIOPCIDevice,
> +                       class_code, PCI_ANY_ID),
>       DEFINE_PROP_BOOL("x-send-queued", VFIOUserPCIDevice, send_queued, false),
>       DEFINE_PROP_UINT32("x-msg-timeout", VFIOUserPCIDevice, wait_time, 5000),
>       DEFINE_PROP_BOOL("x-no-posted-writes", VFIOUserPCIDevice, no_post, false),



Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.