qga-vss: Misc cleanup

[PATCH 2/2] qga-vss: Remove unused dependencies

Posted by Kostiantyn Kostiuk 2 months, 3 weeks ago

Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>
---
 qga/vss-win32/meson.build | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/qga/vss-win32/meson.build b/qga/vss-win32/meson.build
index 0ac918910b..a6b810f12a 100644
--- a/qga/vss-win32/meson.build
+++ b/qga/vss-win32/meson.build
@@ -13,13 +13,11 @@ qga_vss = shared_module(
   link_args: link_args,
   vs_module_defs: 'qga-vss.def',
   dependencies: [
-    glib,
     socket,
     cc.find_library('ole32'),
     cc.find_library('oleaut32'),
     cc.find_library('shlwapi'),
-    cc.find_library('uuid'),
-    cc.find_library('intl')
+    cc.find_library('uuid')
   ]
 )
 
-- 
2.50.1

Re: [PATCH 2/2] qga-vss: Remove unused dependencies

Posted by Yan Vugenfirer 2 months, 2 weeks ago

On Mon, Aug 25, 2025 at 5:52 PM Kostiantyn Kostiuk <kkostiuk@redhat.com> wrote:
>
> Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>
> ---
>  qga/vss-win32/meson.build | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/qga/vss-win32/meson.build b/qga/vss-win32/meson.build
> index 0ac918910b..a6b810f12a 100644
> --- a/qga/vss-win32/meson.build
> +++ b/qga/vss-win32/meson.build
> @@ -13,13 +13,11 @@ qga_vss = shared_module(
>    link_args: link_args,
>    vs_module_defs: 'qga-vss.def',
>    dependencies: [
> -    glib,
>      socket,
>      cc.find_library('ole32'),
>      cc.find_library('oleaut32'),
>      cc.find_library('shlwapi'),
> -    cc.find_library('uuid'),
> -    cc.find_library('intl')
> +    cc.find_library('uuid')
>    ]
>  )
>
> --
> 2.50.1
>

Reviewed-by: Yan Vugenfirer <yvugenfi@redhat.com>

[PATCH 1/2] qga-vss: Replace asserts with condition and report error
[PATCH 2/2] qga-vss: Remove unused dependencies