[v6] hw/i386: separate isapc out from pc_piix

[PATCH v6 07/19] hw/i386/pc_piix.c: remove SGX initialisation from pc_init_isa()

Posted by Mark Cave-Ayland 2 months, 3 weeks ago

The Intel SGX instructions only exist on recent CPUs and so would never be available
on a CPU from the pre-PCI era.

Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
---
 hw/i386/pc_piix.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index e58a7b3977..129a3e2524 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -509,8 +509,6 @@ static void pc_init_isa(MachineState *machine)
         }
     }
 
-    pc_machine_init_sgx_epc(pcms);
-
     /*
      * There is a small chance that someone unintentionally passes "-cpu max"
      * for the isapc machine, which will provide a much more modern 32-bit
-- 
2.43.0

Re: [PATCH v6 07/19] hw/i386/pc_piix.c: remove SGX initialisation from pc_init_isa()

Posted by Xiaoyao Li 2 months, 2 weeks ago

On 8/22/2025 8:11 PM, Mark Cave-Ayland wrote:
> The Intel SGX instructions only exist on recent CPUs and so would never be available
> on a CPU from the pre-PCI era.
> 
> Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>

Reviewed-by: Xiaoyao Li <xiaoyao.li@intel.com>

> ---
>   hw/i386/pc_piix.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
> index e58a7b3977..129a3e2524 100644
> --- a/hw/i386/pc_piix.c
> +++ b/hw/i386/pc_piix.c
> @@ -509,8 +509,6 @@ static void pc_init_isa(MachineState *machine)
>           }
>       }
>   
> -    pc_machine_init_sgx_epc(pcms);
> -
>       /*
>        * There is a small chance that someone unintentionally passes "-cpu max"
>        * for the isapc machine, which will provide a much more modern 32-bit