[PATCH 1/5] docker: Remove 32-bit MIPS toolchain from debian-all-test image

Philippe Mathieu-Daudé posted 5 patches 2 months, 3 weeks ago
Maintainers: "Alex Bennée" <alex.bennee@linaro.org>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Thomas Huth <thuth@redhat.com>, Riku Voipio <riku.voipio@iki.fi>, Paolo Bonzini <pbonzini@redhat.com>, Aurelien Jarno <aurelien@aurel32.net>, Huacai Chen <chenhuacai@kernel.org>, Jiaxun Yang <jiaxun.yang@flygoat.com>, Aleksandar Rikalo <arikalo@gmail.com>, Richard Henderson <richard.henderson@linaro.org>
There is a newer version of this series
[PATCH 1/5] docker: Remove 32-bit MIPS toolchain from debian-all-test image
Posted by Philippe Mathieu-Daudé 2 months, 3 weeks ago
In commit d3322023bfe ("configure: unify again the case arms in
probe_target_compiler") we lost coverage of 32-bit MIPS with the
debian-all-test image. No need to keep installing the toolchain.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 tests/docker/dockerfiles/debian-all-test-cross.docker | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/tests/docker/dockerfiles/debian-all-test-cross.docker b/tests/docker/dockerfiles/debian-all-test-cross.docker
index 420a4e33e60..bc74d65a634 100644
--- a/tests/docker/dockerfiles/debian-all-test-cross.docker
+++ b/tests/docker/dockerfiles/debian-all-test-cross.docker
@@ -40,14 +40,10 @@ ENV AVAILABLE_COMPILERS gcc-aarch64-linux-gnu \
         libc6-dev-arm64-cross \
         gcc-arm-linux-gnueabihf \
         libc6-dev-armhf-cross \
-        gcc-mips-linux-gnu \
-        libc6-dev-mips-cross \
         gcc-mips64-linux-gnuabi64 \
         libc6-dev-mips64-cross \
         gcc-mips64el-linux-gnuabi64 \
         libc6-dev-mips64el-cross \
-        gcc-mipsel-linux-gnu \
-        libc6-dev-mipsel-cross \
         gcc-powerpc64le-linux-gnu \
         libc6-dev-ppc64el-cross \
         gcc-riscv64-linux-gnu \
-- 
2.51.0


Re: [PATCH 1/5] docker: Remove 32-bit MIPS toolchain from debian-all-test image
Posted by Alex Bennée 2 months, 3 weeks ago
Philippe Mathieu-Daudé <philmd@linaro.org> writes:

> In commit d3322023bfe ("configure: unify again the case arms in
> probe_target_compiler") we lost coverage of 32-bit MIPS with the
> debian-all-test image. No need to keep installing the toolchain.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  tests/docker/dockerfiles/debian-all-test-cross.docker | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/tests/docker/dockerfiles/debian-all-test-cross.docker b/tests/docker/dockerfiles/debian-all-test-cross.docker
> index 420a4e33e60..bc74d65a634 100644
> --- a/tests/docker/dockerfiles/debian-all-test-cross.docker
> +++ b/tests/docker/dockerfiles/debian-all-test-cross.docker
> @@ -40,14 +40,10 @@ ENV AVAILABLE_COMPILERS gcc-aarch64-linux-gnu \
>          libc6-dev-arm64-cross \
>          gcc-arm-linux-gnueabihf \
>          libc6-dev-armhf-cross \
> -        gcc-mips-linux-gnu \
> -        libc6-dev-mips-cross \
>          gcc-mips64-linux-gnuabi64 \
>          libc6-dev-mips64-cross \
>          gcc-mips64el-linux-gnuabi64 \
>          libc6-dev-mips64el-cross \
> -        gcc-mipsel-linux-gnu \
> -        libc6-dev-mipsel-cross \
>          gcc-powerpc64le-linux-gnu \
>          libc6-dev-ppc64el-cross \
>          gcc-riscv64-linux-gnu \

You also need to remove the references in configure:

      hppa|m68k|mips|riscv64|sparc64)
        container_image=debian-all-test-cross
        ;;
      mips64)
        container_image=debian-all-test-cross
        container_cross_prefix=mips64-linux-gnuabi64-
        ;;


-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro
Re: [PATCH 1/5] docker: Remove 32-bit MIPS toolchain from debian-all-test image
Posted by Philippe Mathieu-Daudé 2 months, 3 weeks ago
On 22/8/25 13:23, Alex Bennée wrote:
> Philippe Mathieu-Daudé <philmd@linaro.org> writes:
> 
>> In commit d3322023bfe ("configure: unify again the case arms in
>> probe_target_compiler") we lost coverage of 32-bit MIPS with the
>> debian-all-test image. No need to keep installing the toolchain.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> ---
>>   tests/docker/dockerfiles/debian-all-test-cross.docker | 4 ----
>>   1 file changed, 4 deletions(-)
>>
>> diff --git a/tests/docker/dockerfiles/debian-all-test-cross.docker b/tests/docker/dockerfiles/debian-all-test-cross.docker
>> index 420a4e33e60..bc74d65a634 100644
>> --- a/tests/docker/dockerfiles/debian-all-test-cross.docker
>> +++ b/tests/docker/dockerfiles/debian-all-test-cross.docker
>> @@ -40,14 +40,10 @@ ENV AVAILABLE_COMPILERS gcc-aarch64-linux-gnu \
>>           libc6-dev-arm64-cross \
>>           gcc-arm-linux-gnueabihf \
>>           libc6-dev-armhf-cross \
>> -        gcc-mips-linux-gnu \
>> -        libc6-dev-mips-cross \
>>           gcc-mips64-linux-gnuabi64 \
>>           libc6-dev-mips64-cross \
>>           gcc-mips64el-linux-gnuabi64 \
>>           libc6-dev-mips64el-cross \
>> -        gcc-mipsel-linux-gnu \
>> -        libc6-dev-mipsel-cross \
>>           gcc-powerpc64le-linux-gnu \
>>           libc6-dev-ppc64el-cross \
>>           gcc-riscv64-linux-gnu \
> 
> You also need to remove the references in configure:
> 
>        hppa|m68k|mips|riscv64|sparc64)
>          container_image=debian-all-test-cross
>          ;;

OK.

>        mips64)
>          container_image=debian-all-test-cross
>          container_cross_prefix=mips64-linux-gnuabi64-
>          ;;

We aren't removing mips64 yet. We will but since the reason is
different, it will be in another series.

Re: [PATCH 1/5] docker: Remove 32-bit MIPS toolchain from debian-all-test image
Posted by Philippe Mathieu-Daudé 1 month ago
On 22/8/25 16:49, Philippe Mathieu-Daudé wrote:
> On 22/8/25 13:23, Alex Bennée wrote:
>> Philippe Mathieu-Daudé <philmd@linaro.org> writes:
>>
>>> In commit d3322023bfe ("configure: unify again the case arms in
>>> probe_target_compiler") we lost coverage of 32-bit MIPS with the
>>> debian-all-test image. No need to keep installing the toolchain.
>>>
>>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>>> ---
>>>   tests/docker/dockerfiles/debian-all-test-cross.docker | 4 ----
>>>   1 file changed, 4 deletions(-)
>>>
>>> diff --git a/tests/docker/dockerfiles/debian-all-test-cross.docker b/ 
>>> tests/docker/dockerfiles/debian-all-test-cross.docker
>>> index 420a4e33e60..bc74d65a634 100644
>>> --- a/tests/docker/dockerfiles/debian-all-test-cross.docker
>>> +++ b/tests/docker/dockerfiles/debian-all-test-cross.docker
>>> @@ -40,14 +40,10 @@ ENV AVAILABLE_COMPILERS gcc-aarch64-linux-gnu \
>>>           libc6-dev-arm64-cross \
>>>           gcc-arm-linux-gnueabihf \
>>>           libc6-dev-armhf-cross \
>>> -        gcc-mips-linux-gnu \
>>> -        libc6-dev-mips-cross \
>>>           gcc-mips64-linux-gnuabi64 \
>>>           libc6-dev-mips64-cross \
>>>           gcc-mips64el-linux-gnuabi64 \
>>>           libc6-dev-mips64el-cross \
>>> -        gcc-mipsel-linux-gnu \
>>> -        libc6-dev-mipsel-cross \
>>>           gcc-powerpc64le-linux-gnu \
>>>           libc6-dev-ppc64el-cross \
>>>           gcc-riscv64-linux-gnu \
>>
>> You also need to remove the references in configure:
>>

Expanding:

     case $target_arch in

>>        hppa|m68k|mips|riscv64|sparc64)
>>          container_image=debian-all-test-cross
>>          ;;
> 
> OK.

So actual patch is correct here.

> 
>>        mips64)
>>          container_image=debian-all-test-cross
>>          container_cross_prefix=mips64-linux-gnuabi64-
>>          ;;
> 
> We aren't removing mips64 yet. We will but since the reason is
> different, it will be in another series.