A few files in scripts, and the list of packages in pythondeps.toml, are
strictly related to the toplevel build scripts.  Add them to the
MAINTAINERS file stanza.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 MAINTAINERS | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index a07086ed762..3979cffb042 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4403,6 +4403,9 @@ R: Thomas Huth <thuth@redhat.com>
 S: Maintained
 F: Makefile
 F: configure
+F: pythondeps.toml
+F: scripts/git-submodule.sh
+F: scripts/meson-buildoptions.py
 F: scripts/mtest2make.py
 F: tests/Makefile.include
 
-- 
2.50.1

On Tue, 19 Aug 2025 at 16:43, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> A few files in scripts, and the list of packages in pythondeps.toml, are
> strictly related to the toplevel build scripts.  Add them to the
> MAINTAINERS file stanza.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  MAINTAINERS | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index a07086ed762..3979cffb042 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -4403,6 +4403,9 @@ R: Thomas Huth <thuth@redhat.com>
>  S: Maintained
>  F: Makefile
>  F: configure
> +F: pythondeps.toml
> +F: scripts/git-submodule.sh
> +F: scripts/meson-buildoptions.py

This is already covered by the line in the "Meson" section:
F: scripts/meson-buildoptions.*

>  F: scripts/mtest2make.py
>  F: tests/Makefile.include

thanks
-- PMM

On Tue, Aug 19, 2025 at 6:08 PM Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Tue, 19 Aug 2025 at 16:43, Paolo Bonzini <pbonzini@redhat.com> wrote:
> >
> > A few files in scripts, and the list of packages in pythondeps.toml, are
> > strictly related to the toplevel build scripts.  Add them to the
> > MAINTAINERS file stanza.
> >
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > ---
> >  MAINTAINERS | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index a07086ed762..3979cffb042 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -4403,6 +4403,9 @@ R: Thomas Huth <thuth@redhat.com>
> >  S: Maintained
> >  F: Makefile
> >  F: configure
> > +F: pythondeps.toml
> > +F: scripts/git-submodule.sh
> > +F: scripts/meson-buildoptions.py
>
> This is already covered by the line in the "Meson" section:
> F: scripts/meson-buildoptions.*

Yes, that's intentional. I can change that one from py to sh, but the
Python script that generates the option parser has more to do with
configure/Makefile than Meson.

Paolo


Paolo

On Wed, 20 Aug 2025 at 10:46, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On Tue, Aug 19, 2025 at 6:08 PM Peter Maydell <peter.maydell@linaro.org> wrote:
> >
> > On Tue, 19 Aug 2025 at 16:43, Paolo Bonzini <pbonzini@redhat.com> wrote:
> > >
> > > A few files in scripts, and the list of packages in pythondeps.toml, are
> > > strictly related to the toplevel build scripts.  Add them to the
> > > MAINTAINERS file stanza.
> > >
> > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > > ---
> > >  MAINTAINERS | 3 +++
> > >  1 file changed, 3 insertions(+)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index a07086ed762..3979cffb042 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -4403,6 +4403,9 @@ R: Thomas Huth <thuth@redhat.com>
> > >  S: Maintained
> > >  F: Makefile
> > >  F: configure
> > > +F: pythondeps.toml
> > > +F: scripts/git-submodule.sh
> > > +F: scripts/meson-buildoptions.py
> >
> > This is already covered by the line in the "Meson" section:
> > F: scripts/meson-buildoptions.*
>
> Yes, that's intentional. I can change that one from py to sh, but the
> Python script that generates the option parser has more to do with
> configure/Makefile than Meson.

If you want to move the files from one category to the other
that's fine, but I think both files should be in the same
category, because one is the output of the other, so I think
it would be better to move the existing F: line from Meson to
Top Level Makefile.

thanks
-- PMM