[v1] linux-user: Split up elfload.c

[PATCH 81/89] linux-user: Remove ELIBBAD from elfload.c

Posted by Richard Henderson 3 months, 2 weeks ago

The last use of this fallback was removed in 8e62a71738bc.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 linux-user/elfload.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index 5185c84e58..6eb4e31bdb 100644
--- a/linux-user/elfload.c
+++ b/linux-user/elfload.c
@@ -110,11 +110,6 @@ int info_is_fdpic(struct image_info *info)
 #define MAP_DENYWRITE 0
 #endif
 
-/* should probably go in elf.h */
-#ifndef ELIBBAD
-#define ELIBBAD 80
-#endif
-
 #if TARGET_BIG_ENDIAN
 #define ELF_DATA        ELFDATA2MSB
 #else
-- 
2.43.0

Re: [PATCH 81/89] linux-user: Remove ELIBBAD from elfload.c

Posted by Peter Maydell 3 months, 2 weeks ago

On Wed, 30 Jul 2025 at 01:39, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> The last use of this fallback was removed in 8e62a71738bc.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  linux-user/elfload.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/linux-user/elfload.c b/linux-user/elfload.c
> index 5185c84e58..6eb4e31bdb 100644
> --- a/linux-user/elfload.c
> +++ b/linux-user/elfload.c
> @@ -110,11 +110,6 @@ int info_is_fdpic(struct image_info *info)
>  #define MAP_DENYWRITE 0
>  #endif
>
> -/* should probably go in elf.h */
> -#ifndef ELIBBAD
> -#define ELIBBAD 80
> -#endif

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

(The existence of an unguarded "E(ELIBBAD)" in errnos.c.inc suggests
that all our supported hosts define ELIBBAD in the system headers
anyway.)

thanks
-- PMM