[PATCH 0/3] aspeed: Update vbootrom image

Cédric Le Goater posted 3 patches 3 months, 2 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20250729170800.678363-1-clg@redhat.com
pc-bios/ast27x0_bootrom.bin | Bin 15552 -> 16408 bytes
roms/Makefile               |   5 +++++
roms/vbootrom               |   2 +-
3 files changed, 6 insertions(+), 1 deletion(-)
[PATCH 0/3] aspeed: Update vbootrom image
Posted by Cédric Le Goater 3 months, 2 weeks ago
Hello !

Michael provided changes to fix the build of the vbootrom image of the
AST2700 SoC machine in [1]. However, a workaound in roms/Makefile was
still necessary to build ast27x0_bootrom.bin correctly. This was later
fixed in [2].

This series is an update of [1] including a vbootrom image matching
the new commits.

Thanks,
C.

[1] https://lore.kernel.org/qemu-devel/2a89ad4c8f5665d07952a4f1749caa6ec0cd3d9c.1753654515.git.mjt@tls.msk.ru/
[2] https://github.com/google/vbootrom/commit/7b1eb5f7fe6a85a03a1e40aa703a6ebbdb644e31


Cédric Le Goater (1):
  aspeed: Update vbootrom image to commit 183c9ff8056b

Michael Tokarev (2):
  roms/vbootrom: update to 7b1eb5f7fe6a
  roms/Makefile: build ast27x0_bootrom

 pc-bios/ast27x0_bootrom.bin | Bin 15552 -> 16408 bytes
 roms/Makefile               |   5 +++++
 roms/vbootrom               |   2 +-
 3 files changed, 6 insertions(+), 1 deletion(-)

-- 
2.50.1


Re: [PATCH 0/3] aspeed: Update vbootrom image
Posted by Michael Tokarev 3 months, 2 weeks ago
On 29.07.2025 20:07, Cédric Le Goater wrote:
> Hello !
> 
> Michael provided changes to fix the build of the vbootrom image of the
> AST2700 SoC machine in [1]. However, a workaound in roms/Makefile was
> still necessary to build ast27x0_bootrom.bin correctly. This was later
> fixed in [2].
> 
> This series is an update of [1] including a vbootrom image matching
> the new commits.

Thank you for this!

I guess we should also update npcm bootroms now, - does it need any
additional handling (the two changes related to npcm)?

And I'd say we should include all this in 10.1.

/mjt

Re: [PATCH 0/3] aspeed: Update vbootrom image
Posted by Cédric Le Goater 3 months, 2 weeks ago
On 7/29/25 19:20, Michael Tokarev wrote:
> On 29.07.2025 20:07, Cédric Le Goater wrote:
>> Hello !
>>
>> Michael provided changes to fix the build of the vbootrom image of the
>> AST2700 SoC machine in [1]. However, a workaound in roms/Makefile was
>> still necessary to build ast27x0_bootrom.bin correctly. This was later
>> fixed in [2].
>>
>> This series is an update of [1] including a vbootrom image matching
>> the new commits.
> 
> Thank you for this!
> 
> I guess we should also update npcm bootroms now, - 

Of course. Let me respin.

> does it need any
> additional handling (the two changes related to npcm)?

"roms/Makefile: fix npcmNxx_bootrom build rules" was merged.
commit 653a75a9d7f9.

> And I'd say we should include all this in 10.1.

yes if Hao agrees.

Thanks,

C.