hw/intc/arm_gicv3_kvm: two small fixes about register accesses

[PATCH 0/2] hw/intc/arm_gicv3_kvm: two small fixes about register accesses

Zenghui Yu posted 2 patches 6 months, 1 week ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20250729161650.43758-1-zenghui.yu@linux.dev

Maintainers: Peter Maydell <peter.maydell@linaro.org>

hw/intc/arm_gicv3_kvm.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

Expand all Fold all

[PATCH 0/2] hw/intc/arm_gicv3_kvm: two small fixes about register accesses

Posted by Zenghui Yu 6 months, 1 week ago

Zenghui Yu (2):
  hw/intc/arm_gicv3_kvm: Remove writes to ICPENDR registers
  hw/intc/arm_gicv3_kvm: Write all 1's to clear enable/active

 hw/intc/arm_gicv3_kvm.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

-- 
2.34.1

Re: [PATCH 0/2] hw/intc/arm_gicv3_kvm: two small fixes about register accesses

Posted by Peter Maydell 6 months, 1 week ago

On Tue, 29 Jul 2025 at 17:17, Zenghui Yu <zenghui.yu@linux.dev> wrote:
>
> Zenghui Yu (2):
>   hw/intc/arm_gicv3_kvm: Remove writes to ICPENDR registers
>   hw/intc/arm_gicv3_kvm: Write all 1's to clear enable/active
>
>  hw/intc/arm_gicv3_kvm.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)

Did this cause any visible bugs, or did you just notice it
by code inspection ?

Applied to target-arm.next, thanks.

-- PMM

Re: [PATCH 0/2] hw/intc/arm_gicv3_kvm: two small fixes about register accesses

Posted by Zenghui Yu 6 months ago

On 2025/8/1 01:11, Peter Maydell wrote:
> On Tue, 29 Jul 2025 at 17:17, Zenghui Yu <zenghui.yu@linux.dev> wrote:
> >
> > Zenghui Yu (2):
> >   hw/intc/arm_gicv3_kvm: Remove writes to ICPENDR registers
> >   hw/intc/arm_gicv3_kvm: Write all 1's to clear enable/active
> >
> >  hw/intc/arm_gicv3_kvm.c | 6 ++----
> >  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> Did this cause any visible bugs, or did you just notice it
> by code inspection ?

They're noticed by code inspection. I agree with that patch #2 is
guest-visible only when doing a system reset.

> 
> Applied to target-arm.next, thanks.

Thanks!

Zenghui