Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index f1bd69c3db..9c22e921e8 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4432,6 +4432,7 @@ F: docs/requirements.txt
F: docs/sphinx/
F: docs/_templates/
F: docs/devel/docs.rst
+F: docs/devel/qapi-domain.rst
Rust build system integration
M: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
--
2.49.0
On 29/7/25 11:16, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster <armbru@redhat.com> > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
On Tue, Jul 29, 2025 at 12:18 PM Markus Armbruster <armbru@redhat.com> wrote: > > Signed-off-by: Markus Armbruster <armbru@redhat.com> > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index f1bd69c3db..9c22e921e8 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -4432,6 +4432,7 @@ F: docs/requirements.txt > F: docs/sphinx/ > F: docs/_templates/ > F: docs/devel/docs.rst > +F: docs/devel/qapi-domain.rst Question: Does it matter if this is already covered by QAPI section which has: "F: docs/devel/qapi*"? If not, Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org> > > Rust build system integration > M: Manos Pitsidianakis <manos.pitsidianakis@linaro.org> > -- > 2.49.0 > >
Manos Pitsidianakis <manos.pitsidianakis@linaro.org> writes:
> On Tue, Jul 29, 2025 at 12:18 PM Markus Armbruster <armbru@redhat.com> wrote:
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>> MAINTAINERS | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index f1bd69c3db..9c22e921e8 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -4432,6 +4432,7 @@ F: docs/requirements.txt
>> F: docs/sphinx/
>> F: docs/_templates/
>> F: docs/devel/docs.rst
>> +F: docs/devel/qapi-domain.rst
>
> Question: Does it matter if this is already covered by QAPI section
> which has: "F: docs/devel/qapi*"?
I'm adding it to the "Sphinx documentation configuration and build
machinery" section as well.
Before the patch:
$ scripts/get_maintainer.pl -f docs/devel/qapi-domain.rst
Markus Armbruster <armbru@redhat.com> (supporter:QAPI)
Michael Roth <michael.roth@amd.com> (supporter:QAPI)
qemu-devel@nongnu.org (open list:All patches CC here)
Afterwards:
$ scripts/get_maintainer.pl -f docs/devel/qapi-domain.rst
--> John Snow <jsnow@redhat.com> (maintainer:Sphinx documentat...)
--> Peter Maydell <peter.maydell@linaro.org> (maintainer:Sphinx documentat...)
Markus Armbruster <armbru@redhat.com> (supporter:QAPI)
Michael Roth <michael.roth@amd.com> (supporter:QAPI)
qemu-devel@nongnu.org (open list:All patches CC here)
Good, because it's John's baby, and he's maintaining it.
> If not,
>
> Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Thank you!
[...]
Markus Armbruster <armbru@redhat.com> writes:
> Manos Pitsidianakis <manos.pitsidianakis@linaro.org> writes:
>
>> On Tue, Jul 29, 2025 at 12:18 PM Markus Armbruster <armbru@redhat.com> wrote:
>>>
>>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>>> ---
>>> MAINTAINERS | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index f1bd69c3db..9c22e921e8 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -4432,6 +4432,7 @@ F: docs/requirements.txt
>>> F: docs/sphinx/
>>> F: docs/_templates/
>>> F: docs/devel/docs.rst
>>> +F: docs/devel/qapi-domain.rst
>>
>> Question: Does it matter if this is already covered by QAPI section
>> which has: "F: docs/devel/qapi*"?
>
> I'm adding it to the "Sphinx documentation configuration and build
> machinery" section as well.
>
> Before the patch:
>
> $ scripts/get_maintainer.pl -f docs/devel/qapi-domain.rst
> Markus Armbruster <armbru@redhat.com> (supporter:QAPI)
> Michael Roth <michael.roth@amd.com> (supporter:QAPI)
> qemu-devel@nongnu.org (open list:All patches CC here)
>
> Afterwards:
>
> $ scripts/get_maintainer.pl -f docs/devel/qapi-domain.rst
> --> John Snow <jsnow@redhat.com> (maintainer:Sphinx documentat...)
> --> Peter Maydell <peter.maydell@linaro.org> (maintainer:Sphinx documentat...)
> Markus Armbruster <armbru@redhat.com> (supporter:QAPI)
> Michael Roth <michael.roth@amd.com> (supporter:QAPI)
> qemu-devel@nongnu.org (open list:All patches CC here)
>
> Good, because it's John's baby, and he's maintaining it.
>
>> If not,
>>
>> Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
>
> Thank you!
>
> [...]
Amending the commit message:
Section QAPI already covers it, and that's fine. It's missing from
"Sphinx documentation configuration and build machinery". Add it
there.
© 2016 - 2025 Red Hat, Inc.