"qemu/error-report.h" was previously implicitly included. This is no
longer the case following 012842c075520dbe1bd96a2fdcf4e218874ba443.

However, the issue predates this change as `error-report.h` should have
been included when the `warn_report` call was introduced.

Fixes: fa140b9562 ("hw/sm501: allow compiling without PIXMAN")
Signed-off-by: Clément Chigot <chigot@adacore.com>
---
 hw/display/sm501.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/display/sm501.c b/hw/display/sm501.c
index 6d2f18684c..bc091b3c9f 100644
--- a/hw/display/sm501.c
+++ b/hw/display/sm501.c
@@ -26,6 +26,7 @@
 #include "qemu/osdep.h"
 #include "qemu/units.h"
 #include "qapi/error.h"
+#include "qemu/error-report.h"
 #include "qemu/log.h"
 #include "qemu/module.h"
 #include "hw/usb/hcd-ohci.h"
-- 
2.34.1

On 28/7/25 11:05, Clément Chigot wrote:
> "qemu/error-report.h" was previously implicitly included. This is no
> longer the case following 012842c075520dbe1bd96a2fdcf4e218874ba443.
> 
> However, the issue predates this change as `error-report.h` should have
> been included when the `warn_report` call was introduced.
> 
> Fixes: fa140b9562 ("hw/sm501: allow compiling without PIXMAN")
> Signed-off-by: Clément Chigot <chigot@adacore.com>
> ---
>   hw/display/sm501.c | 1 +
>   1 file changed, 1 insertion(+)

Patch queued, thanks!

On 28/7/25 11:05, Clément Chigot wrote:
> "qemu/error-report.h" was previously implicitly included. This is no
> longer the case following 012842c075520dbe1bd96a2fdcf4e218874ba443.
> 
> However, the issue predates this change as `error-report.h` should have
> been included when the `warn_report` call was introduced.
> 
> Fixes: fa140b9562 ("hw/sm501: allow compiling without PIXMAN")
> Signed-off-by: Clément Chigot <chigot@adacore.com>
> ---
>   hw/display/sm501.c | 1 +
>   1 file changed, 1 insertion(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

and queued, thanks!

On Mon, Jul 28, 2025 at 11:05:18AM +0200, Clément Chigot wrote:
> "qemu/error-report.h" was previously implicitly included. This is no
> longer the case following 012842c075520dbe1bd96a2fdcf4e218874ba443.
> 
> However, the issue predates this change as `error-report.h` should have
> been included when the `warn_report` call was introduced.
> 
> Fixes: fa140b9562 ("hw/sm501: allow compiling without PIXMAN")
> Signed-off-by: Clément Chigot <chigot@adacore.com>
> ---
>  hw/display/sm501.c | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

> 
> diff --git a/hw/display/sm501.c b/hw/display/sm501.c
> index 6d2f18684c..bc091b3c9f 100644
> --- a/hw/display/sm501.c
> +++ b/hw/display/sm501.c
> @@ -26,6 +26,7 @@
>  #include "qemu/osdep.h"
>  #include "qemu/units.h"
>  #include "qapi/error.h"
> +#include "qemu/error-report.h"
>  #include "qemu/log.h"
>  #include "qemu/module.h"
>  #include "hw/usb/hcd-ohci.h"
> -- 
> 2.34.1
> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|