1. Patchew
  2. QEMU
  3. [PATCH v2 0/3] RISC-V: ACPI: Update FADT and MADT versions
  4. View patch

[PATCH v2 3/3] tests/data/acpi/riscv64: Update expected FADT and MADT

Sunil V L posted 3 patches 3 months, 3 weeks ago
Maintainers: Sunil V L <sunilvl@ventanamicro.com>, Palmer Dabbelt <palmer@dabbelt.com>, Alistair Francis <alistair.francis@wdc.com>, Weiwei Li <liwei1518@gmail.com>, Daniel Henrique Barboza <dbarboza@ventanamicro.com>, Liu Zhiwei <zhiwei_liu@linux.alibaba.com>, "Michael S. Tsirkin" <mst@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Ani Sinha <anisinha@redhat.com>
[PATCH v2 3/3] tests/data/acpi/riscv64: Update expected FADT and MADT
Posted by Sunil V L 3 months, 3 weeks ago 
Update the expected tables for the version change.
 /*
  *
  * ACPI Data Table [FACP]
  *
  * Format: [HexOffset DecimalOffset ByteLength]  FieldName : FieldValue (in hex)
  */

 [000h 0000 004h]                   Signature : "FACP"    [Fixed ACPI Description Table (FADT)]
 [004h 0004 004h]                Table Length : 00000114
 [008h 0008 001h]                    Revision : 06
-[009h 0009 001h]                    Checksum : 13
+[009h 0009 001h]                    Checksum : 12
 [00Ah 0010 006h]                      Oem ID : "BOCHS "
 [010h 0016 008h]                Oem Table ID : "BXPC    "
 [018h 0024 004h]                Oem Revision : 00000001
 [01Ch 0028 004h]             Asl Compiler ID : "BXPC"
 [020h 0032 004h]       Asl Compiler Revision : 00000001

 [024h 0036 004h]                FACS Address : 00000000
 [028h 0040 004h]                DSDT Address : 00000000
 [02Ch 0044 001h]                       Model : 00
 [02Dh 0045 001h]                  PM Profile : 00 [Unspecified]
 [02Eh 0046 002h]               SCI Interrupt : 0000
 [030h 0048 004h]            SMI Command Port : 00000000
 [034h 0052 001h]           ACPI Enable Value : 00
 [035h 0053 001h]          ACPI Disable Value : 00
 [036h 0054 001h]              S4BIOS Command : 00
 [037h 0055 001h]             P-State Control : 00
@@ -86,33 +86,33 @@
      Use APIC Physical Destination Mode (V4) : 0
                        Hardware Reduced (V5) : 1
                       Low Power S0 Idle (V5) : 0

 [074h 0116 00Ch]              Reset Register : [Generic Address Structure]
 [074h 0116 001h]                    Space ID : 00 [SystemMemory]
 [075h 0117 001h]                   Bit Width : 00
 [076h 0118 001h]                  Bit Offset : 00
 [077h 0119 001h]        Encoded Access Width : 00 [Undefined/Legacy]
 [078h 0120 008h]                     Address : 0000000000000000

 [080h 0128 001h]        Value to cause reset : 00
 [081h 0129 002h]   ARM Flags (decoded below) : 0000
                               PSCI Compliant : 0
                        Must use HVC for PSCI : 0

-[083h 0131 001h]         FADT Minor Revision : 05
+[083h 0131 001h]         FADT Minor Revision : 06
 [084h 0132 008h]                FACS Address : 0000000000000000
[...]

 /*
  *
  * ACPI Data Table [APIC]
  *
  * Format: [HexOffset DecimalOffset ByteLength]  FieldName : FieldValue (in hex)
  */

 [000h 0000 004h]                   Signature : "APIC"    [Multiple APIC Description Table (MADT)]
 [004h 0004 004h]                Table Length : 00000074
-[008h 0008 001h]                    Revision : 06
-[009h 0009 001h]                    Checksum : B4
+[008h 0008 001h]                    Revision : 07
+[009h 0009 001h]                    Checksum : B3
 [00Ah 0010 006h]                      Oem ID : "BOCHS "
 [010h 0016 008h]                Oem Table ID : "BXPC    "
[...]

Signed-off-by: Sunil V L <sunilvl@ventanamicro.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
---
 tests/data/acpi/riscv64/virt/APIC           | Bin 116 -> 116 bytes
 tests/data/acpi/riscv64/virt/FACP           | Bin 276 -> 276 bytes
 tests/qtest/bios-tables-test-allowed-diff.h |   2 --
 3 files changed, 2 deletions(-)

diff --git a/tests/data/acpi/riscv64/virt/APIC b/tests/data/acpi/riscv64/virt/APIC
index 66a25dfd2d6ea2b607c024722b2eab95873a01e9..3fb5b753596fc7c2618b3d5210be8b00b0c177f6 100644
GIT binary patch
delta 16
XcmXRZ;c^V{bS`0FU|`=okt+)TB&q~M

delta 16
XcmXRZ;c^V{bS`0FU|`!akt+)TB&h^L

diff --git a/tests/data/acpi/riscv64/virt/FACP b/tests/data/acpi/riscv64/virt/FACP
index a5276b65ea8ce46cc9b40d96d98f0669c9089ed4..78e1b14b1d4ff0533a6a4c041f195a69b4ef114d 100644
GIT binary patch
delta 30
mcmbQjG=+)F&CxkPgpq-PO=u!lB_rF!iPaMgcqj8PasU8k76z;U

delta 30
mcmbQjG=+)F&CxkPgpq-PO?V<#B_r#^iPaMgcqj8PasU8k8wRWZ

diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index 0c3f7a6cac..dfb8523c8b 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1,3 +1 @@
 /* List of comma-separated changed AML files to ignore */
-"tests/data/acpi/riscv64/virt/APIC",
-"tests/data/acpi/riscv64/virt/FACP",
-- 
2.43.0
Re: [PATCH v2 3/3] tests/data/acpi/riscv64: Update expected FADT and MADT
Posted by Nutty Liu 3 months, 3 weeks ago 
On 7/24/2025 7:03 PM, Sunil V L wrote:
> Update the expected tables for the version change.
>   /*
>    *
>    * ACPI Data Table [FACP]
>    *
>    * Format: [HexOffset DecimalOffset ByteLength]  FieldName : FieldValue (in hex)
>    */
>
>   [000h 0000 004h]                   Signature : "FACP"    [Fixed ACPI Description Table (FADT)]
>   [004h 0004 004h]                Table Length : 00000114
>   [008h 0008 001h]                    Revision : 06
> -[009h 0009 001h]                    Checksum : 13
> +[009h 0009 001h]                    Checksum : 12
>   [00Ah 0010 006h]                      Oem ID : "BOCHS "
>   [010h 0016 008h]                Oem Table ID : "BXPC    "
>   [018h 0024 004h]                Oem Revision : 00000001
>   [01Ch 0028 004h]             Asl Compiler ID : "BXPC"
>   [020h 0032 004h]       Asl Compiler Revision : 00000001
>
>   [024h 0036 004h]                FACS Address : 00000000
>   [028h 0040 004h]                DSDT Address : 00000000
>   [02Ch 0044 001h]                       Model : 00
>   [02Dh 0045 001h]                  PM Profile : 00 [Unspecified]
>   [02Eh 0046 002h]               SCI Interrupt : 0000
>   [030h 0048 004h]            SMI Command Port : 00000000
>   [034h 0052 001h]           ACPI Enable Value : 00
>   [035h 0053 001h]          ACPI Disable Value : 00
>   [036h 0054 001h]              S4BIOS Command : 00
>   [037h 0055 001h]             P-State Control : 00
> @@ -86,33 +86,33 @@
>        Use APIC Physical Destination Mode (V4) : 0
>                          Hardware Reduced (V5) : 1
>                         Low Power S0 Idle (V5) : 0
>
>   [074h 0116 00Ch]              Reset Register : [Generic Address Structure]
>   [074h 0116 001h]                    Space ID : 00 [SystemMemory]
>   [075h 0117 001h]                   Bit Width : 00
>   [076h 0118 001h]                  Bit Offset : 00
>   [077h 0119 001h]        Encoded Access Width : 00 [Undefined/Legacy]
>   [078h 0120 008h]                     Address : 0000000000000000
>
>   [080h 0128 001h]        Value to cause reset : 00
>   [081h 0129 002h]   ARM Flags (decoded below) : 0000
>                                 PSCI Compliant : 0
>                          Must use HVC for PSCI : 0
>
> -[083h 0131 001h]         FADT Minor Revision : 05
> +[083h 0131 001h]         FADT Minor Revision : 06
>   [084h 0132 008h]                FACS Address : 0000000000000000
> [...]
>
>   /*
>    *
>    * ACPI Data Table [APIC]
>    *
>    * Format: [HexOffset DecimalOffset ByteLength]  FieldName : FieldValue (in hex)
>    */
>
>   [000h 0000 004h]                   Signature : "APIC"    [Multiple APIC Description Table (MADT)]
>   [004h 0004 004h]                Table Length : 00000074
> -[008h 0008 001h]                    Revision : 06
> -[009h 0009 001h]                    Checksum : B4
> +[008h 0008 001h]                    Revision : 07
> +[009h 0009 001h]                    Checksum : B3
>   [00Ah 0010 006h]                      Oem ID : "BOCHS "
>   [010h 0016 008h]                Oem Table ID : "BXPC    "
> [...]
>
> Signed-off-by: Sunil V L <sunilvl@ventanamicro.com>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
Reviewed-by: Nutty Liu <liujingqi@lanxincomputing.com>

Thanks,
Nutty
>   tests/data/acpi/riscv64/virt/APIC           | Bin 116 -> 116 bytes
>   tests/data/acpi/riscv64/virt/FACP           | Bin 276 -> 276 bytes
>   tests/qtest/bios-tables-test-allowed-diff.h |   2 --
>   3 files changed, 2 deletions(-)
>
> diff --git a/tests/data/acpi/riscv64/virt/APIC b/tests/data/acpi/riscv64/virt/APIC
> index 66a25dfd2d6ea2b607c024722b2eab95873a01e9..3fb5b753596fc7c2618b3d5210be8b00b0c177f6 100644
> GIT binary patch
> delta 16
> XcmXRZ;c^V{bS`0FU|`=okt+)TB&q~M
>
> delta 16
> XcmXRZ;c^V{bS`0FU|`!akt+)TB&h^L
>
> diff --git a/tests/data/acpi/riscv64/virt/FACP b/tests/data/acpi/riscv64/virt/FACP
> index a5276b65ea8ce46cc9b40d96d98f0669c9089ed4..78e1b14b1d4ff0533a6a4c041f195a69b4ef114d 100644
> GIT binary patch
> delta 30
> mcmbQjG=+)F&CxkPgpq-PO=u!lB_rF!iPaMgcqj8PasU8k76z;U
>
> delta 30
> mcmbQjG=+)F&CxkPgpq-PO?V<#B_r#^iPaMgcqj8PasU8k8wRWZ
>
> diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
> index 0c3f7a6cac..dfb8523c8b 100644
> --- a/tests/qtest/bios-tables-test-allowed-diff.h
> +++ b/tests/qtest/bios-tables-test-allowed-diff.h
> @@ -1,3 +1 @@
>   /* List of comma-separated changed AML files to ignore */
> -"tests/data/acpi/riscv64/virt/APIC",
> -"tests/data/acpi/riscv64/virt/FACP",
Re: [PATCH v2 3/3] tests/data/acpi/riscv64: Update expected FADT and MADT
Posted by Daniel Henrique Barboza 3 months, 3 weeks ago 

On 7/24/25 8:03 AM, Sunil V L wrote:
> Update the expected tables for the version change.
>   /*
>    *
>    * ACPI Data Table [FACP]
>    *
>    * Format: [HexOffset DecimalOffset ByteLength]  FieldName : FieldValue (in hex)
>    */
> 
>   [000h 0000 004h]                   Signature : "FACP"    [Fixed ACPI Description Table (FADT)]
>   [004h 0004 004h]                Table Length : 00000114
>   [008h 0008 001h]                    Revision : 06
> -[009h 0009 001h]                    Checksum : 13
> +[009h 0009 001h]                    Checksum : 12
>   [00Ah 0010 006h]                      Oem ID : "BOCHS "
>   [010h 0016 008h]                Oem Table ID : "BXPC    "
>   [018h 0024 004h]                Oem Revision : 00000001
>   [01Ch 0028 004h]             Asl Compiler ID : "BXPC"
>   [020h 0032 004h]       Asl Compiler Revision : 00000001
> 
>   [024h 0036 004h]                FACS Address : 00000000
>   [028h 0040 004h]                DSDT Address : 00000000
>   [02Ch 0044 001h]                       Model : 00
>   [02Dh 0045 001h]                  PM Profile : 00 [Unspecified]
>   [02Eh 0046 002h]               SCI Interrupt : 0000
>   [030h 0048 004h]            SMI Command Port : 00000000
>   [034h 0052 001h]           ACPI Enable Value : 00
>   [035h 0053 001h]          ACPI Disable Value : 00
>   [036h 0054 001h]              S4BIOS Command : 00
>   [037h 0055 001h]             P-State Control : 00
> @@ -86,33 +86,33 @@
>        Use APIC Physical Destination Mode (V4) : 0
>                          Hardware Reduced (V5) : 1
>                         Low Power S0 Idle (V5) : 0
> 
>   [074h 0116 00Ch]              Reset Register : [Generic Address Structure]
>   [074h 0116 001h]                    Space ID : 00 [SystemMemory]
>   [075h 0117 001h]                   Bit Width : 00
>   [076h 0118 001h]                  Bit Offset : 00
>   [077h 0119 001h]        Encoded Access Width : 00 [Undefined/Legacy]
>   [078h 0120 008h]                     Address : 0000000000000000
> 
>   [080h 0128 001h]        Value to cause reset : 00
>   [081h 0129 002h]   ARM Flags (decoded below) : 0000
>                                 PSCI Compliant : 0
>                          Must use HVC for PSCI : 0
> 
> -[083h 0131 001h]         FADT Minor Revision : 05
> +[083h 0131 001h]         FADT Minor Revision : 06
>   [084h 0132 008h]                FACS Address : 0000000000000000
> [...]
> 
>   /*
>    *
>    * ACPI Data Table [APIC]
>    *
>    * Format: [HexOffset DecimalOffset ByteLength]  FieldName : FieldValue (in hex)
>    */
> 
>   [000h 0000 004h]                   Signature : "APIC"    [Multiple APIC Description Table (MADT)]
>   [004h 0004 004h]                Table Length : 00000074
> -[008h 0008 001h]                    Revision : 06
> -[009h 0009 001h]                    Checksum : B4
> +[008h 0008 001h]                    Revision : 07
> +[009h 0009 001h]                    Checksum : B3
>   [00Ah 0010 006h]                      Oem ID : "BOCHS "
>   [010h 0016 008h]                Oem Table ID : "BXPC    "
> [...]
> 
> Signed-off-by: Sunil V L <sunilvl@ventanamicro.com>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---

Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>

>   tests/data/acpi/riscv64/virt/APIC           | Bin 116 -> 116 bytes
>   tests/data/acpi/riscv64/virt/FACP           | Bin 276 -> 276 bytes
>   tests/qtest/bios-tables-test-allowed-diff.h |   2 --
>   3 files changed, 2 deletions(-)
> 
> diff --git a/tests/data/acpi/riscv64/virt/APIC b/tests/data/acpi/riscv64/virt/APIC
> index 66a25dfd2d6ea2b607c024722b2eab95873a01e9..3fb5b753596fc7c2618b3d5210be8b00b0c177f6 100644
> GIT binary patch
> delta 16
> XcmXRZ;c^V{bS`0FU|`=okt+)TB&q~M
> 
> delta 16
> XcmXRZ;c^V{bS`0FU|`!akt+)TB&h^L
> 
> diff --git a/tests/data/acpi/riscv64/virt/FACP b/tests/data/acpi/riscv64/virt/FACP
> index a5276b65ea8ce46cc9b40d96d98f0669c9089ed4..78e1b14b1d4ff0533a6a4c041f195a69b4ef114d 100644
> GIT binary patch
> delta 30
> mcmbQjG=+)F&CxkPgpq-PO=u!lB_rF!iPaMgcqj8PasU8k76z;U
> 
> delta 30
> mcmbQjG=+)F&CxkPgpq-PO?V<#B_r#^iPaMgcqj8PasU8k8wRWZ
> 
> diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
> index 0c3f7a6cac..dfb8523c8b 100644
> --- a/tests/qtest/bios-tables-test-allowed-diff.h
> +++ b/tests/qtest/bios-tables-test-allowed-diff.h
> @@ -1,3 +1 @@
>   /* List of comma-separated changed AML files to ignore */
> -"tests/data/acpi/riscv64/virt/APIC",
> -"tests/data/acpi/riscv64/virt/FACP",

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.