migration: show error message when postcopy fails

[PATCH] migration: show error message when postcopy fails

Daniel P. Berrangé posted 1 patch 3 months, 3 weeks ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20250721133913.2914669-1-berrange@redhat.com

Maintainers: Peter Xu <peterx@redhat.com>, Fabiano Rosas <farosas@suse.de>

migration/migration-hmp-cmds.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Expand all Fold all

[PATCH] migration: show error message when postcopy fails

Posted by Daniel P. Berrangé 3 months, 3 weeks ago

The 'info migrate' command only shows the error message when the
migration state is 'failed'. When postcopy is used, however,
the 'postcopy-paused' state is used instead of 'failed', so we
must show the error message there too.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 migration/migration-hmp-cmds.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/migration/migration-hmp-cmds.c b/migration/migration-hmp-cmds.c
index cef5608210..07fd227edc 100644
--- a/migration/migration-hmp-cmds.c
+++ b/migration/migration-hmp-cmds.c
@@ -153,7 +153,8 @@ void hmp_info_migrate(Monitor *mon, const QDict *qdict)
     if (info->has_status) {
         monitor_printf(mon, "Status: \t\t%s",
                        MigrationStatus_str(info->status));
-        if (info->status == MIGRATION_STATUS_FAILED && info->error_desc) {
+        if ((info->status == MIGRATION_STATUS_FAILED ||
+             info->status == MIGRATION_STATUS_POSTCOPY_PAUSED) && info->error_desc) {
             monitor_printf(mon, " (%s)\n", info->error_desc);
         } else {
             monitor_printf(mon, "\n");
-- 
2.50.1

Re: [PATCH] migration: show error message when postcopy fails

Posted by Fabiano Rosas 3 months, 3 weeks ago

Daniel P. Berrangé <berrange@redhat.com> writes:

> The 'info migrate' command only shows the error message when the
> migration state is 'failed'. When postcopy is used, however,
> the 'postcopy-paused' state is used instead of 'failed', so we
> must show the error message there too.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  migration/migration-hmp-cmds.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/migration/migration-hmp-cmds.c b/migration/migration-hmp-cmds.c
> index cef5608210..07fd227edc 100644
> --- a/migration/migration-hmp-cmds.c
> +++ b/migration/migration-hmp-cmds.c
> @@ -153,7 +153,8 @@ void hmp_info_migrate(Monitor *mon, const QDict *qdict)
>      if (info->has_status) {
>          monitor_printf(mon, "Status: \t\t%s",
>                         MigrationStatus_str(info->status));
> -        if (info->status == MIGRATION_STATUS_FAILED && info->error_desc) {
> +        if ((info->status == MIGRATION_STATUS_FAILED ||
> +             info->status == MIGRATION_STATUS_POSTCOPY_PAUSED) && info->error_desc) {
>              monitor_printf(mon, " (%s)\n", info->error_desc);
>          } else {
>              monitor_printf(mon, "\n");

Reviewed-by: Fabiano Rosas <farosas@suse.de>

queued