[PATCH 4/4] tests: acpi: update expected blobs

Vadim Chichikalyuk posted 4 patches 3 months, 4 weeks ago
Maintainers: "Michael S. Tsirkin" <mst@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Ani Sinha <anisinha@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Shannon Zhao <shannon.zhaosl@gmail.com>
[PATCH 4/4] tests: acpi: update expected blobs
Posted by Vadim Chichikalyuk 3 months, 4 weeks ago
Previous patch changed the SPCR ACPI table for AArch64 virt:
@@ -15,2 +15,2 @@
-[008h 0008 001h]                    Revision : 02
-[009h 0009 001h]                    Checksum : B1
+[008h 0008 001h]                    Revision : 03
+[009h 0009 001h]                    Checksum : 0B
@@ -49 +49 @@
-[04Ch 0076 004h]                    Reserved : 00000000
+[04Ch 0076 004h]                    Reserved : 016E3600
@@ -53 +53 @@
-0000: 53 50 43 52 50 00 00 00 02 B1 42 4F 43 48 53 20  // SPCRP.....BOCHS
+0000: 53 50 43 52 50 00 00 00 03 0B 42 4F 43 48 53 20  // SPCRP.....BOCHS
@@ -57 +57 @@
-0040: FF FF FF FF 00 00 00 00 00 00 00 00 00 00 00 00  // ................
+0040: FF FF FF FF 00 00 00 00 00 00 00 00 00 36 6E 01  // .............6n.

In a revision 3 SPCR table, the "Reserved" field is the UART clock frequency
field.

Signed-off-by: Vadim Chichikalyuk <chichikalyuk@gmail.com>
---
 tests/data/acpi/aarch64/virt/SPCR           | Bin 80 -> 80 bytes
 tests/qtest/bios-tables-test-allowed-diff.h |   1 -
 2 files changed, 1 deletion(-)

diff --git a/tests/data/acpi/aarch64/virt/SPCR b/tests/data/acpi/aarch64/virt/SPCR
index cf0f2b75226515097c08d2e2016a83a4f08812ba..76ac417fbdc4dc6a473c51b82164f40bc5320c58 100644
GIT binary patch
delta 20
bcmWFt;0g|K4hmpkU|{B+$mPszmd6MHD|7?L

delta 20
acmWFt;0g|K4hmpkU|`xfk;|DG$N&H@90SJy

diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index 2a30472d57..dfb8523c8b 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1,2 +1 @@
 /* List of comma-separated changed AML files to ignore */
-"tests/data/acpi/aarch64/virt/SPCR",
\ No newline at end of file
-- 
2.39.5 (Apple Git-154)
Re: [PATCH 4/4] tests: acpi: update expected blobs
Posted by Jonathan Cameron via 3 months, 3 weeks ago
On Fri, 18 Jul 2025 19:20:45 +0300
Vadim Chichikalyuk <chichikalyuk@gmail.com> wrote:

> Previous patch changed the SPCR ACPI table for AArch64 virt:
> @@ -15,2 +15,2 @@
> -[008h 0008 001h]                    Revision : 02
> -[009h 0009 001h]                    Checksum : B1
> +[008h 0008 001h]                    Revision : 03
> +[009h 0009 001h]                    Checksum : 0B
> @@ -49 +49 @@
> -[04Ch 0076 004h]                    Reserved : 00000000
> +[04Ch 0076 004h]                    Reserved : 016E3600

Hmm. No support in acpi-tools?  Old version maybe?

Looks like v4 support was added in this pull request last year
https://github.com/acpica/acpica/pull/931

Jonathan


> @@ -53 +53 @@
> -0000: 53 50 43 52 50 00 00 00 02 B1 42 4F 43 48 53 20  // SPCRP.....BOCHS
> +0000: 53 50 43 52 50 00 00 00 03 0B 42 4F 43 48 53 20  // SPCRP.....BOCHS
> @@ -57 +57 @@
> -0040: FF FF FF FF 00 00 00 00 00 00 00 00 00 00 00 00  // ................
> +0040: FF FF FF FF 00 00 00 00 00 00 00 00 00 36 6E 01  // .............6n.
> 
> In a revision 3 SPCR table, the "Reserved" field is the UART clock frequency
> field.
> 
> Signed-off-by: Vadim Chichikalyuk <chichikalyuk@gmail.com>
> ---
>  tests/data/acpi/aarch64/virt/SPCR           | Bin 80 -> 80 bytes
>  tests/qtest/bios-tables-test-allowed-diff.h |   1 -
>  2 files changed, 1 deletion(-)
> 
> diff --git a/tests/data/acpi/aarch64/virt/SPCR b/tests/data/acpi/aarch64/virt/SPCR
> index cf0f2b75226515097c08d2e2016a83a4f08812ba..76ac417fbdc4dc6a473c51b82164f40bc5320c58 100644
> GIT binary patch
> delta 20
> bcmWFt;0g|K4hmpkU|{B+$mPszmd6MHD|7?L
> 
> delta 20
> acmWFt;0g|K4hmpkU|`xfk;|DG$N&H@90SJy
> 
> diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
> index 2a30472d57..dfb8523c8b 100644
> --- a/tests/qtest/bios-tables-test-allowed-diff.h
> +++ b/tests/qtest/bios-tables-test-allowed-diff.h
> @@ -1,2 +1 @@
>  /* List of comma-separated changed AML files to ignore */
> -"tests/data/acpi/aarch64/virt/SPCR",
> \ No newline at end of file