net/passt: Fix build failure due to missing GIO dependency

[PATCH] net/passt: Fix build failure due to missing GIO dependency

Posted by Laurent Vivier 3 months, 4 weeks ago

The passt networking backend uses functions from the GIO library,
such as g_subprocess_launcher_new(), to manage its daemon process.
So, building with passt enabled requires GIO to be available.

If we enable passt and disable gio the build fails during linkage with
undefined reference errors:

  /usr/bin/ld: libsystem.a.p/net_passt.c.o: in function `net_passt_start_daemon':
  net/passt.c:250: undefined reference to `g_subprocess_launcher_new'
  /usr/bin/ld: net/passt.c:251: undefined reference to `g_subprocess_launcher_take_fd'
  /usr/bin/ld: net/passt.c:253: undefined reference to `g_subprocess_launcher_spawnv'
  /usr/bin/ld: net/passt.c:256: undefined reference to `g_object_unref'
  /usr/bin/ld: net/passt.c:263: undefined reference to `g_subprocess_wait'
  /usr/bin/ld: net/passt.c:268: undefined reference to `g_subprocess_get_if_exited'
  /usr/bin/ld: libsystem.a.p/net_passt.c.o: in function `glib_autoptr_clear_GSubprocess':
  /usr/include/glib-2.0/gio/gio-autocleanups.h:132: undefined reference to `g_object_unref'
  /usr/bin/ld: libsystem.a.p/net_passt.c.o: in function `net_passt_start_daemon':
  net/passt.c:269: undefined reference to `g_subprocess_get_exit_status'

Fix this by adding an explicit weson dependency on GIO for the passt
option.
The existing dependency on linux is kept because passt is only available
on this OS.

Reported-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
 meson.build | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meson.build b/meson.build
index c2bc3eeedce9..5842dd026a6f 100644
--- a/meson.build
+++ b/meson.build
@@ -1287,6 +1287,7 @@ endif
 
 enable_passt = get_option('passt') \
   .require(host_os == 'linux', error_message: 'passt is supported only on Linux') \
+  .require(gio.found(), error_message: 'passt requires gio') \
   .allowed()
 
 vde = not_found
-- 
2.49.0

Re: [PATCH] net/passt: Fix build failure due to missing GIO dependency

Posted by Peter Maydell 1 month, 2 weeks ago

On Fri, 18 Jul 2025 at 14:32, Laurent Vivier <lvivier@redhat.com> wrote:
>
> The passt networking backend uses functions from the GIO library,
> such as g_subprocess_launcher_new(), to manage its daemon process.
> So, building with passt enabled requires GIO to be available.
>
> If we enable passt and disable gio the build fails during linkage with
> undefined reference errors:
>
>   /usr/bin/ld: libsystem.a.p/net_passt.c.o: in function `net_passt_start_daemon':
>   net/passt.c:250: undefined reference to `g_subprocess_launcher_new'
>   /usr/bin/ld: net/passt.c:251: undefined reference to `g_subprocess_launcher_take_fd'
>   /usr/bin/ld: net/passt.c:253: undefined reference to `g_subprocess_launcher_spawnv'
>   /usr/bin/ld: net/passt.c:256: undefined reference to `g_object_unref'
>   /usr/bin/ld: net/passt.c:263: undefined reference to `g_subprocess_wait'
>   /usr/bin/ld: net/passt.c:268: undefined reference to `g_subprocess_get_if_exited'
>   /usr/bin/ld: libsystem.a.p/net_passt.c.o: in function `glib_autoptr_clear_GSubprocess':
>   /usr/include/glib-2.0/gio/gio-autocleanups.h:132: undefined reference to `g_object_unref'
>   /usr/bin/ld: libsystem.a.p/net_passt.c.o: in function `net_passt_start_daemon':
>   net/passt.c:269: undefined reference to `g_subprocess_get_exit_status'
>
> Fix this by adding an explicit weson dependency on GIO for the passt
> option.
> The existing dependency on linux is kept because passt is only available
> on this OS.
>
> Reported-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>


I've picked this up via target-arm.next, and added some tags:
Cc: qemu-stable@nongnu.org
Fixes: 854ee02b222 ("net: Add passt network backend")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3121

-- PMM

Re: [PATCH] net/passt: Fix build failure due to missing GIO dependency

Posted by Thomas Huth 3 months, 4 weeks ago

On 18/07/2025 15.31, Laurent Vivier wrote:
> The passt networking backend uses functions from the GIO library,
> such as g_subprocess_launcher_new(), to manage its daemon process.
> So, building with passt enabled requires GIO to be available.
> 
> If we enable passt and disable gio the build fails during linkage with
> undefined reference errors:
> 
>    /usr/bin/ld: libsystem.a.p/net_passt.c.o: in function `net_passt_start_daemon':
>    net/passt.c:250: undefined reference to `g_subprocess_launcher_new'
>    /usr/bin/ld: net/passt.c:251: undefined reference to `g_subprocess_launcher_take_fd'
>    /usr/bin/ld: net/passt.c:253: undefined reference to `g_subprocess_launcher_spawnv'
>    /usr/bin/ld: net/passt.c:256: undefined reference to `g_object_unref'
>    /usr/bin/ld: net/passt.c:263: undefined reference to `g_subprocess_wait'
>    /usr/bin/ld: net/passt.c:268: undefined reference to `g_subprocess_get_if_exited'
>    /usr/bin/ld: libsystem.a.p/net_passt.c.o: in function `glib_autoptr_clear_GSubprocess':
>    /usr/include/glib-2.0/gio/gio-autocleanups.h:132: undefined reference to `g_object_unref'
>    /usr/bin/ld: libsystem.a.p/net_passt.c.o: in function `net_passt_start_daemon':
>    net/passt.c:269: undefined reference to `g_subprocess_get_exit_status'
> 
> Fix this by adding an explicit weson dependency on GIO for the passt
> option.
> The existing dependency on linux is kept because passt is only available
> on this OS.
> 
> Reported-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
>   meson.build | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/meson.build b/meson.build
> index c2bc3eeedce9..5842dd026a6f 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -1287,6 +1287,7 @@ endif
>   
>   enable_passt = get_option('passt') \
>     .require(host_os == 'linux', error_message: 'passt is supported only on Linux') \
> +  .require(gio.found(), error_message: 'passt requires gio') \
>     .allowed()
>   
>   vde = not_found

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [PATCH] net/passt: Fix build failure due to missing GIO dependency

Posted by Daniel P. Berrangé 3 months, 4 weeks ago

On Fri, Jul 18, 2025 at 03:31:10PM +0200, Laurent Vivier wrote:
> The passt networking backend uses functions from the GIO library,
> such as g_subprocess_launcher_new(), to manage its daemon process.
> So, building with passt enabled requires GIO to be available.
> 
> If we enable passt and disable gio the build fails during linkage with
> undefined reference errors:
> 
>   /usr/bin/ld: libsystem.a.p/net_passt.c.o: in function `net_passt_start_daemon':
>   net/passt.c:250: undefined reference to `g_subprocess_launcher_new'
>   /usr/bin/ld: net/passt.c:251: undefined reference to `g_subprocess_launcher_take_fd'
>   /usr/bin/ld: net/passt.c:253: undefined reference to `g_subprocess_launcher_spawnv'
>   /usr/bin/ld: net/passt.c:256: undefined reference to `g_object_unref'
>   /usr/bin/ld: net/passt.c:263: undefined reference to `g_subprocess_wait'
>   /usr/bin/ld: net/passt.c:268: undefined reference to `g_subprocess_get_if_exited'
>   /usr/bin/ld: libsystem.a.p/net_passt.c.o: in function `glib_autoptr_clear_GSubprocess':
>   /usr/include/glib-2.0/gio/gio-autocleanups.h:132: undefined reference to `g_object_unref'
>   /usr/bin/ld: libsystem.a.p/net_passt.c.o: in function `net_passt_start_daemon':
>   net/passt.c:269: undefined reference to `g_subprocess_get_exit_status'
> 
> Fix this by adding an explicit weson dependency on GIO for the passt
> option.
> The existing dependency on linux is kept because passt is only available
> on this OS.
> 
> Reported-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
>  meson.build | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|