[PATCH v2 1/4] qga: Fix guest-network-get-route return value documentation

Markus Armbruster posted 4 patches 4 months ago
Maintainers: Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>, Michael Roth <michael.roth@amd.com>, Kostiantyn Kostiuk <kkostiuk@redhat.com>
[PATCH v2 1/4] qga: Fix guest-network-get-route return value documentation
Posted by Markus Armbruster 4 months ago
Tagged sections are only recognized at the beginning of a paragraph.
guest-network-get-route's Returns: isn't, and therefore gets rendered
as ordinary text within its paragraph:

    Retrieve information about route of network. Returns: List of route
    info of guest.

Since there is no (recognized) Returns: section, the doc generator
adds

    Return:
       [GuestNetworkRoute]

Note: only since recent commit 636c96cd77d (qapi: Fix undocumented
return values by generating something).

Insert the required blank line so that Returns: is recognized.
Result:

    Retrieve information about route of network.

    Return:
       [GuestNetworkRoute] -- List of route info of guest.

Fixes: commit 8e326d36dd16 (qga/linux: Add new api 'guest-network-get-route')
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
---
 qga/qapi-schema.json | 1 +
 1 file changed, 1 insertion(+)

diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
index 6d770f7b8e..a569a14b55 100644
--- a/qga/qapi-schema.json
+++ b/qga/qapi-schema.json
@@ -1966,6 +1966,7 @@
 # @guest-network-get-route:
 #
 # Retrieve information about route of network.
+#
 # Returns: List of route info of guest.
 #
 # Since: 9.1
-- 
2.49.0


Re: [PATCH v2 1/4] qga: Fix guest-network-get-route return value documentation
Posted by John Snow 3 months, 3 weeks ago
On Thu, Jul 17, 2025 at 7:52 AM Markus Armbruster <armbru@redhat.com> wrote:
>
> Tagged sections are only recognized at the beginning of a paragraph.
> guest-network-get-route's Returns: isn't, and therefore gets rendered
> as ordinary text within its paragraph:
>
>     Retrieve information about route of network. Returns: List of route
>     info of guest.
>
> Since there is no (recognized) Returns: section, the doc generator
> adds
>
>     Return:
>        [GuestNetworkRoute]
>
> Note: only since recent commit 636c96cd77d (qapi: Fix undocumented
> return values by generating something).
>
> Insert the required blank line so that Returns: is recognized.
> Result:
>
>     Retrieve information about route of network.
>
>     Return:
>        [GuestNetworkRoute] -- List of route info of guest.
>
> Fixes: commit 8e326d36dd16 (qga/linux: Add new api 'guest-network-get-route')
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

Reviewed-by: John Snow <jsnow@redhat.com>

> ---
>  qga/qapi-schema.json | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
> index 6d770f7b8e..a569a14b55 100644
> --- a/qga/qapi-schema.json
> +++ b/qga/qapi-schema.json
> @@ -1966,6 +1966,7 @@
>  # @guest-network-get-route:
>  #
>  # Retrieve information about route of network.
> +#
>  # Returns: List of route info of guest.
>  #
>  # Since: 9.1
> --
> 2.49.0
>