[PATCH] i386/cpu: Cleanup host_cpu_max_instance_init()

Xiaoyao Li posted 1 patch 4 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20250716063117.602050-1-xiaoyao.li@intel.com
Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Zhao Liu <zhao1.liu@intel.com>
target/i386/host-cpu.h | 1 -
1 file changed, 1 deletion(-)
[PATCH] i386/cpu: Cleanup host_cpu_max_instance_init()
Posted by Xiaoyao Li 4 months ago
The implementation of host_cpu_max_instance_init() was merged into
host_cpu_instance_init() by commit 29f1ba338baf ("target/i386: merge
host_cpu_instance_init() and host_cpu_max_instance_init()"), while the
declaration of it remains in host-cpu.h.

Clean it up.

Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
---
 target/i386/host-cpu.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/target/i386/host-cpu.h b/target/i386/host-cpu.h
index 10df4b3a3a74..ee6532422548 100644
--- a/target/i386/host-cpu.h
+++ b/target/i386/host-cpu.h
@@ -12,7 +12,6 @@
 
 uint32_t host_cpu_phys_bits(void);
 void host_cpu_instance_init(X86CPU *cpu);
-void host_cpu_max_instance_init(X86CPU *cpu);
 bool host_cpu_realizefn(CPUState *cs, Error **errp);
 
 void host_cpu_vendor_fms(char *vendor, int *family, int *model, int *stepping);
-- 
2.43.0
Re: [PATCH] i386/cpu: Cleanup host_cpu_max_instance_init()
Posted by Paolo Bonzini 4 months ago
Queued, thanks.

Paolo
Re: [PATCH] i386/cpu: Cleanup host_cpu_max_instance_init()
Posted by Zhao Liu 4 months ago
On Wed, Jul 16, 2025 at 02:31:16PM +0800, Xiaoyao Li wrote:
> Date: Wed, 16 Jul 2025 14:31:16 +0800
> From: Xiaoyao Li <xiaoyao.li@intel.com>
> Subject: [PATCH] i386/cpu: Cleanup host_cpu_max_instance_init()
> X-Mailer: git-send-email 2.43.0
> 
> The implementation of host_cpu_max_instance_init() was merged into
> host_cpu_instance_init() by commit 29f1ba338baf ("target/i386: merge
> host_cpu_instance_init() and host_cpu_max_instance_init()"), while the
> declaration of it remains in host-cpu.h.
> 
> Clean it up.
> 
> Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
> ---
>  target/i386/host-cpu.h | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
Re: [PATCH] i386/cpu: Cleanup host_cpu_max_instance_init()
Posted by Philippe Mathieu-Daudé 4 months ago
On 16/7/25 08:31, Xiaoyao Li wrote:
> The implementation of host_cpu_max_instance_init() was merged into
> host_cpu_instance_init() by commit 29f1ba338baf ("target/i386: merge
> host_cpu_instance_init() and host_cpu_max_instance_init()"), while the
> declaration of it remains in host-cpu.h.
> 
> Clean it up.
> 
> Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
> ---
>   target/i386/host-cpu.h | 1 -
>   1 file changed, 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>