vfio: improve use of QOM and coding guidelines

[PATCH 05/22] ppc/spapr_pci_vfio.c: use QOM casts where appropriate

Posted by Mark Cave-Ayland 4 months ago

Use a QOM cast to convert to VFIOContainer instead of accessing bcontainer
directly.

Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
---
 hw/ppc/spapr_pci_vfio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/ppc/spapr_pci_vfio.c b/hw/ppc/spapr_pci_vfio.c
index e318d0d912..7e1c71ef59 100644
--- a/hw/ppc/spapr_pci_vfio.c
+++ b/hw/ppc/spapr_pci_vfio.c
@@ -106,7 +106,7 @@ static VFIOContainer *vfio_eeh_as_container(AddressSpace *as)
 
 out:
     vfio_address_space_put(space);
-    return container_of(bcontainer, VFIOContainer, bcontainer);
+    return VFIO_IOMMU_LEGACY(bcontainer);
 }
 
 static bool vfio_eeh_as_ok(AddressSpace *as)
-- 
2.43.0

Re: [PATCH 05/22] ppc/spapr_pci_vfio.c: use QOM casts where appropriate

Posted by Cédric Le Goater 3 months ago

On 7/15/25 11:25, Mark Cave-Ayland wrote:
> Use a QOM cast to convert to VFIOContainer instead of accessing bcontainer
> directly.
> 
> Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>

Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.


> ---
>   hw/ppc/spapr_pci_vfio.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/ppc/spapr_pci_vfio.c b/hw/ppc/spapr_pci_vfio.c
> index e318d0d912..7e1c71ef59 100644
> --- a/hw/ppc/spapr_pci_vfio.c
> +++ b/hw/ppc/spapr_pci_vfio.c
> @@ -106,7 +106,7 @@ static VFIOContainer *vfio_eeh_as_container(AddressSpace *as)
>   
>   out:
>       vfio_address_space_put(space);
> -    return container_of(bcontainer, VFIOContainer, bcontainer);
> +    return VFIO_IOMMU_LEGACY(bcontainer);
>   }
>   
>   static bool vfio_eeh_as_ok(AddressSpace *as)

Re: [PATCH 05/22] ppc/spapr_pci_vfio.c: use QOM casts where appropriate

Posted by Harsh Prateek Bora 4 months ago


On 7/15/25 14:55, Mark Cave-Ayland wrote:
> Use a QOM cast to convert to VFIOContainer instead of accessing bcontainer
> directly.
> 
> Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>

Reviewed-by: Harsh Prateek Bora <harshpb@linux.ibm.com>

> ---
>   hw/ppc/spapr_pci_vfio.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/ppc/spapr_pci_vfio.c b/hw/ppc/spapr_pci_vfio.c
> index e318d0d912..7e1c71ef59 100644
> --- a/hw/ppc/spapr_pci_vfio.c
> +++ b/hw/ppc/spapr_pci_vfio.c
> @@ -106,7 +106,7 @@ static VFIOContainer *vfio_eeh_as_container(AddressSpace *as)
>   
>   out:
>       vfio_address_space_put(space);
> -    return container_of(bcontainer, VFIOContainer, bcontainer);
> +    return VFIO_IOMMU_LEGACY(bcontainer);
>   }
>   
>   static bool vfio_eeh_as_ok(AddressSpace *as)