vfio: improve use of QOM and coding guidelines

[PATCH 14/22] vfio/pci.h: update VFIOPCIDevice declaration

Posted by Mark Cave-Ayland 4 months ago

Update the VFIOPCIDevice declaration so that it is closer to our coding
guidelines: add a blank line after the parent object.

Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
---
 hw/vfio/pci.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/vfio/pci.h b/hw/vfio/pci.h
index 495fae737d..16f092a0c6 100644
--- a/hw/vfio/pci.h
+++ b/hw/vfio/pci.h
@@ -132,6 +132,7 @@ OBJECT_DECLARE_SIMPLE_TYPE(VFIOPCIDevice, VFIO_PCI_BASE)
 
 struct VFIOPCIDevice {
     PCIDevice pdev;
+
     VFIODevice vbasedev;
     VFIOINTx intx;
     unsigned int config_size;
-- 
2.43.0

Re: [PATCH 14/22] vfio/pci.h: update VFIOPCIDevice declaration

Posted by Cédric Le Goater 3 months ago

On 7/15/25 11:25, Mark Cave-Ayland wrote:
> Update the VFIOPCIDevice declaration so that it is closer to our coding
> guidelines: add a blank line after the parent object.
> 
> Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>


Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.


> ---
>   hw/vfio/pci.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/hw/vfio/pci.h b/hw/vfio/pci.h
> index 495fae737d..16f092a0c6 100644
> --- a/hw/vfio/pci.h
> +++ b/hw/vfio/pci.h
> @@ -132,6 +132,7 @@ OBJECT_DECLARE_SIMPLE_TYPE(VFIOPCIDevice, VFIO_PCI_BASE)
>   
>   struct VFIOPCIDevice {
>       PCIDevice pdev;
> +
>       VFIODevice vbasedev;
>       VFIOINTx intx;
>       unsigned int config_size;

Re: [PATCH 14/22] vfio/pci.h: update VFIOPCIDevice declaration

Posted by Philippe Mathieu-Daudé 4 months ago

On 15/7/25 11:25, Mark Cave-Ayland wrote:
> Update the VFIOPCIDevice declaration so that it is closer to our coding
> guidelines: add a blank line after the parent object.
> 
> Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
> ---
>   hw/vfio/pci.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/hw/vfio/pci.h b/hw/vfio/pci.h
> index 495fae737d..16f092a0c6 100644
> --- a/hw/vfio/pci.h
> +++ b/hw/vfio/pci.h
> @@ -132,6 +132,7 @@ OBJECT_DECLARE_SIMPLE_TYPE(VFIOPCIDevice, VFIO_PCI_BASE)
>   
>   struct VFIOPCIDevice {
>       PCIDevice pdev;
> +

Could be squashed with #22, anyhow:

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

>       VFIODevice vbasedev;
>       VFIOINTx intx;
>       unsigned int config_size;