vfio: improve use of QOM and coding guidelines

[PATCH 13/22] vfio-user/pci.c: rename VFIOUserPCIDevice device field to parent_obj

Posted by Mark Cave-Ayland 4 months ago

Now that nothing accesses the device field directly, rename device to
parent_obj as per our current coding guidelines.

Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
---
 hw/vfio-user/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/vfio-user/pci.c b/hw/vfio-user/pci.c
index e23a941605..9380766548 100644
--- a/hw/vfio-user/pci.c
+++ b/hw/vfio-user/pci.c
@@ -20,7 +20,7 @@
 OBJECT_DECLARE_SIMPLE_TYPE(VFIOUserPCIDevice, VFIO_USER_PCI)
 
 struct VFIOUserPCIDevice {
-    VFIOPCIDevice device;
+    VFIOPCIDevice parent_obj;
 
     SocketAddress *socket;
     bool send_queued;   /* all sends are queued */
-- 
2.43.0

Re: [PATCH 13/22] vfio-user/pci.c: rename VFIOUserPCIDevice device field to parent_obj

Posted by Cédric Le Goater 3 months ago

On 7/15/25 11:25, Mark Cave-Ayland wrote:
> Now that nothing accesses the device field directly, rename device to
> parent_obj as per our current coding guidelines.
> 
> Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>


Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.


> ---
>   hw/vfio-user/pci.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/vfio-user/pci.c b/hw/vfio-user/pci.c
> index e23a941605..9380766548 100644
> --- a/hw/vfio-user/pci.c
> +++ b/hw/vfio-user/pci.c
> @@ -20,7 +20,7 @@
>   OBJECT_DECLARE_SIMPLE_TYPE(VFIOUserPCIDevice, VFIO_USER_PCI)
>   
>   struct VFIOUserPCIDevice {
> -    VFIOPCIDevice device;
> +    VFIOPCIDevice parent_obj;
>   
>       SocketAddress *socket;
>       bool send_queued;   /* all sends are queued */

Re: [PATCH 13/22] vfio-user/pci.c: rename VFIOUserPCIDevice device field to parent_obj

Posted by John Levon 4 months ago

On Tue, Jul 15, 2025 at 10:25:53AM +0100, Mark Cave-Ayland wrote:

> Now that nothing accesses the device field directly, rename device to
> parent_obj as per our current coding guidelines.
> 
> Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
> ---
>  hw/vfio-user/pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/vfio-user/pci.c b/hw/vfio-user/pci.c
> index e23a941605..9380766548 100644
> --- a/hw/vfio-user/pci.c
> +++ b/hw/vfio-user/pci.c
> @@ -20,7 +20,7 @@
>  OBJECT_DECLARE_SIMPLE_TYPE(VFIOUserPCIDevice, VFIO_USER_PCI)
>  
>  struct VFIOUserPCIDevice {
> -    VFIOPCIDevice device;
> +    VFIOPCIDevice parent_obj;
>  
>      SocketAddress *socket;
>      bool send_queued;   /* all sends are queued */

Reviewed-by: John Levon <john.levon@nutanix.com>

Re: [PATCH 13/22] vfio-user/pci.c: rename VFIOUserPCIDevice device field to parent_obj

Posted by Philippe Mathieu-Daudé 4 months ago

On 15/7/25 11:25, Mark Cave-Ayland wrote:
> Now that nothing accesses the device field directly, rename device to
> parent_obj as per our current coding guidelines.
> 
> Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
> ---
>   hw/vfio-user/pci.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/vfio-user/pci.c b/hw/vfio-user/pci.c
> index e23a941605..9380766548 100644
> --- a/hw/vfio-user/pci.c
> +++ b/hw/vfio-user/pci.c
> @@ -20,7 +20,7 @@
>   OBJECT_DECLARE_SIMPLE_TYPE(VFIOUserPCIDevice, VFIO_USER_PCI)
>   
>   struct VFIOUserPCIDevice {
> -    VFIOPCIDevice device;
> +    VFIOPCIDevice parent_obj;

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>