1. Patchew
  2. QEMU
  3. [PATCH 00/22] vfio: improve use of QOM and coding guidelines
  4. View patch

[PATCH 11/22] vfio-user/pci.c: update VFIOUserPCIDevice declaration

Mark Cave-Ayland posted 22 patches 4 months ago
Maintainers: Nicholas Piggin <npiggin@gmail.com>, Daniel Henrique Barboza <danielhb413@gmail.com>, Harsh Prateek Bora <harshpb@linux.ibm.com>, Matthew Rosato <mjrosato@linux.ibm.com>, Eric Farman <farman@linux.ibm.com>, Richard Henderson <richard.henderson@linaro.org>, David Hildenbrand <david@redhat.com>, Ilya Leoshkevich <iii@linux.ibm.com>, Thomas Huth <thuth@redhat.com>, Halil Pasic <pasic@linux.ibm.com>, Christian Borntraeger <borntraeger@linux.ibm.com>, John Levon <john.levon@nutanix.com>, Thanos Makatos <thanos.makatos@nutanix.com>, Alex Williamson <alex.williamson@redhat.com>, "Cédric Le Goater" <clg@redhat.com>, Steve Sistare <steven.sistare@oracle.com>, Tomita Moeko <tomitamoeko@gmail.com>
[PATCH 11/22] vfio-user/pci.c: update VFIOUserPCIDevice declaration
Posted by Mark Cave-Ayland 4 months ago 
Update the VFIOUserPCIDevice declaration so that it is closer to our coding
guidelines: add a blank line after the parent object.

Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
---
 hw/vfio-user/pci.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/vfio-user/pci.c b/hw/vfio-user/pci.c
index be71c77729..da6fe51809 100644
--- a/hw/vfio-user/pci.c
+++ b/hw/vfio-user/pci.c
@@ -21,6 +21,7 @@ OBJECT_DECLARE_SIMPLE_TYPE(VFIOUserPCIDevice, VFIO_USER_PCI)
 
 struct VFIOUserPCIDevice {
     VFIOPCIDevice device;
+
     SocketAddress *socket;
     bool send_queued;   /* all sends are queued */
     uint32_t wait_time; /* timeout for message replies */
-- 
2.43.0
Re: [PATCH 11/22] vfio-user/pci.c: update VFIOUserPCIDevice declaration
Posted by Cédric Le Goater 3 months ago 
On 7/15/25 11:25, Mark Cave-Ayland wrote:
> Update the VFIOUserPCIDevice declaration so that it is closer to our coding
> guidelines: add a blank line after the parent object.
> 
> Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>


Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.


> ---
>   hw/vfio-user/pci.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/hw/vfio-user/pci.c b/hw/vfio-user/pci.c
> index be71c77729..da6fe51809 100644
> --- a/hw/vfio-user/pci.c
> +++ b/hw/vfio-user/pci.c
> @@ -21,6 +21,7 @@ OBJECT_DECLARE_SIMPLE_TYPE(VFIOUserPCIDevice, VFIO_USER_PCI)
>   
>   struct VFIOUserPCIDevice {
>       VFIOPCIDevice device;
> +
>       SocketAddress *socket;
>       bool send_queued;   /* all sends are queued */
>       uint32_t wait_time; /* timeout for message replies */
Re: [PATCH 11/22] vfio-user/pci.c: update VFIOUserPCIDevice declaration
Posted by John Levon 4 months ago 
On Tue, Jul 15, 2025 at 10:25:51AM +0100, Mark Cave-Ayland wrote:

> Update the VFIOUserPCIDevice declaration so that it is closer to our coding
> guidelines: add a blank line after the parent object.
> 
> Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
> ---
>  hw/vfio-user/pci.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/vfio-user/pci.c b/hw/vfio-user/pci.c
> index be71c77729..da6fe51809 100644
> --- a/hw/vfio-user/pci.c
> +++ b/hw/vfio-user/pci.c
> @@ -21,6 +21,7 @@ OBJECT_DECLARE_SIMPLE_TYPE(VFIOUserPCIDevice, VFIO_USER_PCI)
>  
>  struct VFIOUserPCIDevice {
>      VFIOPCIDevice device;
> +
>      SocketAddress *socket;
>      bool send_queued;   /* all sends are queued */
>      uint32_t wait_time; /* timeout for message replies */

Reviewed-by: John Levon <john.levon@nutanix.com>
Re: [PATCH 11/22] vfio-user/pci.c: update VFIOUserPCIDevice declaration
Posted by BALATON Zoltan 4 months ago 
On Tue, 15 Jul 2025, Mark Cave-Ayland wrote:
> Update the VFIOUserPCIDevice declaration so that it is closer to our coding
> guidelines: add a blank line after the parent object.
>
> Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
> ---
> hw/vfio-user/pci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/vfio-user/pci.c b/hw/vfio-user/pci.c
> index be71c77729..da6fe51809 100644
> --- a/hw/vfio-user/pci.c
> +++ b/hw/vfio-user/pci.c
> @@ -21,6 +21,7 @@ OBJECT_DECLARE_SIMPLE_TYPE(VFIOUserPCIDevice, VFIO_USER_PCI)
>
> struct VFIOUserPCIDevice {
>     VFIOPCIDevice device;
> +

This isn't worth a separate patch. Can be squashed in patch 13.

Regards,
BALATON Zoltan

>     SocketAddress *socket;
>     bool send_queued;   /* all sends are queued */
>     uint32_t wait_time; /* timeout for message replies */
>
Re: [PATCH 11/22] vfio-user/pci.c: update VFIOUserPCIDevice declaration
Posted by Philippe Mathieu-Daudé 4 months ago 
On 15/7/25 11:25, Mark Cave-Ayland wrote:
> Update the VFIOUserPCIDevice declaration so that it is closer to our coding
> guidelines: add a blank line after the parent object.
> 
> Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
> ---
>   hw/vfio-user/pci.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/hw/vfio-user/pci.c b/hw/vfio-user/pci.c
> index be71c77729..da6fe51809 100644
> --- a/hw/vfio-user/pci.c
> +++ b/hw/vfio-user/pci.c
> @@ -21,6 +21,7 @@ OBJECT_DECLARE_SIMPLE_TYPE(VFIOUserPCIDevice, VFIO_USER_PCI)
>   
>   struct VFIOUserPCIDevice {
>       VFIOPCIDevice device;

s/device/parent_obj/?

> +
>       SocketAddress *socket;
>       bool send_queued;   /* all sends are queued */
>       uint32_t wait_time; /* timeout for message replies */

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Re: [PATCH 11/22] vfio-user/pci.c: update VFIOUserPCIDevice declaration
Posted by Philippe Mathieu-Daudé 4 months ago 
On 15/7/25 11:42, Philippe Mathieu-Daudé wrote:
> On 15/7/25 11:25, Mark Cave-Ayland wrote:
>> Update the VFIOUserPCIDevice declaration so that it is closer to our 
>> coding
>> guidelines: add a blank line after the parent object.
>>
>> Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
>> ---
>>   hw/vfio-user/pci.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/hw/vfio-user/pci.c b/hw/vfio-user/pci.c
>> index be71c77729..da6fe51809 100644
>> --- a/hw/vfio-user/pci.c
>> +++ b/hw/vfio-user/pci.c
>> @@ -21,6 +21,7 @@ OBJECT_DECLARE_SIMPLE_TYPE(VFIOUserPCIDevice, 
>> VFIO_USER_PCI)
>>   struct VFIOUserPCIDevice {
>>       VFIOPCIDevice device;
> 
> s/device/parent_obj/?

Patch #13, OK ;)

> 
>> +
>>       SocketAddress *socket;
>>       bool send_queued;   /* all sends are queued */
>>       uint32_t wait_time; /* timeout for message replies */
> 
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.