vfio: improve use of QOM and coding guidelines

[PATCH 10/22] vfio-user/container.h: rename VFIOUserContainer bcontainer field to parent_obj

Posted by Mark Cave-Ayland 4 months ago

Now that nothing accesses the bcontainer field directly, rename bcontainer to
parent_obj as per our current coding guidelines.

Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
---
 hw/vfio-user/container.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/vfio-user/container.h b/hw/vfio-user/container.h
index d5d2275af7..96aa6785d9 100644
--- a/hw/vfio-user/container.h
+++ b/hw/vfio-user/container.h
@@ -14,7 +14,7 @@
 
 /* MMU container sub-class for vfio-user. */
 struct VFIOUserContainer {
-    VFIOContainerBase bcontainer;
+    VFIOContainerBase parent_obj;
 
     VFIOUserProxy *proxy;
 };
-- 
2.43.0

Re: [PATCH 10/22] vfio-user/container.h: rename VFIOUserContainer bcontainer field to parent_obj

Posted by Cédric Le Goater 3 months ago

On 7/15/25 11:25, Mark Cave-Ayland wrote:
> Now that nothing accesses the bcontainer field directly, rename bcontainer to
> parent_obj as per our current coding guidelines.
> 
> Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>


Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.


> ---
>   hw/vfio-user/container.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/vfio-user/container.h b/hw/vfio-user/container.h
> index d5d2275af7..96aa6785d9 100644
> --- a/hw/vfio-user/container.h
> +++ b/hw/vfio-user/container.h
> @@ -14,7 +14,7 @@
>   
>   /* MMU container sub-class for vfio-user. */
>   struct VFIOUserContainer {
> -    VFIOContainerBase bcontainer;
> +    VFIOContainerBase parent_obj;
>   
>       VFIOUserProxy *proxy;
>   };

Re: [PATCH 10/22] vfio-user/container.h: rename VFIOUserContainer bcontainer field to parent_obj

Posted by John Levon 4 months ago

On Tue, Jul 15, 2025 at 10:25:50AM +0100, Mark Cave-Ayland wrote:

> Now that nothing accesses the bcontainer field directly, rename bcontainer to
> parent_obj as per our current coding guidelines.
> 
> Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
> ---
>  hw/vfio-user/container.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/vfio-user/container.h b/hw/vfio-user/container.h
> index d5d2275af7..96aa6785d9 100644
> --- a/hw/vfio-user/container.h
> +++ b/hw/vfio-user/container.h
> @@ -14,7 +14,7 @@
>  
>  /* MMU container sub-class for vfio-user. */
>  struct VFIOUserContainer {
> -    VFIOContainerBase bcontainer;
> +    VFIOContainerBase parent_obj;
>  
>      VFIOUserProxy *proxy;
>  };

Reviewed-by: John Levon <john.levon@nutanix.com>

Re: [PATCH 10/22] vfio-user/container.h: rename VFIOUserContainer bcontainer field to parent_obj

Posted by Philippe Mathieu-Daudé 4 months ago

On 15/7/25 11:25, Mark Cave-Ayland wrote:
> Now that nothing accesses the bcontainer field directly, rename bcontainer to
> parent_obj as per our current coding guidelines.
> 
> Signed-off-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
> ---
>   hw/vfio-user/container.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>