[v2] Ui patches

[PULL v2 00/13] Ui patches

marcandre.lureau@redhat.com posted 13 patches 4 months ago

Diff against v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v1 v2 v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20250715063301.145191-1-marcandre.lureau@redhat.com

Maintainers: Paolo Bonzini <pbonzini@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Eduardo Habkost <eduardo@habkost.net>, "Michael S. Tsirkin" <mst@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org>, Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>, Dmitry Osipenko <dmitry.osipenko@collabora.com>, Gerd Hoffmann <kraxel@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>, Stefan Berger <stefanb@linux.vnet.ibm.com>

There is a newer version of this series

qapi/ui.json                        |  15 +-
qapi/virtio.json                    |  18 +-
include/hw/display/edid.h           |   2 +
include/hw/qdev-properties-system.h |   5 +
include/hw/virtio/virtio-gpu.h      |   3 +
include/ui/console.h                |   3 +
include/ui/gtk.h                    |   2 +
include/ui/spice-display.h          |   5 +
include/ui/surface.h                |   1 +
ui/vnc.h                            |  49 +--
hw/core/qdev-properties-system.c    |  44 +++
hw/display/virtio-gpu-base.c        |  27 ++
system/tpm.c                        |   5 +-
ui/console-gl.c                     |  54 ++++
ui/egl-helpers.c                    |   6 +
ui/gtk.c                            |  58 ++--
ui/spice-core.c                     |  32 ++
ui/spice-display.c                  | 226 +++++++++++++-
ui/vnc-enc-tight.c                  | 456 +++++++++++++++-------------
ui/vnc-enc-zlib.c                   |  47 +--
ui/vnc-enc-zrle.c                   | 122 ++++----
ui/vnc-jobs.c                       |  13 +-
ui/vnc.c                            |  83 +++--
ui/vnc-enc-zrle.c.inc               |  20 +-
qemu-options.hx                     |  13 +
25 files changed, 883 insertions(+), 426 deletions(-)

Expand all Fold all

[PULL v2 00/13] Ui patches

Posted by marcandre.lureau@redhat.com 4 months ago

From: Marc-André Lureau <marcandre.lureau@redhat.com>

The following changes since commit 9a4e273ddec3927920c5958d2226c6b38b543336:

  Merge tag 'pull-tcg-20250711' of https://gitlab.com/rth7680/qemu into staging (2025-07-13 01:46:04 -0400)

are available in the Git repository at:

  https://gitlab.com/marcandre.lureau/qemu.git tags/ui-pull-request

for you to fetch changes up to df892b3954e5b2782165e6c59e5ffd55c2f7ec5a:

  tpm: "qemu -tpmdev help" should return success (2025-07-15 10:22:33 +0400)

----------------------------------------------------------------
UI-related for 10.1

- [PATCH v3 0/2] ui/vnc: Do not copy z_stream
- [PATCH v6 0/7] ui/spice: Enable gl=on option for non-local or remote clients
- [PATCH v6 0/1] Allow injection of virtio-gpu EDID name
- [PATCH 0/2] ui/gtk: Add keep-aspect-ratio and scale option

----------------------------------------------------------------

Akihiko Odaki (2):
  ui/vnc: Do not copy z_stream
  ui/vnc: Introduce the VncWorker type

Andrew Keesler (1):
  hw/display: Allow injection of virtio-gpu EDID name

Marc-André Lureau (1):
  tpm: "qemu -tpmdev help" should return success

Vivek Kasireddy (7):
  ui/egl-helpers: Error check the fds in egl_dmabuf_export_texture()
  ui/spice: Enable gl=on option for non-local or remote clients
  ui/spice: Add an option for users to provide a preferred video codec
  ui/spice: Add an option to submit gl_draw requests at fixed rate
  ui/console-gl: Add a helper to create a texture with linear memory
    layout
  ui/spice: Create a new texture with linear layout when gl=on is
    specified
  ui/spice: Blit the scanout texture if its memory layout is not linear

Weifeng Liu (2):
  ui/gtk: Add keep-aspect-ratio option
  ui/gtk: Add scale option

 qapi/ui.json                        |  15 +-
 qapi/virtio.json                    |  18 +-
 include/hw/display/edid.h           |   2 +
 include/hw/qdev-properties-system.h |   5 +
 include/hw/virtio/virtio-gpu.h      |   3 +
 include/ui/console.h                |   3 +
 include/ui/gtk.h                    |   2 +
 include/ui/spice-display.h          |   5 +
 include/ui/surface.h                |   1 +
 ui/vnc.h                            |  49 +--
 hw/core/qdev-properties-system.c    |  44 +++
 hw/display/virtio-gpu-base.c        |  27 ++
 system/tpm.c                        |   5 +-
 ui/console-gl.c                     |  54 ++++
 ui/egl-helpers.c                    |   6 +
 ui/gtk.c                            |  58 ++--
 ui/spice-core.c                     |  32 ++
 ui/spice-display.c                  | 226 +++++++++++++-
 ui/vnc-enc-tight.c                  | 456 +++++++++++++++-------------
 ui/vnc-enc-zlib.c                   |  47 +--
 ui/vnc-enc-zrle.c                   | 122 ++++----
 ui/vnc-jobs.c                       |  13 +-
 ui/vnc.c                            |  83 +++--
 ui/vnc-enc-zrle.c.inc               |  20 +-
 qemu-options.hx                     |  13 +
 25 files changed, 883 insertions(+), 426 deletions(-)

-- 
2.50.0

Re: [PULL v2 00/13] Ui patches

Posted by Marc-André Lureau 4 months ago

Hi

On Tue, Jul 15, 2025 at 10:36 AM <marcandre.lureau@redhat.com> wrote:
>
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> The following changes since commit 9a4e273ddec3927920c5958d2226c6b38b543336:
>
>   Merge tag 'pull-tcg-20250711' of https://gitlab.com/rth7680/qemu into staging (2025-07-13 01:46:04 -0400)
>
> are available in the Git repository at:
>
>   https://gitlab.com/marcandre.lureau/qemu.git tags/ui-pull-request
>
> for you to fetch changes up to df892b3954e5b2782165e6c59e5ffd55c2f7ec5a:
>
>   tpm: "qemu -tpmdev help" should return success (2025-07-15 10:22:33 +0400)
>
> ----------------------------------------------------------------
> UI-related for 10.1
>
> - [PATCH v3 0/2] ui/vnc: Do not copy z_stream
> - [PATCH v6 0/7] ui/spice: Enable gl=on option for non-local or remote clients
> - [PATCH v6 0/1] Allow injection of virtio-gpu EDID name
> - [PATCH 0/2] ui/gtk: Add keep-aspect-ratio and scale option
>
> ----------------------------------------------------------------
>
> Akihiko Odaki (2):
>   ui/vnc: Do not copy z_stream
>   ui/vnc: Introduce the VncWorker type

Checkpatch complains with a false positive here:
ERROR: spaces required around that '*' (ctx:WxB)
#250: FILE: ui/vnc-enc-tight.c:356:
+        data = (uint##bpp##_t *)tight->tight.buffer;                    \
                               ^

ERROR: spaces required around that '*' (ctx:WxV)
#327: FILE: ui/vnc-enc-tight.c:614:
+                               uint##bpp##_t *buf, int w, int h) {      \
                                              ^

total: 2 errors, 0 warnings, 1790 lines checked

Please ignore

>
> Andrew Keesler (1):
>   hw/display: Allow injection of virtio-gpu EDID name
>
> Marc-André Lureau (1):
>   tpm: "qemu -tpmdev help" should return success
>
> Vivek Kasireddy (7):
>   ui/egl-helpers: Error check the fds in egl_dmabuf_export_texture()
>   ui/spice: Enable gl=on option for non-local or remote clients
>   ui/spice: Add an option for users to provide a preferred video codec
>   ui/spice: Add an option to submit gl_draw requests at fixed rate
>   ui/console-gl: Add a helper to create a texture with linear memory
>     layout
>   ui/spice: Create a new texture with linear layout when gl=on is
>     specified
>   ui/spice: Blit the scanout texture if its memory layout is not linear
>
> Weifeng Liu (2):
>   ui/gtk: Add keep-aspect-ratio option
>   ui/gtk: Add scale option
>
>  qapi/ui.json                        |  15 +-
>  qapi/virtio.json                    |  18 +-
>  include/hw/display/edid.h           |   2 +
>  include/hw/qdev-properties-system.h |   5 +
>  include/hw/virtio/virtio-gpu.h      |   3 +
>  include/ui/console.h                |   3 +
>  include/ui/gtk.h                    |   2 +
>  include/ui/spice-display.h          |   5 +
>  include/ui/surface.h                |   1 +
>  ui/vnc.h                            |  49 +--
>  hw/core/qdev-properties-system.c    |  44 +++
>  hw/display/virtio-gpu-base.c        |  27 ++
>  system/tpm.c                        |   5 +-
>  ui/console-gl.c                     |  54 ++++
>  ui/egl-helpers.c                    |   6 +
>  ui/gtk.c                            |  58 ++--
>  ui/spice-core.c                     |  32 ++
>  ui/spice-display.c                  | 226 +++++++++++++-
>  ui/vnc-enc-tight.c                  | 456 +++++++++++++++-------------
>  ui/vnc-enc-zlib.c                   |  47 +--
>  ui/vnc-enc-zrle.c                   | 122 ++++----
>  ui/vnc-jobs.c                       |  13 +-
>  ui/vnc.c                            |  83 +++--
>  ui/vnc-enc-zrle.c.inc               |  20 +-
>  qemu-options.hx                     |  13 +
>  25 files changed, 883 insertions(+), 426 deletions(-)
>
> --
> 2.50.0
>
>


-- 
Marc-André Lureau

Re: [PULL v2 00/13] Ui patches

Posted by Stefan Hajnoczi 4 months ago

Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes.