[PULL 00/17] MIPS & Co. patches for 2025-07-15

Philippe Mathieu-Daudé posted 17 patches 4 months ago
Failed in applying to current master (apply log)
Maintainers: Song Gao <gaosong@loongson.cn>, Bibo Mao <maobibo@loongson.cn>, Jiaxun Yang <jiaxun.yang@flygoat.com>, Paolo Bonzini <pbonzini@redhat.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Fam Zheng <fam@euphon.net>, Aurelien Jarno <aurelien@aurel32.net>, Aleksandar Rikalo <arikalo@gmail.com>
include/hw/scsi/esp.h                         |  15 +-
target/mips/helper.h                          |   2 +
target/mips/tcg/translate.h                   |   4 +
tests/tcg/mips/include/wrappers_mips64r6.h    |  32 ++++
target/mips/tcg/octeon.decode                 |   8 +
target/mips/tcg/rel6.decode                   |   5 +
hw/intc/loongarch_extioi_kvm.c                |   1 -
hw/mips/cps.c                                 |   4 +-
hw/scsi/esp.c                                 |  94 ++++++++++--
target/mips/tcg/msa_translate.c               |   4 +-
target/mips/tcg/octeon_translate.c            |  12 ++
target/mips/tcg/op_helper.c                   |  26 ++++
target/mips/tcg/rel6_translate.c              |  16 +-
target/mips/tcg/translate.c                   | 102 +++++++------
target/mips/tcg/translate_addr_const.c        |   4 +-
.../isa/mips64r6/crc/test_mips64r6_crc32b.c   | 142 ++++++++++++++++++
.../isa/mips64r6/crc/test_mips64r6_crc32cb.c  | 142 ++++++++++++++++++
.../isa/mips64r6/crc/test_mips64r6_crc32cd.c  | 142 ++++++++++++++++++
.../isa/mips64r6/crc/test_mips64r6_crc32ch.c  | 142 ++++++++++++++++++
.../isa/mips64r6/crc/test_mips64r6_crc32cw.c  | 142 ++++++++++++++++++
.../isa/mips64r6/crc/test_mips64r6_crc32d.c   | 142 ++++++++++++++++++
.../isa/mips64r6/crc/test_mips64r6_crc32h.c   | 142 ++++++++++++++++++
.../isa/mips64r6/crc/test_mips64r6_crc32w.c   | 142 ++++++++++++++++++
target/mips/cpu-defs.c.inc                    |  10 +-
target/mips/tcg/micromips_translate.c.inc     |   2 +-
target/mips/tcg/nanomips_translate.c.inc      |   7 +-
hw/microblaze/Kconfig                         |   4 +-
hw/mips/Kconfig                               |   2 +-
hw/misc/Kconfig                               |   1 +
hw/scsi/trace-events                          |   1 +
pc-bios/hppa-firmware.img                     | Bin
pc-bios/hppa-firmware64.img                   | Bin
target/mips/meson.build                       |   1 +
tests/tcg/mips/user/isa/mips64r6/crc/Makefile |  40 +++++
34 files changed, 1447 insertions(+), 86 deletions(-)
create mode 100644 tests/tcg/mips/user/isa/mips64r6/crc/test_mips64r6_crc32b.c
create mode 100644 tests/tcg/mips/user/isa/mips64r6/crc/test_mips64r6_crc32cb.c
create mode 100644 tests/tcg/mips/user/isa/mips64r6/crc/test_mips64r6_crc32cd.c
create mode 100644 tests/tcg/mips/user/isa/mips64r6/crc/test_mips64r6_crc32ch.c
create mode 100644 tests/tcg/mips/user/isa/mips64r6/crc/test_mips64r6_crc32cw.c
create mode 100644 tests/tcg/mips/user/isa/mips64r6/crc/test_mips64r6_crc32d.c
create mode 100644 tests/tcg/mips/user/isa/mips64r6/crc/test_mips64r6_crc32h.c
create mode 100644 tests/tcg/mips/user/isa/mips64r6/crc/test_mips64r6_crc32w.c
mode change 100755 => 100644 pc-bios/hppa-firmware.img
mode change 100755 => 100644 pc-bios/hppa-firmware64.img
create mode 100644 tests/tcg/mips/user/isa/mips64r6/crc/Makefile
[PULL 00/17] MIPS & Co. patches for 2025-07-15
Posted by Philippe Mathieu-Daudé 4 months ago
The following changes since commit 9a4e273ddec3927920c5958d2226c6b38b543336:

  Merge tag 'pull-tcg-20250711' of https://gitlab.com/rth7680/qemu into staging (2025-07-13 01:46:04 -0400)

are available in the Git repository at:

  https://github.com/philmd/qemu.git tags/mips-20250715

for you to fetch changes up to 6f8ce26bb00db66e6cec632f16df3cd13e4df934:

  esp.c: only allow ESP commands permitted in the current asc_mode (2025-07-15 00:25:21 +0200)

----------------------------------------------------------------
MIPS patches queue

- Implement CRC32[c] (Release 6) instructions
- Convert Octeon LX instructions to decodetree
- Restrict ITU to TCG
- Fix ESP issue affecting WinNT (INACCESSIBLE_BOOT_DEVICE BSOD)
- Add missing FDT dependency for some MicroBlaze machines
- Remove execute bit on hppa-firmware blobs

----------------------------------------------------------------

Aleksandar Rakic (1):
  tests/tcg/mips: Add tests for MIPS CRC32[c] instructions

Bernhard Beschow (1):
  hw/microblaze: Add missing FDT dependency

Cole Robinson (1):
  roms: re-remove execute bit from hppa-firmware*

Mark Cave-Ayland (7):
  esp.c: only raise IRQ in esp_transfer_data() for CMD_SEL, CMD_SELATN
    and CMD_TI commands
  esp.c: improve comment in esp_transfer_data()
  esp.h: remove separate ESPState typedef
  esp.c: only call dma_memory_read function if transfer length is
    non-zero
  esp.c: only call dma_memory_write function if transfer length is
    non-zero
  esp.c: add asc_mode property to indicate the current ESP mode
  esp.c: only allow ESP commands permitted in the current asc_mode

Philippe Mathieu-Daudé (6):
  target/mips: Extract gen_base_index_addr() helper
  target/mips: Extract generic gen_lx() helper
  target/mips: Convert Octeon LX instructions to decodetree
  target/mips: Have gen_[d]lsa() callers add 1 to shift amount argument
  hw/mips: Restrict ITU to TCG
  hw/intc/loongarch_extioi: Remove unnecessary 'qemu/typedefs.h' include

Yongbok Kim (1):
  target/mips: Add support for emulation of CRC32 instructions

 include/hw/scsi/esp.h                         |  15 +-
 target/mips/helper.h                          |   2 +
 target/mips/tcg/translate.h                   |   4 +
 tests/tcg/mips/include/wrappers_mips64r6.h    |  32 ++++
 target/mips/tcg/octeon.decode                 |   8 +
 target/mips/tcg/rel6.decode                   |   5 +
 hw/intc/loongarch_extioi_kvm.c                |   1 -
 hw/mips/cps.c                                 |   4 +-
 hw/scsi/esp.c                                 |  94 ++++++++++--
 target/mips/tcg/msa_translate.c               |   4 +-
 target/mips/tcg/octeon_translate.c            |  12 ++
 target/mips/tcg/op_helper.c                   |  26 ++++
 target/mips/tcg/rel6_translate.c              |  16 +-
 target/mips/tcg/translate.c                   | 102 +++++++------
 target/mips/tcg/translate_addr_const.c        |   4 +-
 .../isa/mips64r6/crc/test_mips64r6_crc32b.c   | 142 ++++++++++++++++++
 .../isa/mips64r6/crc/test_mips64r6_crc32cb.c  | 142 ++++++++++++++++++
 .../isa/mips64r6/crc/test_mips64r6_crc32cd.c  | 142 ++++++++++++++++++
 .../isa/mips64r6/crc/test_mips64r6_crc32ch.c  | 142 ++++++++++++++++++
 .../isa/mips64r6/crc/test_mips64r6_crc32cw.c  | 142 ++++++++++++++++++
 .../isa/mips64r6/crc/test_mips64r6_crc32d.c   | 142 ++++++++++++++++++
 .../isa/mips64r6/crc/test_mips64r6_crc32h.c   | 142 ++++++++++++++++++
 .../isa/mips64r6/crc/test_mips64r6_crc32w.c   | 142 ++++++++++++++++++
 target/mips/cpu-defs.c.inc                    |  10 +-
 target/mips/tcg/micromips_translate.c.inc     |   2 +-
 target/mips/tcg/nanomips_translate.c.inc      |   7 +-
 hw/microblaze/Kconfig                         |   4 +-
 hw/mips/Kconfig                               |   2 +-
 hw/misc/Kconfig                               |   1 +
 hw/scsi/trace-events                          |   1 +
 pc-bios/hppa-firmware.img                     | Bin
 pc-bios/hppa-firmware64.img                   | Bin
 target/mips/meson.build                       |   1 +
 tests/tcg/mips/user/isa/mips64r6/crc/Makefile |  40 +++++
 34 files changed, 1447 insertions(+), 86 deletions(-)
 create mode 100644 tests/tcg/mips/user/isa/mips64r6/crc/test_mips64r6_crc32b.c
 create mode 100644 tests/tcg/mips/user/isa/mips64r6/crc/test_mips64r6_crc32cb.c
 create mode 100644 tests/tcg/mips/user/isa/mips64r6/crc/test_mips64r6_crc32cd.c
 create mode 100644 tests/tcg/mips/user/isa/mips64r6/crc/test_mips64r6_crc32ch.c
 create mode 100644 tests/tcg/mips/user/isa/mips64r6/crc/test_mips64r6_crc32cw.c
 create mode 100644 tests/tcg/mips/user/isa/mips64r6/crc/test_mips64r6_crc32d.c
 create mode 100644 tests/tcg/mips/user/isa/mips64r6/crc/test_mips64r6_crc32h.c
 create mode 100644 tests/tcg/mips/user/isa/mips64r6/crc/test_mips64r6_crc32w.c
 mode change 100755 => 100644 pc-bios/hppa-firmware.img
 mode change 100755 => 100644 pc-bios/hppa-firmware64.img
 create mode 100644 tests/tcg/mips/user/isa/mips64r6/crc/Makefile

-- 
2.49.0


Re: [PULL 00/17] MIPS & Co. patches for 2025-07-15
Posted by Philippe Mathieu-Daudé 4 months ago
On 15/7/25 08:19, Philippe Mathieu-Daudé wrote:
> The following changes since commit 9a4e273ddec3927920c5958d2226c6b38b543336:
> 
>    Merge tag 'pull-tcg-20250711' of https://gitlab.com/rth7680/qemu into staging (2025-07-13 01:46:04 -0400)
> 
> are available in the Git repository at:
> 
>    https://github.com/philmd/qemu.git tags/mips-20250715
> 
> for you to fetch changes up to 6f8ce26bb00db66e6cec632f16df3cd13e4df934:
> 
>    esp.c: only allow ESP commands permitted in the current asc_mode (2025-07-15 00:25:21 +0200)
> 
> ----------------------------------------------------------------
> MIPS patches queue
> 
> - Implement CRC32[c] (Release 6) instructions
> - Convert Octeon LX instructions to decodetree
> - Restrict ITU to TCG
> - Fix ESP issue affecting WinNT (INACCESSIBLE_BOOT_DEVICE BSOD)
> - Add missing FDT dependency for some MicroBlaze machines
> - Remove execute bit on hppa-firmware blobs
> 
> ----------------------------------------------------------------

BTW the 2 checkpatch errors are spurious:

4/17 Checking commit 23ecff81ac88 (target/mips: Convert Octeon LX 
instructions to decodetree)
WARNING: Saw acceptable license 'LGPL-2.1-or-later' but note 
'GPL-2.0-or-later' is preferred for new files unless the code is derived 
from a source file with an existing declared license that must be 
retained. Please explain the license choice in the commit message.
total: 0 errors, 1 warnings, 42 lines checked

-> no license change / addition.

6/17 Checking commit c083f1f3de93 (tests/tcg/mips: Add tests for MIPS 
CRC32[c] instructions)
WARNING: added, moved or deleted file(s):

   tests/tcg/mips/user/isa/mips64r6/crc/test_mips64r6_crc32b.c
   tests/tcg/mips/user/isa/mips64r6/crc/test_mips64r6_crc32cb.c
   tests/tcg/mips/user/isa/mips64r6/crc/test_mips64r6_crc32cd.c
   tests/tcg/mips/user/isa/mips64r6/crc/test_mips64r6_crc32ch.c
   tests/tcg/mips/user/isa/mips64r6/crc/test_mips64r6_crc32cw.c
   tests/tcg/mips/user/isa/mips64r6/crc/test_mips64r6_crc32d.c
   tests/tcg/mips/user/isa/mips64r6/crc/test_mips64r6_crc32h.c
   tests/tcg/mips/user/isa/mips64r6/crc/test_mips64r6_crc32w.c
   tests/tcg/mips/user/isa/mips64r6/crc/Makefile

Does MAINTAINERS need updating?

->

$ ./scripts/get_maintainer.pl -f 
tests/tcg/mips/user/isa/mips64r6/crc/Makefile
"Philippe Mathieu-Daudé" <philmd@linaro.org> (odd fixer:MIPS TCG CPUs)
Aurelien Jarno <aurelien@aurel32.net> (reviewer:MIPS TCG CPUs)
Jiaxun Yang <jiaxun.yang@flygoat.com> (reviewer:MIPS TCG CPUs)
Aleksandar Rikalo <arikalo@gmail.com> (reviewer:MIPS TCG CPUs)
qemu-devel@nongnu.org (open list:All patches CC here)


Re: [PULL 00/17] MIPS & Co. patches for 2025-07-15
Posted by Stefan Hajnoczi 4 months ago
Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes.