[v3] hw/arm/virt: Add support for user-creatable accelerated SMMUv3

[RFC PATCH v3 15/15] hw/arm/smmu-common: Add accel property for SMMU dev

Posted by Shameer Kolothum via 4 months ago

Now user can set "accel=on". Have fun!

Signed-off-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
---
 hw/arm/smmu-common.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/arm/smmu-common.c b/hw/arm/smmu-common.c
index 6a58f574d3..3e8783670a 100644
--- a/hw/arm/smmu-common.c
+++ b/hw/arm/smmu-common.c
@@ -1022,6 +1022,7 @@ static const Property smmu_dev_properties[] = {
     DEFINE_PROP_BOOL("smmu_per_bus", SMMUState, smmu_per_bus, false),
     DEFINE_PROP_LINK("primary-bus", SMMUState, primary_bus,
                      TYPE_PCI_BUS, PCIBus *),
+    DEFINE_PROP_BOOL("accel", SMMUState, accel, false),
 };
 
 static void smmu_base_class_init(ObjectClass *klass, const void *data)
-- 
2.34.1

Re: [RFC PATCH v3 15/15] hw/arm/smmu-common: Add accel property for SMMU dev

Posted by Eric Auger 2 months, 1 week ago

Hi Shameer,

On 7/14/25 5:59 PM, Shameer Kolothum wrote:
> Now user can set "accel=on". Have fun!
>
> Signed-off-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
> ---
>  hw/arm/smmu-common.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/hw/arm/smmu-common.c b/hw/arm/smmu-common.c
> index 6a58f574d3..3e8783670a 100644
> --- a/hw/arm/smmu-common.c
> +++ b/hw/arm/smmu-common.c
> @@ -1022,6 +1022,7 @@ static const Property smmu_dev_properties[] = {
>      DEFINE_PROP_BOOL("smmu_per_bus", SMMUState, smmu_per_bus, false),
>      DEFINE_PROP_LINK("primary-bus", SMMUState, primary_bus,
>                       TYPE_PCI_BUS, PCIBus *),
> +    DEFINE_PROP_BOOL("accel", SMMUState, accel, false),
would be nice to add some documentation as done in
4526687bf126 ("vfio: Add property documentation")

Eric
>  };
>  
>  static void smmu_base_class_init(ObjectClass *klass, const void *data)

Re: [RFC PATCH v3 15/15] hw/arm/smmu-common: Add accel property for SMMU dev

Posted by Jonathan Cameron via 4 months ago

On Mon, 14 Jul 2025 16:59:41 +0100
Shameer Kolothum <shameerali.kolothum.thodi@huawei.com> wrote:

> Now user can set "accel=on". Have fun!
> 
> Signed-off-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>

Hard to argue with this one ;)

Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>

> ---
>  hw/arm/smmu-common.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/arm/smmu-common.c b/hw/arm/smmu-common.c
> index 6a58f574d3..3e8783670a 100644
> --- a/hw/arm/smmu-common.c
> +++ b/hw/arm/smmu-common.c
> @@ -1022,6 +1022,7 @@ static const Property smmu_dev_properties[] = {
>      DEFINE_PROP_BOOL("smmu_per_bus", SMMUState, smmu_per_bus, false),
>      DEFINE_PROP_LINK("primary-bus", SMMUState, primary_bus,
>                       TYPE_PCI_BUS, PCIBus *),
> +    DEFINE_PROP_BOOL("accel", SMMUState, accel, false),
>  };
>  
>  static void smmu_base_class_init(ObjectClass *klass, const void *data)

Re: [RFC PATCH v3 15/15] hw/arm/smmu-common: Add accel property for SMMU dev

Posted by Nicolin Chen 4 months ago

On Mon, Jul 14, 2025 at 04:59:41PM +0100, Shameer Kolothum wrote:
> Now user can set "accel=on". Have fun!
> 
> Signed-off-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
 
Reviewed-by: Nicolin Chen <nicolinc@nvidia.com>