1. Patchew
  2. QEMU
  3. View series

[PULL 00/13] Ui patches

marcandre.lureau@redhat.com posted 13 patches 4 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20250714111039.4150419-1-marcandre.lureau@redhat.com
Maintainers: Paolo Bonzini <pbonzini@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Eduardo Habkost <eduardo@habkost.net>, "Michael S. Tsirkin" <mst@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org>, Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>, Dmitry Osipenko <dmitry.osipenko@collabora.com>, Gerd Hoffmann <kraxel@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>, Stefan Berger <stefanb@linux.vnet.ibm.com>
There is a newer version of this series
qapi/ui.json                        |  15 +-
qapi/virtio.json                    |  18 +-
include/hw/display/edid.h           |   2 +
include/hw/qdev-properties-system.h |   5 +
include/hw/virtio/virtio-gpu.h      |   3 +
include/ui/console.h                |   3 +
include/ui/gtk.h                    |   2 +
include/ui/spice-display.h          |   5 +
include/ui/surface.h                |   1 +
ui/vnc.h                            |  49 +--
hw/core/qdev-properties-system.c    |  44 +++
hw/display/virtio-gpu-base.c        |  27 ++
system/tpm.c                        |   5 +-
ui/console-gl.c                     |  54 ++++
ui/egl-helpers.c                    |   6 +
ui/gtk.c                            |  58 ++--
ui/spice-core.c                     |  31 ++
ui/spice-display.c                  | 226 +++++++++++++-
ui/vnc-enc-tight.c                  | 456 +++++++++++++++-------------
ui/vnc-enc-zlib.c                   |  47 +--
ui/vnc-enc-zrle.c                   | 122 ++++----
ui/vnc-jobs.c                       |  13 +-
ui/vnc.c                            |  83 +++--
ui/vnc-enc-zrle.c.inc               |  20 +-
qemu-options.hx                     |  13 +
25 files changed, 882 insertions(+), 426 deletions(-)
[PULL 00/13] Ui patches
Posted by marcandre.lureau@redhat.com 4 months ago 
From: Marc-André Lureau <marcandre.lureau@redhat.com>

The following changes since commit 9a4e273ddec3927920c5958d2226c6b38b543336:

  Merge tag 'pull-tcg-20250711' of https://gitlab.com/rth7680/qemu into staging (2025-07-13 01:46:04 -0400)

are available in the Git repository at:

  https://gitlab.com/marcandre.lureau/qemu.git tags/ui-pull-request

for you to fetch changes up to c99b7e6d4aa8bcc12d47483ebe81072168de56fb:

  tpm: "qemu -tpmdev help" should return success (2025-07-14 15:02:00 +0400)

----------------------------------------------------------------
UI-related for 10.1

- [PATCH v3 0/2] ui/vnc: Do not copy z_stream
- [PATCH v6 0/7] ui/spice: Enable gl=on option for non-local or remote clients
- [PATCH v6 0/1] Allow injection of virtio-gpu EDID name
- [PATCH 0/2] ui/gtk: Add keep-aspect-ratio and scale option

----------------------------------------------------------------

Akihiko Odaki (2):
  ui/vnc: Do not copy z_stream
  ui/vnc: Introduce the VncWorker type

Andrew Keesler (1):
  hw/display: Allow injection of virtio-gpu EDID name

Marc-André Lureau (1):
  tpm: "qemu -tpmdev help" should return success

Vivek Kasireddy (7):
  ui/egl-helpers: Error check the fds in egl_dmabuf_export_texture()
  ui/spice: Enable gl=on option for non-local or remote clients
  ui/spice: Add an option for users to provide a preferred video codec
  ui/spice: Add an option to submit gl_draw requests at fixed rate
  ui/console-gl: Add a helper to create a texture with linear memory
    layout
  ui/spice: Create a new texture with linear layout when gl=on is
    specified
  ui/spice: Blit the scanout texture if its memory layout is not linear

Weifeng Liu (2):
  ui/gtk: Add keep-aspect-ratio option
  ui/gtk: Add scale option

 qapi/ui.json                        |  15 +-
 qapi/virtio.json                    |  18 +-
 include/hw/display/edid.h           |   2 +
 include/hw/qdev-properties-system.h |   5 +
 include/hw/virtio/virtio-gpu.h      |   3 +
 include/ui/console.h                |   3 +
 include/ui/gtk.h                    |   2 +
 include/ui/spice-display.h          |   5 +
 include/ui/surface.h                |   1 +
 ui/vnc.h                            |  49 +--
 hw/core/qdev-properties-system.c    |  44 +++
 hw/display/virtio-gpu-base.c        |  27 ++
 system/tpm.c                        |   5 +-
 ui/console-gl.c                     |  54 ++++
 ui/egl-helpers.c                    |   6 +
 ui/gtk.c                            |  58 ++--
 ui/spice-core.c                     |  31 ++
 ui/spice-display.c                  | 226 +++++++++++++-
 ui/vnc-enc-tight.c                  | 456 +++++++++++++++-------------
 ui/vnc-enc-zlib.c                   |  47 +--
 ui/vnc-enc-zrle.c                   | 122 ++++----
 ui/vnc-jobs.c                       |  13 +-
 ui/vnc.c                            |  83 +++--
 ui/vnc-enc-zrle.c.inc               |  20 +-
 qemu-options.hx                     |  13 +
 25 files changed, 882 insertions(+), 426 deletions(-)

-- 
2.50.0
Re: [PULL 00/13] Ui patches
Posted by Marc-André Lureau 4 months ago 
On Mon, Jul 14, 2025 at 3:45 PM <marcandre.lureau@redhat.com> wrote:
>
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> The following changes since commit 9a4e273ddec3927920c5958d2226c6b38b543336:
>
>   Merge tag 'pull-tcg-20250711' of https://gitlab.com/rth7680/qemu into staging (2025-07-13 01:46:04 -0400)
>
> are available in the Git repository at:
>
>   https://gitlab.com/marcandre.lureau/qemu.git tags/ui-pull-request
>
> for you to fetch changes up to c99b7e6d4aa8bcc12d47483ebe81072168de56fb:
>
>   tpm: "qemu -tpmdev help" should return success (2025-07-14 15:02:00 +0400)
>
> ----------------------------------------------------------------
> UI-related for 10.1
>
> - [PATCH v3 0/2] ui/vnc: Do not copy z_stream
> - [PATCH v6 0/7] ui/spice: Enable gl=on option for non-local or remote clients
> - [PATCH v6 0/1] Allow injection of virtio-gpu EDID name
> - [PATCH 0/2] ui/gtk: Add keep-aspect-ratio and scale option
>
> ----------------------------------------------------------------
>
> Akihiko Odaki (2):
>   ui/vnc: Do not copy z_stream
>   ui/vnc: Introduce the VncWorker type
>
> Andrew Keesler (1):
>   hw/display: Allow injection of virtio-gpu EDID name
>
> Marc-André Lureau (1):
>   tpm: "qemu -tpmdev help" should return success
>
> Vivek Kasireddy (7):
>   ui/egl-helpers: Error check the fds in egl_dmabuf_export_texture()
>   ui/spice: Enable gl=on option for non-local or remote clients
>   ui/spice: Add an option for users to provide a preferred video codec
>   ui/spice: Add an option to submit gl_draw requests at fixed rate
>   ui/console-gl: Add a helper to create a texture with linear memory
>     layout
>   ui/spice: Create a new texture with linear layout when gl=on is
>     specified
>   ui/spice: Blit the scanout texture if its memory layout is not linear
>
> Weifeng Liu (2):
>   ui/gtk: Add keep-aspect-ratio option
>   ui/gtk: Add scale option

NACK, will resend because when Spice is not recent enough:
../ui/spice-core.c: In function 'qemu_spice_init':
../ui/spice-core.c:673:17: error: unused variable 'video_codec'
[-Werror=unused-variable]

>
>  qapi/ui.json                        |  15 +-
>  qapi/virtio.json                    |  18 +-
>  include/hw/display/edid.h           |   2 +
>  include/hw/qdev-properties-system.h |   5 +
>  include/hw/virtio/virtio-gpu.h      |   3 +
>  include/ui/console.h                |   3 +
>  include/ui/gtk.h                    |   2 +
>  include/ui/spice-display.h          |   5 +
>  include/ui/surface.h                |   1 +
>  ui/vnc.h                            |  49 +--
>  hw/core/qdev-properties-system.c    |  44 +++
>  hw/display/virtio-gpu-base.c        |  27 ++
>  system/tpm.c                        |   5 +-
>  ui/console-gl.c                     |  54 ++++
>  ui/egl-helpers.c                    |   6 +
>  ui/gtk.c                            |  58 ++--
>  ui/spice-core.c                     |  31 ++
>  ui/spice-display.c                  | 226 +++++++++++++-
>  ui/vnc-enc-tight.c                  | 456 +++++++++++++++-------------
>  ui/vnc-enc-zlib.c                   |  47 +--
>  ui/vnc-enc-zrle.c                   | 122 ++++----
>  ui/vnc-jobs.c                       |  13 +-
>  ui/vnc.c                            |  83 +++--
>  ui/vnc-enc-zrle.c.inc               |  20 +-
>  qemu-options.hx                     |  13 +
>  25 files changed, 882 insertions(+), 426 deletions(-)
>
> --
> 2.50.0
>
>


-- 
Marc-André Lureau
Re: [PULL 00/13] Ui patches
Posted by Stefan Hajnoczi 4 months ago 
On Mon, Jul 14, 2025 at 10:02 AM Marc-André Lureau
<marcandre.lureau@gmail.com> wrote:
>
> On Mon, Jul 14, 2025 at 3:45 PM <marcandre.lureau@redhat.com> wrote:
> >
> > From: Marc-André Lureau <marcandre.lureau@redhat.com>
> >
> > The following changes since commit 9a4e273ddec3927920c5958d2226c6b38b543336:
> >
> >   Merge tag 'pull-tcg-20250711' of https://gitlab.com/rth7680/qemu into staging (2025-07-13 01:46:04 -0400)
> >
> > are available in the Git repository at:
> >
> >   https://gitlab.com/marcandre.lureau/qemu.git tags/ui-pull-request
> >
> > for you to fetch changes up to c99b7e6d4aa8bcc12d47483ebe81072168de56fb:
> >
> >   tpm: "qemu -tpmdev help" should return success (2025-07-14 15:02:00 +0400)
> >
> > ----------------------------------------------------------------
> > UI-related for 10.1
> >
> > - [PATCH v3 0/2] ui/vnc: Do not copy z_stream
> > - [PATCH v6 0/7] ui/spice: Enable gl=on option for non-local or remote clients
> > - [PATCH v6 0/1] Allow injection of virtio-gpu EDID name
> > - [PATCH 0/2] ui/gtk: Add keep-aspect-ratio and scale option
> >
> > ----------------------------------------------------------------
> >
> > Akihiko Odaki (2):
> >   ui/vnc: Do not copy z_stream
> >   ui/vnc: Introduce the VncWorker type
> >
> > Andrew Keesler (1):
> >   hw/display: Allow injection of virtio-gpu EDID name
> >
> > Marc-André Lureau (1):
> >   tpm: "qemu -tpmdev help" should return success
> >
> > Vivek Kasireddy (7):
> >   ui/egl-helpers: Error check the fds in egl_dmabuf_export_texture()
> >   ui/spice: Enable gl=on option for non-local or remote clients
> >   ui/spice: Add an option for users to provide a preferred video codec
> >   ui/spice: Add an option to submit gl_draw requests at fixed rate
> >   ui/console-gl: Add a helper to create a texture with linear memory
> >     layout
> >   ui/spice: Create a new texture with linear layout when gl=on is
> >     specified
> >   ui/spice: Blit the scanout texture if its memory layout is not linear
> >
> > Weifeng Liu (2):
> >   ui/gtk: Add keep-aspect-ratio option
> >   ui/gtk: Add scale option
>
> NACK, will resend because when Spice is not recent enough:
> ../ui/spice-core.c: In function 'qemu_spice_init':
> ../ui/spice-core.c:673:17: error: unused variable 'video_codec'
> [-Werror=unused-variable]

Okay, holding off on this pull request.

Stefan

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.