"confidential-guest-support" is the recommended property instead of
"memory-encryption". Switch to "confidential-guest-support" in the
example of sev-guest.

Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
---
 qemu-options.hx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qemu-options.hx b/qemu-options.hx
index 740323f22bc2..27b7b79c6cad 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -5986,7 +5986,7 @@ SRST
              # |qemu_system_x86| \\
                  ...... \\
                  -object sev-guest,id=sev0,cbitpos=47,reduced-phys-bits=1 \\
-                 -machine ...,memory-encryption=sev0 \\
+                 -machine ...,confidential-guest-support=sev0 \\
                  .....
 
     ``-object authz-simple,id=id,identity=string``
-- 
2.43.0

On Mon, Jul 14, 2025 at 05:19:51PM +0800, Xiaoyao Li wrote:
> "confidential-guest-support" is the recommended property instead of
> "memory-encryption". Switch to "confidential-guest-support" in the
> example of sev-guest.
> 
> Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
> ---
>  qemu-options.hx | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

On Fri, Sep 12, 2025 at 09:17:35AM +0100, Daniel P. Berrangé wrote:
> On Mon, Jul 14, 2025 at 05:19:51PM +0800, Xiaoyao Li wrote:
> > "confidential-guest-support" is the recommended property instead of
> > "memory-encryption". Switch to "confidential-guest-support" in the
> > example of sev-guest.
> > 
> > Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
> > ---
> >  qemu-options.hx | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

Incidentally, how about adding another patch that declares 'memory-encryption'
as deprecated (print a warning to stderr if used, and add note to
docs/about/deprecated.rst).

We've had 'confidential-guest-support' for long enough that no one should
be using 'memory-encryption' anymore, so it is time to start the clock
for its removal.


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

On 9/12/2025 4:23 PM, Daniel P. Berrangé wrote:
> On Fri, Sep 12, 2025 at 09:17:35AM +0100, Daniel P. Berrangé wrote:
>> On Mon, Jul 14, 2025 at 05:19:51PM +0800, Xiaoyao Li wrote:
>>> "confidential-guest-support" is the recommended property instead of
>>> "memory-encryption". Switch to "confidential-guest-support" in the
>>> example of sev-guest.
>>>
>>> Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
>>> ---
>>>   qemu-options.hx | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> 
> Incidentally, how about adding another patch that declares 'memory-encryption'
> as deprecated (print a warning to stderr if used, and add note to
> docs/about/deprecated.rst).
> 
> We've had 'confidential-guest-support' for long enough that no one should
> be using 'memory-encryption' anymore, so it is time to start the clock
> for its removal.

Sure, I will add an additional patch to deprecate "memory-encryption".

And thanks for reviewing the series!

> 
> With regards,
> Daniel