[PATCH 2/5] i386/sev: Remove the example that references memory-encryption

Xiaoyao Li posted 5 patches 5 months ago
Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Zhao Liu <zhao1.liu@intel.com>, Marcelo Tosatti <mtosatti@redhat.com>
[PATCH 2/5] i386/sev: Remove the example that references memory-encryption
Posted by Xiaoyao Li 5 months ago
"confidential-guest-support" is the recommended property to configure
sev for the machine, and amd-memory-encryption.rst has already switched
to use "confidential-guest-support" in the example.

Instead of changing "memory-encryption" to "confidential-guest-support"
in the comment of struct SevGuestState, just drop the example for
simplicity.

Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
---
 target/i386/sev.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/target/i386/sev.c b/target/i386/sev.c
index 1a12f0671cc6..b1831e9ab14e 100644
--- a/target/i386/sev.c
+++ b/target/i386/sev.c
@@ -131,10 +131,6 @@ struct SevCommonStateClass {
  *
  * The SevGuestState object is used for creating and managing a SEV
  * guest.
- *
- * # $QEMU \
- *         -object sev-guest,id=sev0 \
- *         -machine ...,memory-encryption=sev0
  */
 struct SevGuestState {
     SevCommonState parent_obj;
-- 
2.43.0
Re: [PATCH 2/5] i386/sev: Remove the example that references memory-encryption
Posted by Daniel P. Berrangé 3 months ago
On Mon, Jul 14, 2025 at 05:19:50PM +0800, Xiaoyao Li wrote:
> "confidential-guest-support" is the recommended property to configure
> sev for the machine, and amd-memory-encryption.rst has already switched
> to use "confidential-guest-support" in the example.
> 
> Instead of changing "memory-encryption" to "confidential-guest-support"
> in the comment of struct SevGuestState, just drop the example for
> simplicity.
> 
> Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
> ---
>  target/i386/sev.c | 4 ----
>  1 file changed, 4 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|