qga: Fix truncated output handling in guest-exec status reporting

[PATCH] qga: Fix truncated output handling in guest-exec status reporting

Posted by Minglei Liu 5 months ago

From: "minglei.liu" <minglei.liu@smartx.com>

Signed-off-by: minglei.liu <minglei.liu@smartx.com>
---
 qga/commands.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/qga/commands.c b/qga/commands.c
index 5a5fad31f8..5f20af25d3 100644
--- a/qga/commands.c
+++ b/qga/commands.c
@@ -205,13 +205,15 @@ GuestExecStatus *qmp_guest_exec_status(int64_t pid, Error **errp)
 #endif
         if (gei->out.length > 0) {
             ges->out_data = g_base64_encode(gei->out.data, gei->out.length);
-            ges->has_out_truncated = gei->out.truncated;
+            ges->has_out_truncated = true;
+            ges->out_truncated = gei->out.truncated;
         }
         g_free(gei->out.data);
 
         if (gei->err.length > 0) {
             ges->err_data = g_base64_encode(gei->err.data, gei->err.length);
-            ges->has_err_truncated = gei->err.truncated;
+            ges->has_err_truncated = true;
+            ges->err_truncated = gei->err.truncated;
         }
         g_free(gei->err.data);
 
-- 
2.39.5 (Apple Git-154)

Re: [PATCH] qga: Fix truncated output handling in guest-exec status reporting

Posted by Michael Tokarev 3 months, 1 week ago

On 11.07.2025 05:17, Minglei Liu wrote:
> From: "minglei.liu" <minglei.liu@smartx.com>
> 
> Signed-off-by: minglei.liu <minglei.liu@smartx.com>
> ---
>   qga/commands.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/qga/commands.c b/qga/commands.c
> index 5a5fad31f8..5f20af25d3 100644
> --- a/qga/commands.c
> +++ b/qga/commands.c
> @@ -205,13 +205,15 @@ GuestExecStatus *qmp_guest_exec_status(int64_t pid, Error **errp)
>   #endif
>           if (gei->out.length > 0) {
>               ges->out_data = g_base64_encode(gei->out.data, gei->out.length);
> -            ges->has_out_truncated = gei->out.truncated;
> +            ges->has_out_truncated = true;
> +            ges->out_truncated = gei->out.truncated;
>           }
>           g_free(gei->out.data);
>   
>           if (gei->err.length > 0) {
>               ges->err_data = g_base64_encode(gei->err.data, gei->err.length);
> -            ges->has_err_truncated = gei->err.truncated;
> +            ges->has_err_truncated = true;
> +            ges->err_truncated = gei->err.truncated;
>           }
>           g_free(gei->err.data);
>   

I'm picking this up for all current active stable releases as well
(with d6f67b83b81b "qga: Fix memory leak when output stream is unused"
before it for 7.2).

Please let me know if I shouldn't

Thanks,

/mjt

Re: [PATCH] qga: Fix truncated output handling in guest-exec status reporting

Posted by Daniel P. Berrangé 5 months ago

On Fri, Jul 11, 2025 at 10:17:14AM +0800, Minglei Liu wrote:
> From: "minglei.liu" <minglei.liu@smartx.com>
>

Fixes: a1853dca743

Broken since day 1 :-(

> Signed-off-by: minglei.liu <minglei.liu@smartx.com>
> ---
>  qga/commands.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [PATCH] qga: Fix truncated output handling in guest-exec status reporting

Posted by Kostiantyn Kostiuk 3 months, 2 weeks ago

Reviewed-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>

Best Regards,
Kostiantyn Kostiuk.


On Fri, Jul 11, 2025 at 11:53 AM Daniel P. Berrangé <berrange@redhat.com>
wrote:

> On Fri, Jul 11, 2025 at 10:17:14AM +0800, Minglei Liu wrote:
> > From: "minglei.liu" <minglei.liu@smartx.com>
> >
>
> Fixes: a1853dca743
>
> Broken since day 1 :-(
>
> > Signed-off-by: minglei.liu <minglei.liu@smartx.com>
> > ---
> >  qga/commands.c | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
>
>
> With regards,
> Daniel
> --
> |: https://berrange.com      -o-
> https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org         -o-
> https://fstop138.berrange.com :|
> |: https://entangle-photo.org    -o-
> https://www.instagram.com/dberrange :|
>
>