[v6] ACPI PCI Hotplug support on ARM

[PATCH v6 18/36] qtest/bios-tables-test: Add a variant to the aarch64 viot test

Posted by Eric Auger 4 months, 1 week ago

Signed-off-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
---
 tests/qtest/bios-tables-test.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index 4dbc07ec5e..357bcefd37 100644
--- a/tests/qtest/bios-tables-test.c
+++ b/tests/qtest/bios-tables-test.c
@@ -2237,6 +2237,7 @@ static void test_acpi_aarch64_virt_viot(void)
     test_data data = {
         .machine = "virt",
         .arch = "aarch64",
+        .variant = ".viot",
         .tcg_only = true,
         .uefi_fl1 = "pc-bios/edk2-aarch64-code.fd",
         .uefi_fl2 = "pc-bios/edk2-arm-vars.fd",
-- 
2.49.0

Re: [PATCH v6 18/36] qtest/bios-tables-test: Add a variant to the aarch64 viot test

Posted by Igor Mammedov 4 months, 1 week ago

On Tue,  8 Jul 2025 16:23:00 +0200
Eric Auger <eric.auger@redhat.com> wrote:

> Signed-off-by: Eric Auger <eric.auger@redhat.com>
> Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>

I'd merge this with previous patch


> ---
>  tests/qtest/bios-tables-test.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> index 4dbc07ec5e..357bcefd37 100644
> --- a/tests/qtest/bios-tables-test.c
> +++ b/tests/qtest/bios-tables-test.c
> @@ -2237,6 +2237,7 @@ static void test_acpi_aarch64_virt_viot(void)
>      test_data data = {
>          .machine = "virt",
>          .arch = "aarch64",
> +        .variant = ".viot",
>          .tcg_only = true,
>          .uefi_fl1 = "pc-bios/edk2-aarch64-code.fd",
>          .uefi_fl2 = "pc-bios/edk2-arm-vars.fd",

Re: [PATCH v6 18/36] qtest/bios-tables-test: Add a variant to the aarch64 viot test

Posted by Eric Auger 4 months ago

Hi Igor,

On 7/11/25 2:00 PM, Igor Mammedov wrote:
> On Tue,  8 Jul 2025 16:23:00 +0200
> Eric Auger <eric.auger@redhat.com> wrote:
>
>> Signed-off-by: Eric Auger <eric.auger@redhat.com>
>> Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
> I'd merge this with previous patch
checkpatch complains if I do that:

ERROR: Do not add expected files together with tests, follow
instructions in tests/qtest/bios-tables-test.c. Files

  tests/data/acpi/aarch64/virt/DSDT.viot

and

  tests/qtest/bios-tables-test.c

found in the same patch.

Thanks

Eric


>
>
>> ---
>>  tests/qtest/bios-tables-test.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
>> index 4dbc07ec5e..357bcefd37 100644
>> --- a/tests/qtest/bios-tables-test.c
>> +++ b/tests/qtest/bios-tables-test.c
>> @@ -2237,6 +2237,7 @@ static void test_acpi_aarch64_virt_viot(void)
>>      test_data data = {
>>          .machine = "virt",
>>          .arch = "aarch64",
>> +        .variant = ".viot",
>>          .tcg_only = true,
>>          .uefi_fl1 = "pc-bios/edk2-aarch64-code.fd",
>>          .uefi_fl2 = "pc-bios/edk2-arm-vars.fd",