Since commit da944885469 ("target/s390x: make helper.c
sysemu-only") target/s390x/helper.c is only built for
system mode, so s390_cpu_halt() and s390_cpu_unhalt()
are never called from user mode.

Fixes: da944885469 ("target/s390x: make helper.c sysemu-only")
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 target/s390x/s390x-internal.h | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/target/s390x/s390x-internal.h b/target/s390x/s390x-internal.h
index a4ba6227ab4..6894f0a2569 100644
--- a/target/s390x/s390x-internal.h
+++ b/target/s390x/s390x-internal.h
@@ -246,16 +246,6 @@ void s390_cpu_finalize(Object *obj);
 void s390_cpu_system_class_init(CPUClass *cc);
 void s390_cpu_machine_reset_cb(void *opaque);
 bool s390_cpu_has_work(CPUState *cs);
-
-#else
-static inline unsigned int s390_cpu_halt(S390CPU *cpu)
-{
-    return 0;
-}
-
-static inline void s390_cpu_unhalt(S390CPU *cpu)
-{
-}
 #endif /* CONFIG_USER_ONLY */
 
 
-- 
2.49.0

On 08/07/2025 11.57, Philippe Mathieu-Daudé wrote:
> Since commit da944885469 ("target/s390x: make helper.c
> sysemu-only") target/s390x/helper.c is only built for
> system mode, so s390_cpu_halt() and s390_cpu_unhalt()
> are never called from user mode.
> 
> Fixes: da944885469 ("target/s390x: make helper.c sysemu-only")
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   target/s390x/s390x-internal.h | 10 ----------
>   1 file changed, 10 deletions(-)

There is another call to s390_cpu_unhalt() in target/s390x/tcg/excp_helper.c 
but it is protected by an #ifdef ... so this should be fine.

Reviewed-by: Thomas Huth <thuth@redhat.com>