[PATCH 1/2] target/s390x/kvm: Use vaddr in find/insert_hw_breakpoint()

Philippe Mathieu-Daudé posted 2 patches 5 months, 1 week ago
Maintainers: Halil Pasic <pasic@linux.ibm.com>, Christian Borntraeger <borntraeger@linux.ibm.com>, Eric Farman <farman@linux.ibm.com>, Matthew Rosato <mjrosato@linux.ibm.com>, Richard Henderson <richard.henderson@linaro.org>, David Hildenbrand <david@redhat.com>, Ilya Leoshkevich <iii@linux.ibm.com>, Thomas Huth <thuth@redhat.com>
[PATCH 1/2] target/s390x/kvm: Use vaddr in find/insert_hw_breakpoint()
Posted by Philippe Mathieu-Daudé 5 months, 1 week ago
Since commit b8a6eb1862a both kvm_arch_insert_hw_breakpoint()
and kvm_arch_remove_hw_breakpoint() use a vaddr type. Use the
same type for the callees.

Fixes: b8a6eb1862a ("sysemu/kvm: Use vaddr for kvm_arch_[insert|remove]_hw_breakpoint")
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 target/s390x/kvm/kvm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/target/s390x/kvm/kvm.c b/target/s390x/kvm/kvm.c
index 67d9a1977c0..491cc5f9756 100644
--- a/target/s390x/kvm/kvm.c
+++ b/target/s390x/kvm/kvm.c
@@ -889,7 +889,7 @@ int kvm_arch_remove_sw_breakpoint(CPUState *cs, struct kvm_sw_breakpoint *bp)
     return 0;
 }
 
-static struct kvm_hw_breakpoint *find_hw_breakpoint(target_ulong addr,
+static struct kvm_hw_breakpoint *find_hw_breakpoint(vaddr addr,
                                                     int len, int type)
 {
     int n;
@@ -904,7 +904,7 @@ static struct kvm_hw_breakpoint *find_hw_breakpoint(target_ulong addr,
     return NULL;
 }
 
-static int insert_hw_breakpoint(target_ulong addr, int len, int type)
+static int insert_hw_breakpoint(vaddr addr, int len, int type)
 {
     int size;
 
-- 
2.49.0


Re: [PATCH 1/2] target/s390x/kvm: Use vaddr in find/insert_hw_breakpoint()
Posted by Richard Henderson 5 months, 1 week ago
On 7/7/25 11:10, Philippe Mathieu-Daudé wrote:
> Since commit b8a6eb1862a both kvm_arch_insert_hw_breakpoint()
> and kvm_arch_remove_hw_breakpoint() use a vaddr type. Use the
> same type for the callees.
> 
> Fixes: b8a6eb1862a ("sysemu/kvm: Use vaddr for kvm_arch_[insert|remove]_hw_breakpoint")
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   target/s390x/kvm/kvm.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/target/s390x/kvm/kvm.c b/target/s390x/kvm/kvm.c
> index 67d9a1977c0..491cc5f9756 100644
> --- a/target/s390x/kvm/kvm.c
> +++ b/target/s390x/kvm/kvm.c
> @@ -889,7 +889,7 @@ int kvm_arch_remove_sw_breakpoint(CPUState *cs, struct kvm_sw_breakpoint *bp)
>       return 0;
>   }
>   
> -static struct kvm_hw_breakpoint *find_hw_breakpoint(target_ulong addr,
> +static struct kvm_hw_breakpoint *find_hw_breakpoint(vaddr addr,
>                                                       int len, int type)
>   {
>       int n;
> @@ -904,7 +904,7 @@ static struct kvm_hw_breakpoint *find_hw_breakpoint(target_ulong addr,
>       return NULL;
>   }
>   
> -static int insert_hw_breakpoint(target_ulong addr, int len, int type)
> +static int insert_hw_breakpoint(vaddr addr, int len, int type)
>   {
>       int size;
>   

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~