[PATCH] hw/arm/highbank: Mark the "highbank" and the "midway" machine as deprecated

Thomas Huth posted 1 patch 4 months, 2 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20250702113051.46483-1-thuth@redhat.com
Maintainers: Rob Herring <robh@kernel.org>, Peter Maydell <peter.maydell@linaro.org>
docs/about/deprecated.rst | 7 +++++++
hw/arm/highbank.c         | 2 ++
2 files changed, 9 insertions(+)
[PATCH] hw/arm/highbank: Mark the "highbank" and the "midway" machine as deprecated
Posted by Thomas Huth 4 months, 2 weeks ago
From: Thomas Huth <thuth@redhat.com>

We don't have any automatic regression tests for these machines and
when asking the usual suspects on the mailing list we came to the
conclusion that nobody tests these machines manually, too, so it seems
like this is currently just completely unused code. Mark them as depre-
cated to see whether anybody still speaks up during the deprecation
period, otherwise we can likely remove these two machines in a couple
of releases.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 Here's the preceeding discussion on the mailing list:
 https://lore.kernel.org/qemu-devel/CAFEAcA_0Hu8+G50sy0FJ2rX-=cNymLddDdrS2nN5ZY-doKiT8w@mail.gmail.com/

 docs/about/deprecated.rst | 7 +++++++
 hw/arm/highbank.c         | 2 ++
 2 files changed, 9 insertions(+)

diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
index 42037131de1..3fb9d8e1ebd 100644
--- a/docs/about/deprecated.rst
+++ b/docs/about/deprecated.rst
@@ -344,6 +344,13 @@ they want to use and avoids confusion.  Existing users of the ``spike``
 machine must ensure that they're setting the ``spike`` machine in the
 command line (``-M spike``).
 
+Arm ``highbank`` and ``midway`` machines (since 10.1)
+'''''''''''''''''''''''''''''''''''''''''''''''''''''
+
+There are no known users left for these machines (if you still use it,
+please write a mail to the qemu-devel mailing list). If you just want to
+boot an A15 or A9 Linux, use the ``virt`` machine instead.
+
 
 System emulator binaries
 ------------------------
diff --git a/hw/arm/highbank.c b/hw/arm/highbank.c
index 3ae26ebebdc..165c0b741a5 100644
--- a/hw/arm/highbank.c
+++ b/hw/arm/highbank.c
@@ -357,6 +357,7 @@ static void highbank_class_init(ObjectClass *oc, const void *data)
     mc->max_cpus = 4;
     mc->ignore_memory_transaction_failures = true;
     mc->default_ram_id = "highbank.dram";
+    mc->deprecation_reason = "no known users left for this machine";
 }
 
 static const TypeInfo highbank_type = {
@@ -381,6 +382,7 @@ static void midway_class_init(ObjectClass *oc, const void *data)
     mc->max_cpus = 4;
     mc->ignore_memory_transaction_failures = true;
     mc->default_ram_id = "highbank.dram";
+    mc->deprecation_reason = "no known users left for this machine";
 }
 
 static const TypeInfo midway_type = {
-- 
2.50.0
Re: [PATCH] hw/arm/highbank: Mark the "highbank" and the "midway" machine as deprecated
Posted by Peter Maydell 4 months, 1 week ago
On Wed, 2 Jul 2025 at 12:30, Thomas Huth <thuth@redhat.com> wrote:
>
> From: Thomas Huth <thuth@redhat.com>
>
> We don't have any automatic regression tests for these machines and
> when asking the usual suspects on the mailing list we came to the
> conclusion that nobody tests these machines manually, too, so it seems
> like this is currently just completely unused code. Mark them as depre-
> cated to see whether anybody still speaks up during the deprecation
> period, otherwise we can likely remove these two machines in a couple
> of releases.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  Here's the preceeding discussion on the mailing list:
>  https://lore.kernel.org/qemu-devel/CAFEAcA_0Hu8+G50sy0FJ2rX-=cNymLddDdrS2nN5ZY-doKiT8w@mail.gmail.com/
>



Applied to target-arm.next, thanks.

-- PMM
Re: [PATCH] hw/arm/highbank: Mark the "highbank" and the "midway" machine as deprecated
Posted by Guenter Roeck 4 months, 2 weeks ago
On Wed, Jul 02, 2025 at 01:30:51PM +0200, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
> 
> We don't have any automatic regression tests for these machines and
> when asking the usual suspects on the mailing list we came to the
> conclusion that nobody tests these machines manually, too, so it seems
> like this is currently just completely unused code. Mark them as depre-
> cated to see whether anybody still speaks up during the deprecation
> period, otherwise we can likely remove these two machines in a couple
> of releases.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Acked-by: Guenter Roeck <linux@roeck-us.net>
Re: [PATCH] hw/arm/highbank: Mark the "highbank" and the "midway" machine as deprecated
Posted by Rob Herring 4 months, 2 weeks ago
On Wed, Jul 2, 2025 at 6:31 AM Thomas Huth <thuth@redhat.com> wrote:
>
> From: Thomas Huth <thuth@redhat.com>
>
> We don't have any automatic regression tests for these machines and
> when asking the usual suspects on the mailing list we came to the
> conclusion that nobody tests these machines manually, too, so it seems
> like this is currently just completely unused code. Mark them as depre-
> cated to see whether anybody still speaks up during the deprecation
> period, otherwise we can likely remove these two machines in a couple
> of releases.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  Here's the preceeding discussion on the mailing list:
>  https://lore.kernel.org/qemu-devel/CAFEAcA_0Hu8+G50sy0FJ2rX-=cNymLddDdrS2nN5ZY-doKiT8w@mail.gmail.com/
>
>  docs/about/deprecated.rst | 7 +++++++
>  hw/arm/highbank.c         | 2 ++
>  2 files changed, 9 insertions(+)

Acked-by: Rob Herring <robh@kernel.org>

Rob