[PATCH v3 00/68] accel: Preparatory cleanups for split-accel

Philippe Mathieu-Daudé posted 68 patches 4 months, 2 weeks ago
Failed in applying to current master (apply log)
Maintainers: Richard Henderson <richard.henderson@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, Cameron Esfahani <dirty@apple.com>, Roman Bolshakov <rbolshakov@ddn.com>, Phil Dennis-Jordan <phil@philjordan.eu>, Fabiano Rosas <farosas@suse.de>, Laurent Vivier <lvivier@redhat.com>, Stefano Stabellini <sstabellini@kernel.org>, Anthony PERARD <anthony@xenproject.org>, Paul Durrant <paul@xen.org>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Warner Losh <imp@bsdimp.com>, Kyle Evans <kevans@freebsd.org>, "Alex Bennée" <alex.bennee@linaro.org>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, "Dr. David Alan Gilbert" <dave@treblig.org>, Eduardo Habkost <eduardo@habkost.net>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Yanan Wang <wangyanan55@huawei.com>, Zhao Liu <zhao1.liu@intel.com>, Reinoud Zandijk <reinoud@netbsd.org>, Sunil Muthuswamy <sunilmut@microsoft.com>, Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>, Peter Xu <peterx@redhat.com>, David Hildenbrand <david@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Alexander Graf <agraf@csgraf.de>
There is a newer version of this series
qapi/machine.json                 |   3 +
accel/accel-internal.h            |   2 +
accel/dummy-cpus.h                |  16 ++
accel/tcg/internal-common.h       |   2 +
accel/tcg/tcg-accel-ops-icount.h  |   6 +-
accel/tcg/tcg-accel-ops-mttcg.h   |   4 +-
accel/tcg/tcg-accel-ops-rr.h      |   4 +
accel/tcg/tcg-accel-ops.h         |   5 +-
include/hw/core/cpu.h             |   5 +-
include/qemu/accel.h              |  21 +-
include/system/accel-ops.h        |  38 +++-
include/system/cpus.h             |   5 -
include/system/hvf.h              |  38 ----
include/system/hvf_int.h          |  37 +++-
include/system/hw_accel.h         |  34 ++-
include/system/kvm.h              |   8 -
include/system/nvmm.h             |  23 +-
include/system/runstate.h         |  10 +
include/system/whpx.h             |  27 +--
target/i386/whpx/whpx-accel-ops.h |   1 -
accel/accel-common.c              |  55 ++++-
accel/accel-system.c              |  54 ++++-
accel/dummy-cpus.c                |  18 +-
accel/hvf/hvf-accel-ops.c         | 342 ++++++------------------------
accel/hvf/hvf-all.c               | 276 ++++++++++++++++++++++--
accel/kvm/kvm-accel-ops.c         |  20 +-
accel/kvm/kvm-all.c               |  33 +--
accel/qtest/qtest.c               |   7 +-
accel/stubs/kvm-stub.c            |   9 -
accel/stubs/nvmm-stub.c           |  12 ++
accel/stubs/whpx-stub.c           |  12 ++
accel/tcg/monitor.c               |  27 ++-
accel/tcg/tcg-accel-ops-icount.c  |  16 +-
accel/tcg/tcg-accel-ops-mttcg.c   |  58 +++--
accel/tcg/tcg-accel-ops-rr.c      |  79 +++++--
accel/tcg/tcg-accel-ops.c         |  44 ++--
accel/tcg/tcg-all.c               |  20 +-
accel/xen/xen-all.c               |   8 +-
bsd-user/main.c                   |   2 +-
gdbstub/system.c                  |   7 +-
hw/core/machine-hmp-cmds.c        |   3 +-
hw/core/machine-qmp-cmds.c        |   1 +
linux-user/main.c                 |   2 +-
system/cpus.c                     |  39 +---
system/memory.c                   |  11 +-
system/physmem.c                  |   8 +
target/arm/arm-qmp-cmds.c         |   5 +-
target/arm/cpu.c                  |   5 +-
target/arm/hvf/hvf.c              |  11 +-
target/i386/hvf/hvf.c             |  11 +-
target/i386/hvf/x86hvf.c          |   2 +-
target/i386/nvmm/nvmm-accel-ops.c |  14 +-
target/i386/nvmm/nvmm-all.c       |  29 +--
target/i386/whpx/whpx-accel-ops.c |  15 +-
target/i386/whpx/whpx-all.c       |  33 ++-
accel/stubs/meson.build           |   2 +
hmp-commands-info.hx              |  12 ++
57 files changed, 947 insertions(+), 644 deletions(-)
create mode 100644 accel/dummy-cpus.h
create mode 100644 accel/stubs/nvmm-stub.c
create mode 100644 accel/stubs/whpx-stub.c
[PATCH v3 00/68] accel: Preparatory cleanups for split-accel
Posted by Philippe Mathieu-Daudé 4 months, 2 weeks ago
Since v2:
- Addressed Richard's review comments

Few changes needed before being able to add the
split acceleration:

- few method docstring added
- remove pointless stubs
- propagate soon required AccelState argument
- try to reduce current_accel() uses
- move declarations AccelClass <-> AccelOpsClass
- display model name in 'info cpus'
- add 'info accel' command to monitor
- rename CPUState @dirty -> @hwaccel_synchronized
- make accel_create_vcpu_thread() more generic
- introduce hwaccel_enabled()
- expose init/exec/destroy vcpu hooks in AccelOpsClass for re-use
- add SysemuCPUOps::can_accelerate() hook

Regards,

Phil.

Philippe Mathieu-Daudé (68):
  system/runstate: Document qemu_add_vm_change_state_handler()
  system/cpus: Defer memory layout changes until vCPUs are realized
  system/cpus: Assert interrupt handling is done with BQL locked
  accel: Keep reference to AccelOpsClass in AccelClass
  accel: Introduce AccelOpsClass::cpu_target_realize() hook
  accel/hvf: Add hvf_arch_cpu_realize() stubs
  accel/kvm: Remove kvm_init_cpu_signals() stub
  accel/kvm: Reduce kvm_create_vcpu() declaration scope
  accel: Propagate AccelState to AccelClass::init_machine()
  accel/kvm: Prefer local AccelState over global MachineState::accel
  accel/hvf: Re-use QOM allocated state
  accel/tcg: Prefer local AccelState over global current_accel()
  accel: Directly pass AccelState argument to AccelClass::has_memory()
  accel/kvm: Directly pass KVMState argument to do_kvm_create_vm()
  accel: Remove unused MachineState argument of AccelClass::setup_post()
  accel: Pass AccelState argument to gdbstub_supported_sstep_flags()
  accel: Move supports_guest_debug() declaration to AccelClass
  accel: Move cpus_are_resettable() declaration to AccelClass
  accel: Move cpu_common_[un]realize() declarations to AccelOpsClass
  accel/system: Introduce AccelClass::pre_resume_vm() handler
  accel/whpx: Convert ops::synchronize_pre_resume() -> pre_resume_vm()
  accel/system: Remove AccelOpsClass::synchronize_pre_resume()
  hw/core/machine: Display CPU model name in 'info cpus' command
  accel/system: Add 'info accel' on human monitor
  accel/tcg: Factor tcg_dump_flush_info() out
  accel/tcg: Implement get_[vcpu]_stats()
  accel/hvf: Implement get_vcpu_stats()
  accel/hvf: Report missing com.apple.security.hypervisor entitlement
  accel/hvf: Restrict internal declarations
  accel/hvf: Move per-cpu method declarations to hvf-accel-ops.c
  accel/hvf: Move generic method declarations to hvf-all.c
  cpus: Document CPUState::vcpu_dirty field
  accel/hvf: Replace @dirty field by generic CPUState::vcpu_dirty field
  accel/nvmm: Replace @dirty field by generic CPUState::vcpu_dirty field
  accel/whpx: Replace @dirty field by generic CPUState::vcpu_dirty field
  accel/kvm: Remove kvm_cpu_synchronize_state() stub
  accel/system: Document cpu_synchronize_state()
  accel/system: Document cpu_synchronize_state_post_init/reset()
  accel/nvmm: Expose nvmm_enabled() to common code
  accel/whpx: Expose whpx_enabled() to common code
  accel/system: Introduce hwaccel_enabled() helper
  target/arm: Use generic hwaccel_enabled() to check 'host' cpu type
  accel/dummy: Extract 'dummy-cpus.h' header from 'system/cpus.h'
  accel/dummy: Factor dummy_thread_precreate() out
  accel/tcg: Factor tcg_vcpu_thread_precreate() out
  accel: Factor accel_create_vcpu_thread() out
  accel: Introduce AccelOpsClass::cpu_thread_routine handler
  accel/dummy: Convert to AccelOpsClass::cpu_thread_routine
  accel/tcg: Convert to AccelOpsClass::cpu_thread_routine
  accel/hvf: Convert to AccelOpsClass::cpu_thread_routine
  accel/kvm: Convert to AccelOpsClass::cpu_thread_routine
  accel/nvmm: Convert to AccelOpsClass::cpu_thread_routine
  accel/whpx: Convert to AccelOpsClass::cpu_thread_routine
  accel: Factor accel_cpu_realize() out
  accel/tcg: Factor tcg_vcpu_init() out for re-use
  accel/tcg: Unregister the RCU before exiting RR thread
  accel/tcg: Expose vcpu_[un]register() for MTTCG
  accel/tcg: Factor mttcg_cpu_exec() out for re-use
  accel/tcg: Expose vcpu_[un]register() for RR
  accel/tcg: Factor rr_cpu_exec() out for re-use
  accel/tcg: Clear exit_request once in tcg_cpu_exec()
  accel/tcg: Add rr_vcpu_destroy() stub
  accel/system: Declare init/exec/destroy vcpu hooks
  accel/tcg: Register init/exec/destroy vcpu hooks
  accel/hvf: Register init/exec/destroy vcpu hooks
  accel/system: Pass old/new interrupt mask to handle_interrupt()
    handler
  accel: Have each accelerator implement the handle_interrupt() hook
  RFC system/memory: Restrict eventfd dispatch_write() to emulators

 qapi/machine.json                 |   3 +
 accel/accel-internal.h            |   2 +
 accel/dummy-cpus.h                |  16 ++
 accel/tcg/internal-common.h       |   2 +
 accel/tcg/tcg-accel-ops-icount.h  |   6 +-
 accel/tcg/tcg-accel-ops-mttcg.h   |   4 +-
 accel/tcg/tcg-accel-ops-rr.h      |   4 +
 accel/tcg/tcg-accel-ops.h         |   5 +-
 include/hw/core/cpu.h             |   5 +-
 include/qemu/accel.h              |  21 +-
 include/system/accel-ops.h        |  38 +++-
 include/system/cpus.h             |   5 -
 include/system/hvf.h              |  38 ----
 include/system/hvf_int.h          |  37 +++-
 include/system/hw_accel.h         |  34 ++-
 include/system/kvm.h              |   8 -
 include/system/nvmm.h             |  23 +-
 include/system/runstate.h         |  10 +
 include/system/whpx.h             |  27 +--
 target/i386/whpx/whpx-accel-ops.h |   1 -
 accel/accel-common.c              |  55 ++++-
 accel/accel-system.c              |  54 ++++-
 accel/dummy-cpus.c                |  18 +-
 accel/hvf/hvf-accel-ops.c         | 342 ++++++------------------------
 accel/hvf/hvf-all.c               | 276 ++++++++++++++++++++++--
 accel/kvm/kvm-accel-ops.c         |  20 +-
 accel/kvm/kvm-all.c               |  33 +--
 accel/qtest/qtest.c               |   7 +-
 accel/stubs/kvm-stub.c            |   9 -
 accel/stubs/nvmm-stub.c           |  12 ++
 accel/stubs/whpx-stub.c           |  12 ++
 accel/tcg/monitor.c               |  27 ++-
 accel/tcg/tcg-accel-ops-icount.c  |  16 +-
 accel/tcg/tcg-accel-ops-mttcg.c   |  58 +++--
 accel/tcg/tcg-accel-ops-rr.c      |  79 +++++--
 accel/tcg/tcg-accel-ops.c         |  44 ++--
 accel/tcg/tcg-all.c               |  20 +-
 accel/xen/xen-all.c               |   8 +-
 bsd-user/main.c                   |   2 +-
 gdbstub/system.c                  |   7 +-
 hw/core/machine-hmp-cmds.c        |   3 +-
 hw/core/machine-qmp-cmds.c        |   1 +
 linux-user/main.c                 |   2 +-
 system/cpus.c                     |  39 +---
 system/memory.c                   |  11 +-
 system/physmem.c                  |   8 +
 target/arm/arm-qmp-cmds.c         |   5 +-
 target/arm/cpu.c                  |   5 +-
 target/arm/hvf/hvf.c              |  11 +-
 target/i386/hvf/hvf.c             |  11 +-
 target/i386/hvf/x86hvf.c          |   2 +-
 target/i386/nvmm/nvmm-accel-ops.c |  14 +-
 target/i386/nvmm/nvmm-all.c       |  29 +--
 target/i386/whpx/whpx-accel-ops.c |  15 +-
 target/i386/whpx/whpx-all.c       |  33 ++-
 accel/stubs/meson.build           |   2 +
 hmp-commands-info.hx              |  12 ++
 57 files changed, 947 insertions(+), 644 deletions(-)
 create mode 100644 accel/dummy-cpus.h
 create mode 100644 accel/stubs/nvmm-stub.c
 create mode 100644 accel/stubs/whpx-stub.c

-- 
2.49.0