Only allow disabling NEON when using TCG.
This avoids confusing user experience:
$ qemu-system-aarch64 -M virt -accel hvf \
-cpu host,neon=off,vfp=off,vfp-d32=off
qemu-system-aarch64: AArch64 CPUs must have both VFP and Neon or neither
$ qemu-system-aarch64 -M virt -accel hvf \
-cpu host,neon=off,vfp=off,vfp-d32=off
qemu-system-aarch64: ARM CPUs must have both VFP-D32 and Neon or neither
$ qemu-system-aarch64 -M virt -accel hvf \
-cpu host,neon=off,vfp=off,vfp-d32=off
qemu-system-aarch64: can't apply global host-arm-cpu.vfp-d32=off: Property 'host-arm-cpu.vfp-d32' not found
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
target/arm/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/arm/cpu.c b/target/arm/cpu.c
index ab5fbd9b40b..b6a8ba83a46 100644
--- a/target/arm/cpu.c
+++ b/target/arm/cpu.c
@@ -1810,7 +1810,7 @@ static void arm_cpu_post_init(Object *obj)
if (arm_feature(&cpu->env, ARM_FEATURE_NEON)) {
cpu->has_neon = true;
- if (!kvm_enabled()) {
+ if (tcg_enabled() || qtest_enabled()) {
qdev_property_add_static(DEVICE(obj), &arm_cpu_has_neon_property);
}
}
--
2.49.0
On Mon, 30 Jun 2025 at 14:09, Philippe Mathieu-Daudé <philmd@linaro.org> wrote: > > Only allow disabling NEON when using TCG. > > This avoids confusing user experience: > > $ qemu-system-aarch64 -M virt -accel hvf \ > -cpu host,neon=off,vfp=off,vfp-d32=off > qemu-system-aarch64: AArch64 CPUs must have both VFP and Neon or neither > > $ qemu-system-aarch64 -M virt -accel hvf \ > -cpu host,neon=off,vfp=off,vfp-d32=off > qemu-system-aarch64: ARM CPUs must have both VFP-D32 and Neon or neither > > $ qemu-system-aarch64 -M virt -accel hvf \ > -cpu host,neon=off,vfp=off,vfp-d32=off > qemu-system-aarch64: can't apply global host-arm-cpu.vfp-d32=off: Property 'host-arm-cpu.vfp-d32' not found I don't know about users, but I'm definitely confused. Aren't these three all the same command line ? What's the problem it's trying to show ? -- PMM
On 4/7/25 15:03, Peter Maydell wrote: > On Mon, 30 Jun 2025 at 14:09, Philippe Mathieu-Daudé <philmd@linaro.org> wrote: >> >> Only allow disabling NEON when using TCG. >> >> This avoids confusing user experience: >> >> $ qemu-system-aarch64 -M virt -accel hvf \ >> -cpu host,neon=off,vfp=off,vfp-d32=off >> qemu-system-aarch64: AArch64 CPUs must have both VFP and Neon or neither >> >> $ qemu-system-aarch64 -M virt -accel hvf \ >> -cpu host,neon=off,vfp=off,vfp-d32=off >> qemu-system-aarch64: ARM CPUs must have both VFP-D32 and Neon or neither >> >> $ qemu-system-aarch64 -M virt -accel hvf \ >> -cpu host,neon=off,vfp=off,vfp-d32=off >> qemu-system-aarch64: can't apply global host-arm-cpu.vfp-d32=off: Property 'host-arm-cpu.vfp-d32' not found > > I don't know about users, but I'm definitely confused. > Aren't these three all the same command line ? What's > the problem it's trying to show ? I should have only shared this confusing example: $ qemu-system-aarch64 -M virt -accel hvf -cpu host,vfp-d32=off qemu-system-aarch64: can't apply global host-arm-cpu.vfp-d32=off: Property 'host-arm-cpu.vfp-d32' not found
On Fri, 4 Jul 2025 at 14:17, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> On 4/7/25 15:03, Peter Maydell wrote:
> > On Mon, 30 Jun 2025 at 14:09, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
> >>
> >> Only allow disabling NEON when using TCG.
> >>
> >> This avoids confusing user experience:
> >>
> >> $ qemu-system-aarch64 -M virt -accel hvf \
> >> -cpu host,neon=off,vfp=off,vfp-d32=off
> >> qemu-system-aarch64: AArch64 CPUs must have both VFP and Neon or neither
> >>
> >> $ qemu-system-aarch64 -M virt -accel hvf \
> >> -cpu host,neon=off,vfp=off,vfp-d32=off
> >> qemu-system-aarch64: ARM CPUs must have both VFP-D32 and Neon or neither
> >>
> >> $ qemu-system-aarch64 -M virt -accel hvf \
> >> -cpu host,neon=off,vfp=off,vfp-d32=off
> >> qemu-system-aarch64: can't apply global host-arm-cpu.vfp-d32=off: Property 'host-arm-cpu.vfp-d32' not found
> >
> > I don't know about users, but I'm definitely confused.
> > Aren't these three all the same command line ? What's
> > the problem it's trying to show ?
>
> I should have only shared this confusing example:
>
> $ qemu-system-aarch64 -M virt -accel hvf -cpu host,vfp-d32=off
> qemu-system-aarch64: can't apply global host-arm-cpu.vfp-d32=off:
> Property 'host-arm-cpu.vfp-d32' not found
That seems correct, though ? We say
* Allow user to turn off VFP and Neon support, but only for TCG --
* KVM does not currently allow us to lie to the guest about its
* ID/feature registers, so the guest always sees what the host has.
and hvf is currently the same. The bug the patch is fixing
looks like it is that -accel hvf lets us say '-cpu host,neon=off'
but it won't actually do what the user might be intending. So
we should avoid creating the property, as we already do for KVM.
(The other odd thing here is that hvf CPUs don't support
AArch32, but ARM_FEATURE_NEON is about AArch32. But that's
a separate thing and we'd need to cross-check that nothing
aarch64 is incorrectly looking at that feature flag before
we suppressed it for CPUs without any AArch32 support.)
-- PMM
On 6/30/25 6:09 AM, Philippe Mathieu-Daudé wrote: > Only allow disabling NEON when using TCG. > > This avoids confusing user experience: > > $ qemu-system-aarch64 -M virt -accel hvf \ > -cpu host,neon=off,vfp=off,vfp-d32=off > qemu-system-aarch64: AArch64 CPUs must have both VFP and Neon or neither > > $ qemu-system-aarch64 -M virt -accel hvf \ > -cpu host,neon=off,vfp=off,vfp-d32=off > qemu-system-aarch64: ARM CPUs must have both VFP-D32 and Neon or neither > > $ qemu-system-aarch64 -M virt -accel hvf \ > -cpu host,neon=off,vfp=off,vfp-d32=off > qemu-system-aarch64: can't apply global host-arm-cpu.vfp-d32=off: Property 'host-arm-cpu.vfp-d32' not found > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> > --- > target/arm/cpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
On 6/30/25 07:09, Philippe Mathieu-Daudé wrote:
> Only allow disabling NEON when using TCG.
>
> This avoids confusing user experience:
>
> $ qemu-system-aarch64 -M virt -accel hvf \
> -cpu host,neon=off,vfp=off,vfp-d32=off
> qemu-system-aarch64: AArch64 CPUs must have both VFP and Neon or neither
>
> $ qemu-system-aarch64 -M virt -accel hvf \
> -cpu host,neon=off,vfp=off,vfp-d32=off
> qemu-system-aarch64: ARM CPUs must have both VFP-D32 and Neon or neither
>
> $ qemu-system-aarch64 -M virt -accel hvf \
> -cpu host,neon=off,vfp=off,vfp-d32=off
> qemu-system-aarch64: can't apply global host-arm-cpu.vfp-d32=off: Property 'host-arm-cpu.vfp-d32' not found
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> target/arm/cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/arm/cpu.c b/target/arm/cpu.c
> index ab5fbd9b40b..b6a8ba83a46 100644
> --- a/target/arm/cpu.c
> +++ b/target/arm/cpu.c
> @@ -1810,7 +1810,7 @@ static void arm_cpu_post_init(Object *obj)
>
> if (arm_feature(&cpu->env, ARM_FEATURE_NEON)) {
> cpu->has_neon = true;
> - if (!kvm_enabled()) {
> + if (tcg_enabled() || qtest_enabled()) {
> qdev_property_add_static(DEVICE(obj), &arm_cpu_has_neon_property);
> }
> }
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
© 2016 - 2025 Red Hat, Inc.