target/s390x: set has_deprecated_props flag

[PATCH] target/s390x: set has_deprecated_props flag

Collin Walling posted 1 patch 4 months, 2 weeks ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20250630024404.940882-1-walling@linux.ibm.com

Maintainers: Thomas Huth <thuth@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, David Hildenbrand <david@redhat.com>, Ilya Leoshkevich <iii@linux.ibm.com>

target/s390x/cpu_models_system.c | 3 +++
1 file changed, 3 insertions(+)

Expand all Fold all

[PATCH] target/s390x: set has_deprecated_props flag

Posted by Collin Walling 4 months, 2 weeks ago

Now that the deprecated_props is an optional field, the expansion method
must now set the "has_deprecated_props" flag in order for the data to be
output from the response.

Fixes: 448553bb7c (qapi: Make CpuModelExpansionInfo::deprecated-props optional and generic)
Signed-off-by: Collin Walling <walling@linux.ibm.com>
---
 target/s390x/cpu_models_system.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/target/s390x/cpu_models_system.c b/target/s390x/cpu_models_system.c
index 9d84faa3c9e..5b846048675 100644
--- a/target/s390x/cpu_models_system.c
+++ b/target/s390x/cpu_models_system.c
@@ -252,6 +252,9 @@ CpuModelExpansionInfo *qmp_query_cpu_model_expansion(CpuModelExpansionType type,
 
     s390_feat_bitmap_to_ascii(deprecated_feats,
                               &expansion_info->deprecated_props, list_add_feat);
+
+    expansion_info->has_deprecated_props = !!expansion_info->deprecated_props;
+
     return expansion_info;
 }
 
-- 
2.49.0

Re: [PATCH] target/s390x: set has_deprecated_props flag

Posted by Philippe Mathieu-Daudé 4 months, 2 weeks ago

On 30/6/25 04:44, Collin Walling wrote:
> Now that the deprecated_props is an optional field, the expansion method
> must now set the "has_deprecated_props" flag in order for the data to be
> output from the response.
> 
> Fixes: 448553bb7c (qapi: Make CpuModelExpansionInfo::deprecated-props optional and generic)
> Signed-off-by: Collin Walling <walling@linux.ibm.com>
> ---
>   target/s390x/cpu_models_system.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/target/s390x/cpu_models_system.c b/target/s390x/cpu_models_system.c
> index 9d84faa3c9e..5b846048675 100644
> --- a/target/s390x/cpu_models_system.c
> +++ b/target/s390x/cpu_models_system.c
> @@ -252,6 +252,9 @@ CpuModelExpansionInfo *qmp_query_cpu_model_expansion(CpuModelExpansionType type,
>   
>       s390_feat_bitmap_to_ascii(deprecated_feats,
>                                 &expansion_info->deprecated_props, list_add_feat);
> +
> +    expansion_info->has_deprecated_props = !!expansion_info->deprecated_props;
> +
>       return expansion_info;
>   }
>   

Oops.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>