i386/cpu: Clean Up Reserved CPUID Leaves for Intel

[PATCH 0/4] i386/cpu: Clean Up Reserved CPUID Leaves for Intel

Posted by Zhao Liu 4 months, 3 weeks ago

Hi,

Since the previsor unified cache model series has already introduced a
new compat property "x-vendor-cpuid-only-v2", it's a chance to once
again consolidate more vendor-specific CPUIDs.

I also checked the CPUID leaves currently supported by Intel & AMD and
found that since the previous "x-vendor-cpuid-only," AMD has already
cleaned up the Intel-specific CPUIDs quite well.

As for Intel, the only cleanup needed is for the "extended function
CPUID" leaves (0x80000000~0x80000008). That's what this series does.

This series is based on:

<20250626083105.2581859-1-zhao1.liu@intel.com>

Or you can find the code at:

https://gitlab.com/zhao.liu/qemu/-/tree/cache-model-v2.6-rebase-06-23-2025

Thanks and Best Regards,
Zhao
---
Zhao Liu (4):
  i386/cpu: Mark EBX/ECX/EDX in CPUID 0x80000000 leaf as reserved for
    Intel
  i386/cpu: Mark CPUID 0x80000007[EBX] as reserved for Intel
  i386/cpu: Mark ECX/EDX in CPUID 0x80000008 leaf as reserved for Intel
  i386/cpu: Reorder CPUID leaves in cpu_x86_cpuid()

 target/i386/cpu.c | 83 ++++++++++++++++++++++++++++-------------------
 1 file changed, 49 insertions(+), 34 deletions(-)

-- 
2.34.1

Re: [PATCH 0/4] i386/cpu: Clean Up Reserved CPUID Leaves for Intel

Posted by Tao Su 4 months, 1 week ago

On Fri, Jun 27, 2025 at 11:51:25AM +0800, Zhao Liu wrote:
> Hi,
> 
> Since the previsor unified cache model series has already introduced a
> new compat property "x-vendor-cpuid-only-v2", it's a chance to once
> again consolidate more vendor-specific CPUIDs.
> 
> I also checked the CPUID leaves currently supported by Intel & AMD and
> found that since the previous "x-vendor-cpuid-only," AMD has already
> cleaned up the Intel-specific CPUIDs quite well.
> 
> As for Intel, the only cleanup needed is for the "extended function
> CPUID" leaves (0x80000000~0x80000008). That's what this series does.
> 
> This series is based on:
> 
> <20250626083105.2581859-1-zhao1.liu@intel.com>
> 
> Or you can find the code at:
> 
> https://gitlab.com/zhao.liu/qemu/-/tree/cache-model-v2.6-rebase-06-23-2025

For the whole series,

Reviewed-by: Tao Su <tao1.su@linux.intel.com>

> 
> Thanks and Best Regards,
> Zhao
> ---
> Zhao Liu (4):
>   i386/cpu: Mark EBX/ECX/EDX in CPUID 0x80000000 leaf as reserved for
>     Intel
>   i386/cpu: Mark CPUID 0x80000007[EBX] as reserved for Intel
>   i386/cpu: Mark ECX/EDX in CPUID 0x80000008 leaf as reserved for Intel
>   i386/cpu: Reorder CPUID leaves in cpu_x86_cpuid()
> 
>  target/i386/cpu.c | 83 ++++++++++++++++++++++++++++-------------------
>  1 file changed, 49 insertions(+), 34 deletions(-)
> 
> -- 
> 2.34.1
> 
>

Re: [PATCH 0/4] i386/cpu: Clean Up Reserved CPUID Leaves for Intel

Posted by Xiaoyao Li 4 months, 3 weeks ago

On 6/27/2025 11:51 AM, Zhao Liu wrote:
> Hi,
> 
> Since the previsor unified cache model series has already introduced a
> new compat property "x-vendor-cpuid-only-v2", it's a chance to once
> again consolidate more vendor-specific CPUIDs.

Please provide the link to the patch that introduced 
"x-vendor-cpuid-only-v2"

When talking about vendor-specific CPUIDs, there are multiple vendors 
for x86, including Intel, AMD, Hygon and Zhaoxin. From the patches, you 
are only dealing with Intel specifically. So a basic question is, why 
not rename "x-vendor-cpuid-only-v2" to "x-intel-cpuid-only"?


> I also checked the CPUID leaves currently supported by Intel & AMD and
> found that since the previous "x-vendor-cpuid-only," AMD has already
> cleaned up the Intel-specific CPUIDs quite well.
> 
> As for Intel, the only cleanup needed is for the "extended function
> CPUID" leaves (0x80000000~0x80000008). That's what this series does.
> 
> This series is based on:
> 
> <20250626083105.2581859-1-zhao1.liu@intel.com>
> 
> Or you can find the code at:
> 
> https://gitlab.com/zhao.liu/qemu/-/tree/cache-model-v2.6-rebase-06-23-2025
> 
> Thanks and Best Regards,
> Zhao
> ---
> Zhao Liu (4):
>    i386/cpu: Mark EBX/ECX/EDX in CPUID 0x80000000 leaf as reserved for
>      Intel
>    i386/cpu: Mark CPUID 0x80000007[EBX] as reserved for Intel
>    i386/cpu: Mark ECX/EDX in CPUID 0x80000008 leaf as reserved for Intel
>    i386/cpu: Reorder CPUID leaves in cpu_x86_cpuid()
> 
>   target/i386/cpu.c | 83 ++++++++++++++++++++++++++++-------------------
>   1 file changed, 49 insertions(+), 34 deletions(-)
>