hw/arm/aspeed: bletchley: update hw strap values

[PATCH] hw/arm/aspeed: bletchley: update hw strap values

Patrick Williams posted 1 patch 4 months, 4 weeks ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20250619035850.2682690-1-patrick@stwcx.xyz

Maintainers: "Cédric Le Goater" <clg@kaod.org>, Peter Maydell <peter.maydell@linaro.org>, Steven Lee <steven_lee@aspeedtech.com>, Troy Lee <leetroy@gmail.com>, Jamin Lin <jamin_lin@aspeedtech.com>, Andrew Jeffery <andrew@codeconstruct.com.au>, Joel Stanley <joel@jms.id.au>

hw/arm/aspeed.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

Expand all Fold all

[PATCH] hw/arm/aspeed: bletchley: update hw strap values

Posted by Patrick Williams 4 months, 4 weeks ago

Update the Bletchley hardware strap register values
per actual hardware:
```
root@bmc:~# devmem 0x1e6e2500
0x00002000
root@bmc:~# devmem 0x1e6e2510
0x00000801
```

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
---
 hw/arm/aspeed.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
index b0965ef8a0..94897505f8 100644
--- a/hw/arm/aspeed.c
+++ b/hw/arm/aspeed.c
@@ -198,9 +198,8 @@ struct AspeedMachineState {
 #define FUJI_BMC_HW_STRAP2    0x00000000
 
 /* Bletchley hardware value */
-/* TODO: Leave same as EVB for now. */
-#define BLETCHLEY_BMC_HW_STRAP1 AST2600_EVB_HW_STRAP1
-#define BLETCHLEY_BMC_HW_STRAP2 AST2600_EVB_HW_STRAP2
+#define BLETCHLEY_BMC_HW_STRAP1 0x00002000
+#define BLETCHLEY_BMC_HW_STRAP2 0x00000801
 
 /* Qualcomm DC-SCM hardware value */
 #define QCOM_DC_SCM_V1_BMC_HW_STRAP1  0x00000000
-- 
2.49.0

Re: [PATCH] hw/arm/aspeed: bletchley: update hw strap values

Posted by Cédric Le Goater 4 months, 4 weeks ago

On 6/19/25 05:58, Patrick Williams wrote:
> Update the Bletchley hardware strap register values
> per actual hardware:
> ```
> root@bmc:~# devmem 0x1e6e2500
> 0x00002000
> root@bmc:~# devmem 0x1e6e2510
> 0x00000801
> ```
> 
> Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
> ---
>   hw/arm/aspeed.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
> index b0965ef8a0..94897505f8 100644
> --- a/hw/arm/aspeed.c
> +++ b/hw/arm/aspeed.c
> @@ -198,9 +198,8 @@ struct AspeedMachineState {
>   #define FUJI_BMC_HW_STRAP2    0x00000000
>   
>   /* Bletchley hardware value */
> -/* TODO: Leave same as EVB for now. */
> -#define BLETCHLEY_BMC_HW_STRAP1 AST2600_EVB_HW_STRAP1
> -#define BLETCHLEY_BMC_HW_STRAP2 AST2600_EVB_HW_STRAP2
> +#define BLETCHLEY_BMC_HW_STRAP1 0x00002000
> +#define BLETCHLEY_BMC_HW_STRAP2 0x00000801
>   
>   /* Qualcomm DC-SCM hardware value */
>   #define QCOM_DC_SCM_V1_BMC_HW_STRAP1  0x00000000



Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.