[v2] esp.c: only allow ESP commands permitted in the current mode

[PATCH v2 3/7] esp.h: remove separate ESPState typedef

Posted by Mark Cave-Ayland 5 months ago

This is not needed as it is now handled by the OBJECT_DECLARE_SIMPLE_TYPE() macro.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
---
 include/hw/scsi/esp.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/include/hw/scsi/esp.h b/include/hw/scsi/esp.h
index 533d856aa3..c9afcb7cac 100644
--- a/include/hw/scsi/esp.h
+++ b/include/hw/scsi/esp.h
@@ -14,8 +14,6 @@ typedef void (*ESPDMAMemoryReadWriteFunc)(void *opaque, uint8_t *buf, int len);
 #define ESP_FIFO_SZ 16
 #define ESP_CMDFIFO_SZ 32
 
-typedef struct ESPState ESPState;
-
 #define TYPE_ESP "esp"
 OBJECT_DECLARE_SIMPLE_TYPE(ESPState, ESP)
 
-- 
2.39.5

Re: [PATCH v2 3/7] esp.h: remove separate ESPState typedef

Posted by Philippe Mathieu-Daudé 4 months, 1 week ago

On 18/6/25 08:12, Mark Cave-Ayland wrote:
> This is not needed as it is now handled by the OBJECT_DECLARE_SIMPLE_TYPE() macro.
> 
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
>   include/hw/scsi/esp.h | 2 --
>   1 file changed, 2 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>