[PATCH 0/3] tracetool:cleanup "if(true)" check from trace_foo()

Tanish Desai posted 3 patches 5 months ago
Failed in applying to current master (apply log)
Maintainers: Stefan Hajnoczi <stefanha@redhat.com>, Mads Ynddal <mads@ynddal.dk>
scripts/tracetool/backend/__init__.py |  3 +++
scripts/tracetool/backend/dtrace.py   |  3 ++-
scripts/tracetool/backend/ftrace.py   |  3 ---
scripts/tracetool/backend/log.py      |  9 +--------
scripts/tracetool/backend/simple.py   | 11 +----------
scripts/tracetool/backend/syslog.py   | 11 +----------
scripts/tracetool/backend/ust.py      |  2 +-
scripts/tracetool/format/h.py         | 13 +++++++++----
8 files changed, 18 insertions(+), 37 deletions(-)
[PATCH 0/3] tracetool:cleanup "if(true)" check from trace_foo()
Posted by Tanish Desai 5 months ago
This series of patch aims to removes the leftover if (true) condition from trace_foo, a remnant from the TCG tracing feature removal.
It replaces it with a proper trace_event_get_state(...) check where necessary(for log/simple/syslog and ftrace backend).
Additionally, this change centralizes the generation of trace_event_get_state(...) calls into format/h.py,
eliminating redundant code across individual backends.
This cleanup results in more consistent and less repetitive backend code.

Tanish Desai (3):
  tracetool: removed the unused vcpu property
  tracetool: introduce generate_unconditional
  tracetool: remove redundant event_get_state checks

 scripts/tracetool/backend/__init__.py |  3 +++
 scripts/tracetool/backend/dtrace.py   |  3 ++-
 scripts/tracetool/backend/ftrace.py   |  3 ---
 scripts/tracetool/backend/log.py      |  9 +--------
 scripts/tracetool/backend/simple.py   | 11 +----------
 scripts/tracetool/backend/syslog.py   | 11 +----------
 scripts/tracetool/backend/ust.py      |  2 +-
 scripts/tracetool/format/h.py         | 13 +++++++++----
 8 files changed, 18 insertions(+), 37 deletions(-)

-- 
2.34.1
Re: [PATCH 0/3] tracetool:cleanup "if(true)" check from trace_foo()
Posted by Stefan Hajnoczi 5 months ago
On Mon, Jun 16, 2025 at 08:12:19PM +0000, Tanish Desai wrote:
> This series of patch aims to removes the leftover if (true) condition from trace_foo, a remnant from the TCG tracing feature removal.
> It replaces it with a proper trace_event_get_state(...) check where necessary(for log/simple/syslog and ftrace backend).
> Additionally, this change centralizes the generation of trace_event_get_state(...) calls into format/h.py,
> eliminating redundant code across individual backends.
> This cleanup results in more consistent and less repetitive backend code.

CCing Alex Bennée, who authored commit 126d4123c50a ("tracing: excise
the tcg related from tracetool").

> 
> Tanish Desai (3):
>   tracetool: removed the unused vcpu property
>   tracetool: introduce generate_unconditional
>   tracetool: remove redundant event_get_state checks
> 
>  scripts/tracetool/backend/__init__.py |  3 +++
>  scripts/tracetool/backend/dtrace.py   |  3 ++-
>  scripts/tracetool/backend/ftrace.py   |  3 ---
>  scripts/tracetool/backend/log.py      |  9 +--------
>  scripts/tracetool/backend/simple.py   | 11 +----------
>  scripts/tracetool/backend/syslog.py   | 11 +----------
>  scripts/tracetool/backend/ust.py      |  2 +-
>  scripts/tracetool/format/h.py         | 13 +++++++++----
>  8 files changed, 18 insertions(+), 37 deletions(-)
> 
> -- 
> 2.34.1
>