[RFC PATCH] target/i386: Report TPR accesses to HVF

Philippe Mathieu-Daudé posted 1 patch 5 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20250616090632.55214-1-philmd@linaro.org
Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Zhao Liu <zhao1.liu@intel.com>
target/i386/helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[RFC PATCH] target/i386: Report TPR accesses to HVF
Posted by Philippe Mathieu-Daudé 5 months ago
HVF should be able to handle task priority register accesses.

Cc: Sergio Andres Gomez Del Real <Sergio.G.DelReal@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
RFC: Untested as I don't have access to such setup, noticed
during code review.
---
 target/i386/helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/i386/helper.c b/target/i386/helper.c
index e0aaed3c4c4..a0555e74cc6 100644
--- a/target/i386/helper.c
+++ b/target/i386/helper.c
@@ -549,7 +549,7 @@ void cpu_report_tpr_access(CPUX86State *env, TPRAccess access)
     X86CPU *cpu = env_archcpu(env);
     CPUState *cs = env_cpu(env);
 
-    if (kvm_enabled() || whpx_enabled() || nvmm_enabled()) {
+    if (kvm_enabled() || whpx_enabled() || nvmm_enabled() || hvf_enabled()) {
         env->tpr_access_type = access;
 
         cpu_interrupt(cs, CPU_INTERRUPT_TPR);
-- 
2.49.0


Re: [RFC PATCH] target/i386: Report TPR accesses to HVF
Posted by Zhao Liu 4 months, 2 weeks ago
On Mon, Jun 16, 2025 at 11:06:32AM +0200, Philippe Mathieu-Daudé wrote:
> Date: Mon, 16 Jun 2025 11:06:32 +0200
> From: Philippe Mathieu-Daudé <philmd@linaro.org>
> Subject: [RFC PATCH] target/i386: Report TPR accesses to HVF
> X-Mailer: git-send-email 2.49.0
> 
> HVF should be able to handle task priority register accesses.
> 
> Cc: Sergio Andres Gomez Del Real <Sergio.G.DelReal@gmail.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> RFC: Untested as I don't have access to such setup, noticed
> during code review.
> ---
>  target/i386/helper.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Untested too. But code looks fine for me,

Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
Re: [RFC PATCH] target/i386: Report TPR accesses to HVF
Posted by Philippe Mathieu-Daudé 4 months, 2 weeks ago
Ping?

On 16/6/25 11:06, Philippe Mathieu-Daudé wrote:
> HVF should be able to handle task priority register accesses.
> 
> Cc: Sergio Andres Gomez Del Real <Sergio.G.DelReal@gmail.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> RFC: Untested as I don't have access to such setup, noticed
> during code review.
> ---
>   target/i386/helper.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/i386/helper.c b/target/i386/helper.c
> index e0aaed3c4c4..a0555e74cc6 100644
> --- a/target/i386/helper.c
> +++ b/target/i386/helper.c
> @@ -549,7 +549,7 @@ void cpu_report_tpr_access(CPUX86State *env, TPRAccess access)
>       X86CPU *cpu = env_archcpu(env);
>       CPUState *cs = env_cpu(env);
>   
> -    if (kvm_enabled() || whpx_enabled() || nvmm_enabled()) {
> +    if (kvm_enabled() || whpx_enabled() || nvmm_enabled() || hvf_enabled()) {
>           env->tpr_access_type = access;
>   
>           cpu_interrupt(cs, CPU_INTERRUPT_TPR);