[PATCH v3 0/2] ramfb: Add property to control if load the romfile

Shaoqin Huang posted 2 patches 5 months, 1 week ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20250609073408.2083831-1-shahuang@redhat.com
Maintainers: Peter Maydell <peter.maydell@linaro.org>, Gerd Hoffmann <kraxel@redhat.com>, Alex Williamson <alex.williamson@redhat.com>, "Cédric Le Goater" <clg@redhat.com>
There is a newer version of this series
hw/arm/virt.c                 | 3 +++
hw/display/ramfb-standalone.c | 4 +++-
hw/display/ramfb-stubs.c      | 2 +-
hw/display/ramfb.c            | 6 ++++--
hw/vfio/display.c             | 4 ++--
hw/vfio/pci.c                 | 1 +
hw/vfio/pci.h                 | 1 +
include/hw/display/ramfb.h    | 2 +-
8 files changed, 16 insertions(+), 7 deletions(-)
[PATCH v3 0/2] ramfb: Add property to control if load the romfile
Posted by Shaoqin Huang 5 months, 1 week ago
Now the ramfb will load the vgabios-ramfb.bin unconditionally, but only
the x86 need the vgabios-ramfb.bin, this can cause that when use the
release package on arm64 it can't find the vgabios-ramfb.bin.

Because only seabios will use the vgabios-ramfb.bin, load the rom logic
is x86-specific. For other !x86 platforms, the edk2 ships an EFI driver
for ramfb, so they don't need to load the romfile.

So add a new property use_legacy_x86_rom in both ramfb and vfio_pci
device, because the vfio display also use the ramfb_setup() to load
the vgabios-ramfb.bin file.

After have this property, the machine type can set the compatibility to
not load the vgabios-ramfb.bin if the arch doesn't need it.

I set the "use-legacy-x86-rom" property on arm to false, thus the arm won't load
the vgabios-ramfb.bin.

I want to set the "use-legacy-x86-rom" property to false by default, and only
set it to true on x86, but I didn't find the similiar thing like the
arm_virt_compat, so I didn't use this way.

Changelog:
---------
v2 -> v3:
  - Fix the underscore error.
  - Add a new patch to set the property in arm compatibility.
v1 -> v2:
  - Change the property name.

v2: https://lore.kernel.org/all/20250606070234.2063451-1-shahuang@redhat.com/
v1: https://lore.kernel.org/all/20250605030351.2056571-1-shahuang@redhat.com/

Shaoqin Huang (2):
  ramfb: Add property to control if load the romfile
  hw/arm: Add the romfile compatatibility

 hw/arm/virt.c                 | 3 +++
 hw/display/ramfb-standalone.c | 4 +++-
 hw/display/ramfb-stubs.c      | 2 +-
 hw/display/ramfb.c            | 6 ++++--
 hw/vfio/display.c             | 4 ++--
 hw/vfio/pci.c                 | 1 +
 hw/vfio/pci.h                 | 1 +
 include/hw/display/ramfb.h    | 2 +-
 8 files changed, 16 insertions(+), 7 deletions(-)

-- 
2.40.1