Parent of VirtIOMEMClass is VirtioDeviceClass rather than VirtIODevice.

Fixes: 910b25766b33 ("virtio-mem: Paravirtualized memory hot(un)plug")
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
---
 include/hw/virtio/virtio-mem.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/hw/virtio/virtio-mem.h b/include/hw/virtio/virtio-mem.h
index bc4f787772..93fdf9e432 100644
--- a/include/hw/virtio/virtio-mem.h
+++ b/include/hw/virtio/virtio-mem.h
@@ -134,7 +134,7 @@ struct VirtioMemSystemReset {
 
 struct VirtIOMEMClass {
     /* private */
-    VirtIODevice parent;
+    VirtioDeviceClass parent;
 
     /* public */
     void (*fill_device_info)(const VirtIOMEM *vmen, VirtioMEMDeviceInfo *vi);
-- 
2.34.1

On 4/6/25 10:47, Zhenzhong Duan wrote:
> Parent of VirtIOMEMClass is VirtioDeviceClass rather than VirtIODevice.
> 
> Fixes: 910b25766b33 ("virtio-mem: Paravirtualized memory hot(un)plug")
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
> ---
>   include/hw/virtio/virtio-mem.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/hw/virtio/virtio-mem.h b/include/hw/virtio/virtio-mem.h
> index bc4f787772..93fdf9e432 100644
> --- a/include/hw/virtio/virtio-mem.h
> +++ b/include/hw/virtio/virtio-mem.h
> @@ -134,7 +134,7 @@ struct VirtioMemSystemReset {
>   
>   struct VirtIOMEMClass {
>       /* private */
> -    VirtIODevice parent;
> +    VirtioDeviceClass parent;

Ouch, nice catch.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

On 04.06.25 10:47, Zhenzhong Duan wrote:
> Parent of VirtIOMEMClass is VirtioDeviceClass rather than VirtIODevice.
> 
> Fixes: 910b25766b33 ("virtio-mem: Paravirtualized memory hot(un)plug")
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
> ---
>   include/hw/virtio/virtio-mem.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/hw/virtio/virtio-mem.h b/include/hw/virtio/virtio-mem.h
> index bc4f787772..93fdf9e432 100644
> --- a/include/hw/virtio/virtio-mem.h
> +++ b/include/hw/virtio/virtio-mem.h
> @@ -134,7 +134,7 @@ struct VirtioMemSystemReset {
>   
>   struct VirtIOMEMClass {
>       /* private */
> -    VirtIODevice parent;
> +    VirtioDeviceClass parent;

We seem to have the same problem for VirtIOPMEMClass. Can you check the 
other devices and send fixes? Thanks!

-- 
Cheers,

David / dhildenb

On 04.06.25 10:47, Zhenzhong Duan wrote:
> Parent of VirtIOMEMClass is VirtioDeviceClass rather than VirtIODevice.
> 
> Fixes: 910b25766b33 ("virtio-mem: Paravirtualized memory hot(un)plug")
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
> ---
>   include/hw/virtio/virtio-mem.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/hw/virtio/virtio-mem.h b/include/hw/virtio/virtio-mem.h
> index bc4f787772..93fdf9e432 100644
> --- a/include/hw/virtio/virtio-mem.h
> +++ b/include/hw/virtio/virtio-mem.h
> @@ -134,7 +134,7 @@ struct VirtioMemSystemReset {
>   
>   struct VirtIOMEMClass {
>       /* private */
> -    VirtIODevice parent;
> +    VirtioDeviceClass parent;

Reviewed-by: David Hildenbrand <david@redhat.com>

I assume it's not currently a real problem because VirtIODevice is 
bigger than VirtioDeviceClass?

Or are you aware of any existing problems with that?

-- 
Cheers,

David / dhildenb