[v2] tcg/optimize: Track and use known 1's

[PATCH v2 27/27] tcg/optimize: Simplify fold_eqv constant checks

Posted by Richard Henderson 5 months, 2 weeks ago

Both cases are handled by fold_xor after conversion.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 tcg/optimize.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/tcg/optimize.c b/tcg/optimize.c
index a48ddd9171..62a128bc9b 100644
--- a/tcg/optimize.c
+++ b/tcg/optimize.c
@@ -1948,9 +1948,7 @@ static bool fold_eqv(OptContext *ctx, TCGOp *op)
     uint64_t z_mask, o_mask, s_mask;
     TempOptInfo *t1, *t2;
 
-    if (fold_const2_commutative(ctx, op) ||
-        fold_xi_to_x(ctx, op, -1) ||
-        fold_xi_to_not(ctx, op, 0)) {
+    if (fold_const2_commutative(ctx, op)) {
         return true;
     }
 
-- 
2.43.0

Re: [PATCH v2 27/27] tcg/optimize: Simplify fold_eqv constant checks

Posted by Pierrick Bouvier 4 months, 3 weeks ago

On 6/3/25 1:09 AM, Richard Henderson wrote:
> Both cases are handled by fold_xor after conversion.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   tcg/optimize.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)

Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>