[PATCH 2/3] i386/tdx: Fix the typo of the comment of struct TdxGuest

Xiaoyao Li posted 3 patches 5 months, 2 weeks ago
Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Zhao Liu <zhao1.liu@intel.com>, Marcelo Tosatti <mtosatti@redhat.com>
[PATCH 2/3] i386/tdx: Fix the typo of the comment of struct TdxGuest
Posted by Xiaoyao Li 5 months, 2 weeks ago
Change sha348 to sha384.

Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
---
 target/i386/kvm/tdx.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/target/i386/kvm/tdx.h b/target/i386/kvm/tdx.h
index 04b5afe199f9..8dd66e90149b 100644
--- a/target/i386/kvm/tdx.h
+++ b/target/i386/kvm/tdx.h
@@ -40,9 +40,9 @@ typedef struct TdxGuest {
     bool initialized;
     uint64_t attributes;    /* TD attributes */
     uint64_t xfam;
-    char *mrconfigid;       /* base64 encoded sha348 digest */
-    char *mrowner;          /* base64 encoded sha348 digest */
-    char *mrownerconfig;    /* base64 encoded sha348 digest */
+    char *mrconfigid;       /* base64 encoded sha384 digest */
+    char *mrowner;          /* base64 encoded sha384 digest */
+    char *mrownerconfig;    /* base64 encoded sha384 digest */
 
     MemoryRegion *tdvf_mr;
     TdxFirmware tdvf;
-- 
2.43.0
Re: [PATCH 2/3] i386/tdx: Fix the typo of the comment of struct TdxGuest
Posted by Igor Mammedov 5 months, 2 weeks ago
On Tue,  3 Jun 2025 01:03:04 -0400
Xiaoyao Li <xiaoyao.li@intel.com> wrote:

> Change sha348 to sha384.
> 
> Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>

Reviewed-by: Igor Mammedov <imammedo@redhat.com>

> ---
>  target/i386/kvm/tdx.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/target/i386/kvm/tdx.h b/target/i386/kvm/tdx.h
> index 04b5afe199f9..8dd66e90149b 100644
> --- a/target/i386/kvm/tdx.h
> +++ b/target/i386/kvm/tdx.h
> @@ -40,9 +40,9 @@ typedef struct TdxGuest {
>      bool initialized;
>      uint64_t attributes;    /* TD attributes */
>      uint64_t xfam;
> -    char *mrconfigid;       /* base64 encoded sha348 digest */
> -    char *mrowner;          /* base64 encoded sha348 digest */
> -    char *mrownerconfig;    /* base64 encoded sha348 digest */
> +    char *mrconfigid;       /* base64 encoded sha384 digest */
> +    char *mrowner;          /* base64 encoded sha384 digest */
> +    char *mrownerconfig;    /* base64 encoded sha384 digest */
>  
>      MemoryRegion *tdvf_mr;
>      TdxFirmware tdvf;
Re: [PATCH 2/3] i386/tdx: Fix the typo of the comment of struct TdxGuest
Posted by Daniel P. Berrangé 5 months, 2 weeks ago
On Tue, Jun 03, 2025 at 01:03:04AM -0400, Xiaoyao Li wrote:
> Change sha348 to sha384.
> 
> Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
> ---
>  target/i386/kvm/tdx.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|