qcow2: Add keep_data_file command-line option

[PATCH 0/4] qcow2: Add keep_data_file command-line option

Hanna Czenczek posted 4 patches 8 months, 2 weeks ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20250530084448.192369-1-hreitz@redhat.com

Maintainers: Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>

include/block/block_int-common.h |  1 +
block/qcow2.c                    | 78 +++++++++++++++++++++++++++++---
tests/qemu-iotests/082.out       | 18 ++++++++
tests/qemu-iotests/244           | 71 +++++++++++++++++++++++++++++
tests/qemu-iotests/244.out       | 53 ++++++++++++++++++++++
tests/qemu-iotests/common.filter |  2 +-
6 files changed, 216 insertions(+), 7 deletions(-)

Expand all Fold all

[PATCH 0/4] qcow2: Add keep_data_file command-line option

Posted by Hanna Czenczek 8 months, 2 weeks ago

Hi,

This series adds a keep_data_file qemu-img create option to qcow2 that
makes it keep the given external data file for a newly created image
instead of overwriting it.

This allows to create a qcow2 image for an existing raw image using the
qemu-img create command, which previously wasn’t easily possible
(besides work-arounds using a temporary data file or qemu-img amend).

(The “proper” way of doing it without this option is to use QMP
blockdev-create.)

This new option is a pure qemu-img create (i.e. command-line) option,
not available via QMP, because it does not make any sense there.  See
patch 1 for more explanation.

(See https://issues.redhat.com/browse/RHEL-73509 for perhaps a bit more
context.)


Hanna Czenczek (4):
  qcow2: Add keep_data_file command-line option
  qcow2: Simplify size round-up in co_create_opts
  iotests/common.filter: Sort keep_data_file
  iotests/244: Add test cases for keep_data_file

 include/block/block_int-common.h |  1 +
 block/qcow2.c                    | 78 +++++++++++++++++++++++++++++---
 tests/qemu-iotests/082.out       | 18 ++++++++
 tests/qemu-iotests/244           | 71 +++++++++++++++++++++++++++++
 tests/qemu-iotests/244.out       | 53 ++++++++++++++++++++++
 tests/qemu-iotests/common.filter |  2 +-
 6 files changed, 216 insertions(+), 7 deletions(-)

-- 
2.49.0

Re: [PATCH 0/4] qcow2: Add keep_data_file command-line option

Posted by Hanna Czenczek 2 months, 2 weeks ago

Ping

On 30.05.25 10:44, Hanna Czenczek wrote:
> Hi,
>
> This series adds a keep_data_file qemu-img create option to qcow2 that
> makes it keep the given external data file for a newly created image
> instead of overwriting it.
>
> This allows to create a qcow2 image for an existing raw image using the
> qemu-img create command, which previously wasn’t easily possible
> (besides work-arounds using a temporary data file or qemu-img amend).
>
> (The “proper” way of doing it without this option is to use QMP
> blockdev-create.)
>
> This new option is a pure qemu-img create (i.e. command-line) option,
> not available via QMP, because it does not make any sense there.  See
> patch 1 for more explanation.
>
> (See https://issues.redhat.com/browse/RHEL-73509 for perhaps a bit more
> context.)
>
>
> Hanna Czenczek (4):
>    qcow2: Add keep_data_file command-line option
>    qcow2: Simplify size round-up in co_create_opts
>    iotests/common.filter: Sort keep_data_file
>    iotests/244: Add test cases for keep_data_file
>
>   include/block/block_int-common.h |  1 +
>   block/qcow2.c                    | 78 +++++++++++++++++++++++++++++---
>   tests/qemu-iotests/082.out       | 18 ++++++++
>   tests/qemu-iotests/244           | 71 +++++++++++++++++++++++++++++
>   tests/qemu-iotests/244.out       | 53 ++++++++++++++++++++++
>   tests/qemu-iotests/common.filter |  2 +-
>   6 files changed, 216 insertions(+), 7 deletions(-)
>